[GRASS-dev] [GRASS GIS] #1949: module gui doesn't release if no map display window

#1949: module gui doesn't release if no map display window
-------------------------+--------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.3
Component: wxGUI | Version: svn-develbranch6
Keywords: module guis | Platform: All
      Cpu: All |
-------------------------+--------------------------------------------------
Hi,

(wingrass 6.5svn nightly build r55955)

I had closed the Map Display window since I was just testing data import
and looking at processing reports.

When running a module in wxGUI (desktop icon startup) the control buttons
that are greyed out during the run never come back.

test module: g.region from the menu, select -p flag from the Print tab and
[Run]

traceback error printed to the output tab:
{{{
Traceback (most recent call last):
   File "C:\Program Files\GRASS GIS
6.5.svn\etc\wxpython\gui_core\goutput.py", line 867, in
OnCmdDone

event.onDone(cmd = event.cmd, returncode = event.returncode)
   File "C:\Program Files\GRASS GIS
6.5.svn\etc\wxpython\gui_core\forms.py", line 595, in OnDone

display = self.parent.GetLayerTree().GetMapDisplay()
AttributeError
:
'NoneType' object has no attribute 'GetMapDisplay'
}}}

tested and the same happens in Linux.

thanks,
Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1949&gt;
GRASS GIS <http://grass.osgeo.org>

#1949: module gui doesn't release if no map display window
-------------------------+--------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.3
Component: wxGUI | Version: svn-develbranch6
Keywords: module guis | Platform: All
      Cpu: All |
-------------------------+--------------------------------------------------

Comment(by annakrat):

Replying to [ticket:1949 hamish]:
> When running a module in wxGUI (desktop icon startup) the control
buttons that are greyed out during the run never come back.

What exactly do you mean with control buttons?

>
> test module: g.region from the menu, select -p flag from the Print tab
and [Run]
>
> traceback error printed to the output tab:
> {{{
> Traceback (most recent call last):
>
> display = self.parent.GetLayerTree().GetMapDisplay()
> AttributeError
> :
> 'NoneType' object has no attribute 'GetMapDisplay'
> }}}
>
>

should be fixed in r55989.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1949#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#1949: module gui doesn't release if no map display window
-------------------------+--------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.3
Component: wxGUI | Version: svn-develbranch6
Keywords: module guis | Platform: All
      Cpu: All |
-------------------------+--------------------------------------------------

Comment(by hamish):

Replying to [comment:1 annakrat]:
> should be fixed in r55989.

Hi,

it works now, nice.

(please always commit to the dev branches first for testing, then backport
once testing is confirmed :). otherwise it gets hard to untangle later
since you can't trust the devbranch is newer, bulk backports erase
previous fixes, last minute typos make it into the rel.br.., etc. all
have happened in the past)

thanks,
Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1949#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#1949: module gui doesn't release if no map display window
-------------------------+--------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.3
Component: wxGUI | Version: svn-develbranch6
Keywords: module guis | Platform: All
      Cpu: All |
-------------------------+--------------------------------------------------

Comment(by hamish):

Replying to [comment:1 annakrat]:
> Replying to [ticket:1949 hamish]:
> > When running a module in wxGUI (desktop icon startup) the control
buttons that are greyed out during the run never come back.
>
> What exactly do you mean with control buttons?

[Close] [Run] [Copy] [Help]
at the bottom of the module gui window

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1949#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#1949: module gui doesn't release if no map display window
-------------------------+--------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.3
Component: wxGUI | Version: svn-develbranch6
Keywords: module guis | Platform: All
      Cpu: All |
-------------------------+--------------------------------------------------

Comment(by annakrat):

Replying to [comment:3 hamish]:
> > What exactly do you mean with control buttons?
>
> [Close] [Run] [Copy] [Help]
> at the bottom of the module gui window

Please test, it should be working now.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1949#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#1949: module gui doesn't release if no map display window
---------------------+------------------------------------------------------
  Reporter: hamish | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 6.4.3
Component: wxGUI | Version: svn-develbranch6
Resolution: fixed | Keywords: module guis
  Platform: All | Cpu: All
---------------------+------------------------------------------------------
Changes (by hamish):

  * status: new => closed
  * resolution: => fixed

Comment:

Replying to [comment:4 annakrat]:
> Please test, it should be working now.

(I did, see comment:2)

does it need to be merged to trunk?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1949#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#1949: module gui doesn't release if no map display window
---------------------+------------------------------------------------------
  Reporter: hamish | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 6.4.3
Component: wxGUI | Version: svn-develbranch6
Resolution: fixed | Keywords: module guis
  Platform: All | Cpu: All
---------------------+------------------------------------------------------

Comment(by annakrat):

Replying to [comment:5 hamish]:
> Replying to [comment:4 annakrat]:
> > Please test, it should be working now.
>
> (I did, see comment:2)

Another fix was needed.

>
>
> does it need to be merged to trunk?

no, it's rewritten there, I tested it and it's working.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1949#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

#1949: module gui doesn't release if no map display window
---------------------+------------------------------------------------------
  Reporter: hamish | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 6.4.3
Component: wxGUI | Version: svn-develbranch6
Resolution: fixed | Keywords: module guis
  Platform: All | Cpu: All
---------------------+------------------------------------------------------

Comment(by hamish):

Replying to [comment:6 annakrat]:
> Replying to [comment:5 hamish]:
> > Replying to [comment:4 annakrat]:
> > > Please test, it should be working now.
> >
> > (I did, see comment:2)
>
> Another fix was needed.

ok, well it worked for me then, and I just retested in latest wingrass
6.4.3svn nightly now and works again, so all's well.

> > does it need to be merged to trunk?
>
> no, it's rewritten there, I tested it and it's working.

ok, I was just noticing the lack-of-change.

thanks,
Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1949#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>