[GRASS-dev] [GRASS GIS] #1966: filesystem cruft from wingrass installer

GDAL · May 6, 2013, 12:26pm

#1966: filesystem cruft from wingrass installer
-----------------------+----------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
Type: defect | Status: new
Priority: trivial | Milestone: 7.0.0
Component: Packaging | Version: svn-trunk
Keywords: wingrass | Platform: MSWindows XP
Cpu: All |
-----------------------+----------------------------------------------------
Hi, noticed while fixing #1946, some wingrass installer cruft left behind
in the file system:

* `install_msruntime` dir from osgeo4w left over in ...\Local
Settings\Temp\ (all versions of grass). Delete and RMDir commands in the
nsis installer script don't catch it.

* Makefile and grassrc.tmpl file have made it into $GISBASE/demolocation
? (grass7 only)

Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1966>
GRASS GIS <http://grass.osgeo.org>

GDAL · May 6, 2013, 4:46pm

#1966: filesystem cruft from wingrass installer
-----------------------+----------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
Type: defect | Status: new
Priority: trivial | Milestone: 7.0.0
Component: Packaging | Version: svn-trunk
Keywords: wingrass | Platform: MSWindows XP
Cpu: All |
-----------------------+----------------------------------------------------

Comment(by neteler):

Replying to [ticket:1966 hamish]:
> * Makefile and grassrc.tmpl file have made it into
$GISBASE/demolocation ? (grass7 only)

See r39708 - Build demolocation using $(MKDIR) and $(INSTALL) instead of
"tar"

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1966#comment:1>
GRASS GIS <http://grass.osgeo.org>

GDAL · May 6, 2013, 9:08pm

#1966: filesystem cruft from wingrass installer
-----------------------+----------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
Type: defect | Status: new
Priority: trivial | Milestone: 7.0.0
Component: Packaging | Version: svn-trunk
Keywords: wingrass | Platform: MSWindows XP
Cpu: All |
-----------------------+----------------------------------------------------

Comment(by hamish):

the wingrass installer isn't using 'make install', it simply does a
recursive copy of src/demolocation/ from the svn checkout directory:

{{{
;Define the source path of the demolocation files

!define DEMOLOCATION_PATH
"c:\OSGeo4W@OSGEO4W_DIR_POSTFIX@\usr\src\grass_trunk\demolocation"
}}}
...
{{{
         ;Install demolocation into the GIS_DATABASE directory
         SetOutPath "$GIS_DATABASE\demolocation"
         File /r ${DEMOLOCATION_PATH}\*.*
}}}

so as long as that is the case, probably an explicit delete like is done
for .svn/ there is needed too.

Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1966#comment:2>
GRASS GIS <http://grass.osgeo.org>