[GRASS-dev] [GRASS GIS] #1990: audit high priority missing LFS-on-32bit in 6.x Makefiles

GRASS GIS GRASS GIS developer
1

#1990: audit high priority missing LFS-on-32bit in 6.x Makefiles
-----------------------+----------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 6.4.4
Component: Compiling | Version: svn-develbranch6
Keywords: LFS | Platform: MSWindows 7
      Cpu: x86-32 |
-----------------------+----------------------------------------------------
Hi,

moving this here from #1971 comment 5 (among others we can think of)

Glynn wrote:
> FWIW, the modules and libraries which use G_fseek() and G_ftell()
> in 7.x are:
{{{
general/g.rename
imagery/i.find
include/iostream
lib/dspf
lib/gis
lib/iostream
lib/raster
lib/raster3d
lib/rst/interp_float
lib/sites
lib/vector/Vlib
lib/vector/diglib
ps/ps.map
raster/r.coin
raster/r.cut.mat
raster/r.in.arc
raster/r.in.ascii
raster/r.in.bin
raster/r.in.mat
raster/r.in.poly
raster/r.in.xyz
raster3d/r3.in.bin
vector/v.in.dxf
vector/v.support
vector/v.vol.rst
}}}

r.in.bin done in r56207.

Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1990&gt;
GRASS GIS <http://grass.osgeo.org>

2

#1990: audit high priority missing LFS-on-32bit in 6.x Makefiles
-----------------------+----------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 6.4.3
Component: Compiling | Version: svn-develbranch6
Keywords: LFS | Platform: MSWindows 7
      Cpu: x86-32 |
-----------------------+----------------------------------------------------
Changes (by neteler):

  * milestone: 6.4.4 => 6.4.3

Comment:

Report for GRASS 6.4.svn:

{{{
[neteler@oboe grass64]$ find . -name "*.c" | xargs fgrep --files-with-
match "G_fseek"
./raster/r.in.bin/main.c
./lib/gis/seek.c

[neteler@oboe grass64]$ find . -name "*.c" | xargs fgrep --files-with-
match "G_ftell"
./raster/r.in.bin/main.c
./lib/gis/seek.c
}}}

r56207 has been backported to 6.4.svn time ago, also lib/gis/Makefile
contains the
related entry.

Any reason why this ticket is still open?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1990#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

3

#1990: audit high priority missing LFS-on-32bit in 6.x Makefiles
-----------------------+----------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 6.4.4
Component: Compiling | Version: svn-develbranch6
Keywords: LFS | Platform: MSWindows 7
      Cpu: x86-32 |
-----------------------+----------------------------------------------------
Changes (by hamish):

  * milestone: 6.4.3 => 6.4.4

Comment:

Replying to [comment:1 neteler]:
> Report for GRASS 6.4.svn:
...
> r56207 has been backported to 6.4.svn time ago, also lib/gis/Makefile
contains the
> related entry.
>
> Any reason why this ticket is still open?

yes,

G_fseek() and G_ftell() were only recently added to 6.x, and as seen in
the grep r.in.bin is the only module using them right now. it's modules
that use the standard libc6 fseek() and ftell() which need to be
checked/updated/Makefile'd.

regards,
Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1990#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

4

#1990: audit high priority missing LFS-on-32bit in 6.x Makefiles
-----------------------+----------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 6.4.5
Component: Compiling | Version: svn-develbranch6
Keywords: LFS | Platform: MSWindows 7
      Cpu: x86-32 |
-----------------------+----------------------------------------------------
Changes (by hamish):

  * milestone: 6.4.4 => 6.4.5

Comment:

bumping audit tasks down the road

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1990#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>