[GRASS-dev] [GRASS GIS] #1997: i.landsat.toar for grass-dev is missing the option for landsat8

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: unspecified
Keywords: i.landsat.toar | Platform: Linux
      Cpu: Unspecified |
----------------------------+-----------------------------------------------
Hi,

I just noticed that i.landsat.toar module for grass7 is missing the option
for the new landsat8 satelite , while i.landsat.toar for grass64 has is.

for reference for grass64 the sensor id is sensor=ot8 when invoking the
module.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1997&gt;
GRASS GIS <http://grass.osgeo.org>

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: unspecified
Keywords: i.landsat.toar | Platform: Linux
      Cpu: Unspecified |
----------------------------+-----------------------------------------------
Changes (by neteler):

  * type: enhancement => defect

Comment:

The updates (fixes) in GRASS 7 where not backported properly to G6:

http://trac.osgeo.org/grass/log/grass/trunk/imagery/i.landsat.toar
(r54898,r54904,r54907,r54910,r55068,r55114,r55499)

which prevented the following bugfixes provided by the original
author to be applied to the version in GRASS 7:
http://trac.osgeo.org/grass/log/grass/branches/releasebranch_6_4/imagery/i.landsat.toar
(r53589,r54844,r55376)

Essentially this fork needs to be consolidated.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1997#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: unspecified
Keywords: i.landsat.toar | Platform: Linux
      Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by mmetz):

Replying to [comment:1 neteler]:
> The updates (fixes) in GRASS 7 where not backported properly to G6:
>
> http://trac.osgeo.org/grass/log/grass/trunk/imagery/i.landsat.toar
> (r54898,r54904,r54907,r54910,r55068,r55114,r55499)
>
> which prevented the following bugfixes provided by the original
> author to be applied to the version in GRASS 7:
>
http://trac.osgeo.org/grass/log/grass/branches/releasebranch_6_4/imagery/i.landsat.toar
> (r53589,r54844,r55376)
>
> Essentially this fork needs to be consolidated.

i.landsat.toar is now consolidated across all branches. The only
difference is an option in trunk to print out selected metadata, absent in
GRASS 6.x.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1997#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.landsat.toar | Platform: All
      Cpu: Unspecified |
----------------------------+-----------------------------------------------
Changes (by neteler):

  * platform: Linux => All
  * version: unspecified => svn-trunk

Comment:

For the record: r56905, r56906, r56907, r56908

vesnikos, please close the ticket if it works for you

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1997#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.landsat.toar | Platform: All
      Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by nikosa):

Replying to [comment:3 neteler]:
> For the record: r56905, r56906, r56907, r56908

It works for me (tried with 56906). Tested using the Landsat 8 scene (and
respective MTL file) LC81260592013169LGN00(_MTL.txt).

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1997#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.landsat.toar | Platform: All
      Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by nikosa):

Replying to [comment:4 nikosa]:
> Replying to [comment:3 neteler]:
> > For the record: r56905, r56906, r56907, r56908
>
> It works for me (tried with 56906).

Retried with revision=56932M. All fine.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1997#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.landsat.toar | Platform: All
      Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by vesnikos):

some minor bugs during my tests:

1) Cosmetic typo at the description of sensor parameter:
   It says "Required only if 'metfile' not given (recommended by sanity)"
   should be ""Required only if 'metfile' not given (recommended for
sanity)
2) Band8 (panchomatic) has my nature 15m res. The algorithm uses the
regions resolution , and you cannot do anything to override it.
3) timestamp in r.info reads none, the date of acquisition is in the
metadata, so it should be properly implemented

eg: r.timestamp map=LC81840322013143LGN03_B10.toarr.1 date="$(date
-d'$DATE_ACQUIRED $SCENE_CENTER_TIME' -u +'%d %b %Y %H:%M:%S.%N %z')"

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1997#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.landsat.toar | Platform: All
      Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by nikosa):

Replying to [comment:6 vesnikos]:
> some minor bugs during my tests:

> 2) Band8 (panchomatic) has my nature 15m res. The algorithm uses the
regions resolution , and you cannot do anything to override it.

You can set the region resolution to the desired one! In my scripts I do
that. Maybe in this case an exception could be done and let the module
handle this?

> 3) timestamp in r.info reads none, the date of acquisition is in the
metadata, so it should be properly implemented

This would be also nice!

> eg: r.timestamp map=LC81840322013143LGN03_B10.toarr.1 date="$(date
-d'$DATE_ACQUIRED $SCENE_CENTER_TIME' -u +'%d %b %Y %H:%M:%S.%N %z')"

You can get the date using

{{{
i.landsat.toar -p metfile=MTLFile.txt lsatmet=date
}}}

and the ''decimal'' time

{{{
i.landsat.toar -p metfile=MTLFile.txt lsatmet=time
}}}

though, the "input_prefix=Dummy" and "output_prefix=Dummy" must be
defined.

For the records, if you import Landsat bands using the script found in
GRASS-Wiki
[http://grasswiki.osgeo.org/wiki/LANDSAT#Automated_data_import], the
timestamp is set correctly. However, i.landsat.toar does not take care to
copy this over. Even, the right way would be to grep the info from the
MTL file directly.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1997#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.landsat.toar | Platform: All
      Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by nikosa):

> Replying to [vesnikos]:

Maybe you can close this ticket as i.landsat.toar knows about Landsat8
now! We can open a new ticket for the other issues.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1997#comment:8&gt;
GRASS GIS <http://grass.osgeo.org>

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.landsat.toar | Platform: All
      Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by hamish):

> 1) ... (recommended for sanity)

done in all branches

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1997#comment:9&gt;
GRASS GIS <http://grass.osgeo.org>

Niko,

would you mind checking it this ticket is still "open" for you?

Cheers,

Nikos

On Saturday 29 of June 2013 13:36:42 GRASS GIS wrote:

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------

Reporter: vesnikos | Owner: grass-dev@… Type: defect

   | Status: new Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk Keywords:
i.landsat.toar | Platform: All Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by vesnikos):

some minor bugs during my tests:

1) Cosmetic typo at the description of sensor parameter:
   It says "Required only if 'metfile' not given (recommended by sanity)"
   should be ""Required only if 'metfile' not given (recommended for
sanity)
2) Band8 (panchomatic) has my nature 15m res. The algorithm uses the
regions resolution , and you cannot do anything to override it.
3) timestamp in r.info reads none, the date of acquisition is in the
metadata, so it should be properly implemented

eg: r.timestamp map=LC81840322013143LGN03_B10.toarr.1 date="$(date
-d'$DATE_ACQUIRED $SCENE_CENTER_TIME' -u +'%d %b %Y %H:%M:%S.%N %z')"

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.landsat.toar | Platform: All
      Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by nikosa):

Replying to [comment:7 nikosa]:
> Replying to [comment:6 vesnikos]:
> > some minor bugs during my tests:
>
>
> > 2) Band8 (panchomatic) has my nature 15m res. The algorithm uses the
regions resolution , and you cannot do anything to override it.
>
> You can set the region resolution to the desired one! In my scripts I
do that. Maybe in this case an exception could be done and let the module
handle this?

This look more important than I thought in the beginning. Indeed, one
needs to work-around that issue since there is no way to preserve the
15m-s of Band 8 using (the current) i.landsat.toar in one go.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1997#comment:10&gt;
GRASS GIS <http://grass.osgeo.org>

Yeah its still open - It shouldn’t since the main problem is fixed. I’ll open a new ticket for the the resolution bug.

BTW, I have made a script that does what i.landsat.toar does, only that its fixed in that regard. I’ll be more than happy to share it if someone needs it!

N

···

On Fri, Sep 27, 2013 at 2:28 PM, GRASS GIS <trac@osgeo.org> wrote:

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------±----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…

Type: defect | Status: new
Priority: normal | Milestone: 7.0.0

Component: Imagery | Version: svn-trunk
Keywords: i.landsat.toar | Platform: All
Cpu: Unspecified |
----------------------------±----------------------------------------------

Comment(by nikosa):

Replying to [comment:7 nikosa]:

Replying to [comment:6 vesnikos]:

some minor bugs during my tests:

  1. Band8 (panchomatic) has my nature 15m res. The algorithm uses the
    regions resolution , and you cannot do anything to override it.

You can set the region resolution to the desired one! In my scripts I
do that. Maybe in this case an exception could be done and let the module
handle this?

This look more important than I thought in the beginning. Indeed, one
needs to work-around that issue since there is no way to preserve the
15m-s of Band 8 using (the current) i.landsat.toar in one go.


Ticket URL: <http://trac.osgeo.org/grass/ticket/1997#comment:10>
GRASS GIS <http://grass.osgeo.org>

new ticket about the resolution issue:

https://trac.osgeo.org/grass/ticket/2089

···

On Fri, Sep 27, 2013 at 7:27 PM, Nick Ves <vesnikos@gmail.com> wrote:

Yeah its still open - It shouldn’t since the main problem is fixed. I’ll open a new ticket for the the resolution bug.

BTW, I have made a script that does what i.landsat.toar does, only that its fixed in that regard. I’ll be more than happy to share it if someone needs it!

N

On Fri, Sep 27, 2013 at 2:28 PM, GRASS GIS <trac@osgeo.org> wrote:

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------±----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…

Type: defect | Status: new
Priority: normal | Milestone: 7.0.0

Component: Imagery | Version: svn-trunk
Keywords: i.landsat.toar | Platform: All
Cpu: Unspecified |
----------------------------±----------------------------------------------

Comment(by nikosa):

Replying to [comment:7 nikosa]:

Replying to [comment:6 vesnikos]:

some minor bugs during my tests:

  1. Band8 (panchomatic) has my nature 15m res. The algorithm uses the
    regions resolution , and you cannot do anything to override it.

You can set the region resolution to the desired one! In my scripts I
do that. Maybe in this case an exception could be done and let the module
handle this?

This look more important than I thought in the beginning. Indeed, one
needs to work-around that issue since there is no way to preserve the
15m-s of Band 8 using (the current) i.landsat.toar in one go.


Ticket URL: <http://trac.osgeo.org/grass/ticket/1997#comment:10>
GRASS GIS <http://grass.osgeo.org>

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
----------------------------+-----------------------------------------------
Reporter: vesnikos | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.landsat.toar | Platform: All
      Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by neteler):

Replying to [comment:10 nikosa]:
> This look more important than I thought in the beginning. Indeed, one
needs to work-around that issue since there is no way to preserve the
15m-s of Band 8 using (the current) i.landsat.toar in one go.

New ticket about the resolution issue: #2089

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1997#comment:11&gt;
GRASS GIS <http://grass.osgeo.org>

#1997: i.landsat.toar for grass-dev is missing the option for landsat8
-----------------------+----------------------------------------------------
  Reporter: vesnikos | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Resolution: fixed | Keywords: i.landsat.toar
  Platform: All | Cpu: Unspecified
-----------------------+----------------------------------------------------
Changes (by neteler):

  * status: new => closed
  * resolution: => fixed

Comment:

Replying to [comment:8 nikosa]:
> > Replying to [vesnikos]:
>
> Maybe you can close this ticket as i.landsat.toar knows about Landsat8
now!
> We can open a new ticket for the other issues.

Yes, closing (and also the other issue has been fixed).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1997#comment:12&gt;
GRASS GIS <http://grass.osgeo.org>