[GRASS-dev] [GRASS GIS] #2006: install: extra $GISBASE/etc/wxpython/scripts/Makefile?

GRASS GIS GRASS GIS developer
1

#2006: install: extra $GISBASE/etc/wxpython/scripts/Makefile?
--------------------------+-------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: trivial | Milestone: 6.4.4
Component: Installation | Version: svn-develbranch6
Keywords: wxpython | Platform: Linux
      Cpu: x86-64 |
--------------------------+-------------------------------------------------
Hi,

I notice that $GISBASE/etc/wxpython/scripts/Makefile gets installed.

any reason to keep that?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2006&gt;
GRASS GIS <http://grass.osgeo.org>

2

#2006: install: extra $GISBASE/etc/wxpython/scripts/Makefile?
--------------------------+-------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: trivial | Milestone: 6.4.4
Component: Installation | Version: svn-develbranch6
Keywords: wxpython | Platform: Linux
      Cpu: x86-64 |
--------------------------+-------------------------------------------------

Comment(by glynn):

Replying to [ticket:2006 hamish]:
> I notice that $GISBASE/etc/wxpython/scripts/Makefile gets installed.

gui/wxpython/Makefile does:
{{{
SRCFILES := $(wildcard compat/* icons/*.* scripts/* xml/*) \
}}}
Note that gui/wxpython/scripts/Makefile is redundant as
gui/wxpython/Makefile never recurses into the scripts directory, so
scripts/Makefile won't be used unless the user "make"s that directory
manually.

Also, many of those "*" wildcards could (and should) be changed to "*.py"
to avoid installing cruft such as editor backup files.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2006#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

3

#2006: install: extra $GISBASE/etc/wxpython/scripts/Makefile?
--------------------------+-------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: trivial | Milestone: 6.4.4
Component: Installation | Version: svn-develbranch6
Keywords: wxpython | Platform: Linux
      Cpu: x86-64 |
--------------------------+-------------------------------------------------

Comment(by hamish):

'*' changed to '*.py' for dirs which only have *.py in them done in trunk
and relbr6 with r56744,5, maybe expand to *.py *.html later.

minimal patch to take care of scripts/*.py done in relbr64 with r56757.
will backport the rest after the freeze.

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2006#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

4

#2006: install: extra $GISBASE/etc/wxpython/scripts/Makefile?
---------------------------+---------------------------------------------
  Reporter: hamish | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: trivial | Milestone: 6.4.4
Component: Installation | Version: svn-trunk
Resolution: | Keywords: wxpython, compilation, Makefile
       CPU: x86-64 | Platform: Linux
---------------------------+---------------------------------------------
Changes (by wenzeslaus):

* keywords: wxpython => wxpython, compilation, Makefile
* version: svn-develbranch6 => svn-trunk

Comment:

I'm just looking to `dist...` after compilation not the result of `make
install` but the file (`etc/wxpython/scripts/Makefile` or now
`/gui/wxpython/scripts/Makefile`) is no longer there.

However there are Makefiles in directories of `g.gui.*` modules:

{{{
$ cd dist...
$ find . -name "*Makefile*"
./gui/wxpython/psmap/Makefile
./gui/wxpython/animation/Makefile
./gui/wxpython/dbmgr/Makefile
./gui/wxpython/tplot/Makefile
./gui/wxpython/rlisetup/Makefile
./gui/wxpython/gmodeler/Makefile
./gui/wxpython/mapswipe/Makefile
./gui/wxpython/timeline/Makefile
./gui/wxpython/iclass/Makefile
./gui/wxpython/vdigit/Makefile
}}}

Do we have some bad Makefile template somewhere?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2006#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>