[GRASS-dev] [GRASS GIS] #2097: r.modis install using g.extension fails

#2097: r.modis install using g.extension fails
---------------------------+------------------------------------------------
Reporter: pierreroudier | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Addons | Version: svn-trunk
Keywords: MODIS | Platform: Linux
      Cpu: x86-64 |
---------------------------+------------------------------------------------
I'm having problems trying to compile r.modis on the trunk version of
GRASS from the g.extension command. It does not seem to compile the
pymodis library if I'm getting that right.

I am running Ubuntu 12.04.2.

{{{
GRASS 7.0.svn (eda-rsr):~ > g.extension ext=r.modis
Fetching <r.modis> from GRASS-Addons SVN (be patient)...
WARNING: gnome-keyring:: couldn't connect to:
/tmp/keyring-CTEtVP/pkcs11: No such file or directory
Compiling...
/bin/sh: 1: cannot create
/usr/local/grass-7.0.svn/locale/scriptstrings/r.modis.download_to_translate.c:
Directory nonexistent
sed: couldn't flush stdout: Broken pipe
make[1]:
[/usr/local/grass-7.0.svn/locale/scriptstrings/r.modis.download_to_translate.c]
Error 2 (ignored)
/bin/sh: 1: cannot create
/usr/local/grass-7.0.svn/locale/scriptstrings/r.modis.import_to_translate.c:
Directory nonexistent
sed: couldn't flush stdout: Broken pipe
make[1]:
[/usr/local/grass-7.0.svn/locale/scriptstrings/r.modis.import_to_translate.c]
Error 2 (ignored)
Installing...
Updating metadata file...
Installation of <r.modis> successfully finished
GRASS 7.0.svn (eda-rsr):~ > r.modis.import
ERROR: modis library not found
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2097&gt;
GRASS GIS <http://grass.osgeo.org>

#2097: r.modis install using g.extension fails
---------------------------+------------------------------------------------
Reporter: pierreroudier | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Addons | Version: svn-trunk
Keywords: MODIS | Platform: Linux
      Cpu: x86-64 |
---------------------------+------------------------------------------------

Comment(by neteler):

It works on Fedora 19. Any other distros where it fails than Ubuntu?

Note from grass-dev:

The issue is that the "scriptstrings/2 subdir is missing in
/usr/local/grass-7.0.svn/locale/scriptstrings/

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2097#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#2097: r.modis install using g.extension fails
---------------------------+------------------------------------------------
Reporter: pierreroudier | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Addons | Version: svn-trunk
Keywords: MODIS | Platform: Linux
      Cpu: x86-64 |
---------------------------+------------------------------------------------

Comment(by madi):

Replying to [comment:1 neteler]:
> It works on Fedora 19. Any other distros where it fails than Ubuntu?

Fails on Red Hat
See http://lists.osgeo.org/pipermail/grass-dev/2013-October/065957.html

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2097#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#2097: r.modis install using g.extension fails
---------------------------+------------------------------------------------
Reporter: pierreroudier | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Addons | Version: svn-trunk
Keywords: MODIS | Platform: Linux
      Cpu: x86-64 |
---------------------------+------------------------------------------------

Comment(by neteler):

Did you try to manually add the missing subdir? Would the installation
work then?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2097#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#2097: r.modis install using g.extension fails
---------------------------+------------------------------------------------
Reporter: pierreroudier | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Addons | Version: svn-trunk
Keywords: MODIS | Platform: Linux
      Cpu: x86-64 |
---------------------------+------------------------------------------------

Comment(by madi):

Replying to [comment:3 neteler]:
> Did you try to manually add the missing subdir? Would the installation
work then?

The installation is successfully finished then, BUT the command is not
found, because it is apparently installed in the wrong directory. The
/r.modis folder is placed under /grass-7.0.svn/

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2097#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#2097: r.modis install using g.extension fails
---------------------------+------------------------------------------------
Reporter: pierreroudier | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Addons | Version: svn-trunk
Keywords: MODIS | Platform: Linux
      Cpu: x86-64 |
---------------------------+------------------------------------------------

Comment(by pierreroudier):

Replying to [comment:3 neteler]:
> Did you try to manually add the missing subdir? Would the installation
work then?

Same as madi here on Ubuntu:

{{{
GRASS 7.0.svn (eda-rsr):~ > mkdir -p
/usr/local/grass-7.0.svn/locale/scriptstrings/
GRASS 7.0.svn (eda-rsr):~ > g.extension ext=r.modisWARNING: Extension
<r.modis> already installed. Re-installing...
Fetching <r.modis> from GRASS-Addons SVN (be patient)...
WARNING: gnome-keyring:: couldn't connect to: /tmp/keyring-VFvFlG/pkcs11:
No such file or directory
Compiling...
Installing...
Updating metadata file...
Installation of <r.modis> successfully finished
GRASS 7.0.svn (eda-rsr):~ > r.modis.import
ERROR: modis library not found
}}}

It installs but of course the directory is not correct so the library is
not found.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2097#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#2097: r.modis install using g.extension fails
---------------------------+------------------------------------------------
Reporter: pierreroudier | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Addons | Version: svn-trunk
Keywords: MODIS | Platform: Linux
      Cpu: x86-64 |
---------------------------+------------------------------------------------

Comment(by wenzeslaus):

`r.modis` is a library (Python packages/modules) and group of modules. Is
somewhere specified how the Makefiles for group of Python modules and
their library should look like? How does the build process deals with this
and how with translations? Is there some official template for the
Makefiles?
  * source:grass-addons/grass7/raster/r.modis/Makefile
  * source:grass-addons/grass7/raster/r.modis/libmodis/Makefile
  * source:grass-addons/grass7/raster/r.modis/r.modis.import/Makefile
  * source:grass-addons/grass7/raster/r.modis/r.modis.download/Makefile
It seems that it is implemented in the build system but maybe only
partially? So the current problem is mostly related to the translations?

There is not much about it in SUBMITTING files:
  * source:grass-addons/SUBMITTING
  * source:grass-addons/SUBMITTING_DOCS
  * source:grass-addons/SUBMITTING_PYTHON
  * source:grass-addons/SUBMITTING_SCRIPTS

By the way, we probably have a lot of duplication with the SUBMITTING
files in the main source code (trunk and others).

More by the way, there are some invalid links (and probably invalid info
too) in SUBMITTING files:
  * http://www-pool.math.tu-berlin.de/~soeren/grass/GRASS_TestSuite (Error:
404 Not Found)
  * http://www.grass-gis.org/mailman/listinfo/grass-qa (Errore 404 File non
trovato)

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2097#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

#2097: r.modis install using g.extension fails
---------------------------+------------------------------------------------
Reporter: pierreroudier | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Addons | Version: svn-trunk
Keywords: r.modis | Platform: Linux
      Cpu: x86-64 |
---------------------------+------------------------------------------------
Changes (by neteler):

  * keywords: MODIS => r.modis

Comment:

Replying to [comment:6 wenzeslaus]:

[... unsolved Makefile issues...]

> By the way, we probably have a lot of duplication with the SUBMITTING
files in the main source code (trunk and others).

They should be actually *identical* since some people come trunk while
others only look into Addons.

> More by the way, there are some invalid links (and probably invalid info
too) in SUBMITTING files:
> * http://www-pool.math.tu-berlin.de/~soeren/grass/GRASS_TestSuite
(Error: 404 Not Found)

Maybe use this URL? http://grasswiki.osgeo.org/wiki/Test_Suite

> * http://www.grass-gis.org/mailman/listinfo/grass-qa (Errore 404 File
non trovato)

grass-qa URL fixed.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2097#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>

#2097: r.modis install using g.extension fails
---------------------------+------------------------------------------------
Reporter: pierreroudier | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Addons | Version: svn-trunk
Keywords: r.modis | Platform: Linux
      Cpu: x86-64 |
---------------------------+------------------------------------------------

Comment(by wenzeslaus):

I see that the following is the topic for a new ticket(s). So if the
discussion will go on, we should create them.

Replying to [comment:7 neteler]:
> Replying to [comment:6 wenzeslaus]:
>
> [... unsolved Makefile issues...]
>
> > By the way, we probably have a lot of duplication with the SUBMITTING
files in the main source code (trunk and others).
>
> They should be actually *identical* since some people come trunk while
> others only look into Addons.
>
I would suggest to just link (via description and file name or via URL)
the SUBMITTING from the main source code and in addons only document
addon-specific things. ''(Reorganize SUBMITTING files for addons ticket)''

I think that people are not reading any of these files and the reason They
are not available online as HTML (as part of web page, standalone or as
part of doxygen). ''(Change SUBMITTING format ticket)''

> > More by the way, there are some invalid links (and probably invalid
info too) in SUBMITTING files:
> > * http://www-pool.math.tu-berlin.de/~soeren/grass/GRASS_TestSuite
(Error: 404 Not Found)
>
> Maybe use this URL? http://grasswiki.osgeo.org/wiki/Test_Suite

This is probably only URL we have but, if I understand correctly, it is an
idea, not a working solution. The only solution is manually run shell
scripts (but it would be probably advantageous if they are in the format
specified by that URL).

>
> > * http://www.grass-gis.org/mailman/listinfo/grass-qa (Errore 404 File
non trovato)
>
> grass-qa URL fixed.

For me http://grass.osgeo.org/mailman/listinfo/grass-qa does not work but
the result of googling - http://lists.osgeo.org/listinfo/grass-qa - works.
However, the descriptions says ''(NOTE: currently inactive!)''.

''(Missing instructions for testing ticket)''

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2097#comment:8&gt;
GRASS GIS <http://grass.osgeo.org>

#2097: r.modis install using g.extension fails
---------------------------+------------------------------------------------
Reporter: pierreroudier | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Addons | Version: svn-trunk
Keywords: r.modis | Platform: Linux
      Cpu: x86-64 |
---------------------------+------------------------------------------------

Comment(by neteler):

Replying to [comment:8 wenzeslaus]:
> Replying to [comment:7 neteler]:
> > grass-qa URL fixed.
>
> For me http://grass.osgeo.org/mailman/listinfo/grass-qa does not work
but the result of googling - http://lists.osgeo.org/listinfo/grass-qa -
works.

That was up to date since yesterday (Europe): r57976,r57977,r57978,r57979

> However, the descriptions says ''(NOTE: currently inactive!)''.

The list purpose was the feed of an automated QA system which existed for
some years.

> ''(Missing instructions for testing ticket)''
Please open these tickets then, it is all unrelated to this one here.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2097#comment:9&gt;
GRASS GIS <http://grass.osgeo.org>

#2097: r.modis install using g.extension fails
---------------------------+------------------------------------------------
Reporter: pierreroudier | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Addons | Version: svn-trunk
Keywords: r.modis | Platform: Linux
      Cpu: x86-64 |
---------------------------+------------------------------------------------

Comment(by wenzeslaus):

The unrelated things discussed above have now separate tickets (#2103,
#2104, #2105) except for ''Missing instruction how to do a multi-module
addon'' which is probably related to this ticket in the sense that the
Makefiles are not correct.

Last fully related comment was done by [comment:5 pierreroudier]:
> Replying to [comment:3 neteler]:
> > Did you try to manually add the missing subdir? Would the installation
work then?
>
> Same as madi here on Ubuntu:
> ...
> WARNING: gnome-keyring:: couldn't connect to: /tmp/keyring-
VFvFlG/pkcs11: No such
> ...
>
> It installs but of course the directory is not correct so the library is
not found.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2097#comment:10&gt;
GRASS GIS <http://grass.osgeo.org>