[GRASS-dev] [GRASS GIS] #2148: wxGUI modeler: allow to name elements in the model schema

#2148: wxGUI modeler: allow to name elements in the model schema
-------------------------------+--------------------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: wxGUI | Version: svn-trunk
Keywords: modeller comments | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------+--------------------------------------------
It would be nice if by changing the name of an object in the Objects tab,
this name would replace the name of the command in the model display.
Currently setting this name just is ignored and is lost after saving and
reopening the model.

In addition, the possibility to add comments would be nice, possibly in
the form of a comment object that would be ignored in the model.

Moritz

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2148&gt;
GRASS GIS <http://grass.osgeo.org>

#2148: wxGUI modeler: allow to name elements in the model schema
-------------------------------+--------------------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: wxGUI | Version: svn-trunk
Keywords: modeller comments | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------+--------------------------------------------

Comment(by martinl):

Replying to [ticket:2148 mlennert]:
> It would be nice if by changing the name of an object in the Objects
tab, this name would replace the name of the command in the model display.
Currently setting this name just is ignored and is lost after saving and
reopening the model.

it was hopefully fixed in r58518, you can set action name/label in 'Items'
tab or from contextual menu ('Set label').

> In addition, the possibility to add comments would be nice, possibly in
the form of a comment object that would be ignored in the model.

This has been implemented in r58521. You can set comments from contextual
menu, it's saved to model file. I am not sure how to display them,
probably as tooltips or directly in the object shape below label. Any
opinions?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2148#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#2148: wxGUI modeler: allow to name elements in the model schema
-------------------------------+--------------------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: wxGUI | Version: svn-trunk
Keywords: modeller comments | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------+--------------------------------------------

Comment(by mlennert):

Replying to [comment:1 martinl]:
> Replying to [ticket:2148 mlennert]:
> > It would be nice if by changing the name of an object in the Objects
tab, this name would replace the name of the command in the model display.
Currently setting this name just is ignored and is lost after saving and
reopening the model.
>
> it was hopefully fixed in r58518, you can set action name/label in
'Items' tab or from contextual menu ('Set label').

Works now, thanks !

>
> > In addition, the possibility to add comments would be nice, possibly
in the form of a comment object that would be ignored in the model.
>
> This has been implemented in r58521. You can set comments from
contextual menu, it's saved to model file. I am not sure how to display
them, probably as tooltips or directly in the object shape below label.
Any opinions?

I think the ideal would be to be able to add comments independent of
objects. Sometimes comments can be about a process that includes several
objects. And for such comments it would be nice to have a specific form
not yet used by other types of obects (triangle, hexagon, ...).

And to push things even further: it would be nice if these comments then
also show up in the Python code...

Moritz

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2148#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#2148: wxGUI modeler: allow to name elements in the model schema
-------------------------------+--------------------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: wxGUI | Version: svn-trunk
Keywords: modeller comments | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------+--------------------------------------------

Comment(by martinl):

Replying to [comment:2 mlennert]:
> > > It would be nice if by changing the name of an object in the Objects
tab, this name would replace the name of the command in the model display.
Currently setting this name just is ignored and is lost after saving and
reopening the model.
> >
> > it was hopefully fixed in r58518, you can set action name/label in
'Items' tab or from contextual menu ('Set label').
>
> Works now, thanks !

I have also modified dialog for adding new commands to the model which now
enables setting label and comment, see attachment:modeler-label-
comment.png

> > > In addition, the possibility to add comments would be nice, possibly
in the form of a comment object that would be ignored in the model.
> >
> > This has been implemented in r58521. You can set comments from
contextual menu, it's saved to model file. I am not sure how to display
them, probably as tooltips or directly in the object shape below label.
Any opinions?
>
> I think the ideal would be to be able to add comments independent of
objects. Sometimes comments can be about a process that includes several
objects. And for such comments it would be nice to have a specific form
not yet used by other types of obects (triangle, hexagon, ...).

This make sense.

> And to push things even further: it would be nice if these comments then
also show up in the Python code...

As comments, good point.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2148#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#2148: wxGUI modeler: allow to name elements in the model schema
-------------------------------+--------------------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: wxGUI | Version: svn-trunk
Keywords: modeller comments | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------+--------------------------------------------

Comment(by martinl):

Replying to [comment:3 martinl]:
> > I think the ideal would be to be able to add comments independent of
objects. Sometimes comments can be about a process that includes several
objects. And for such comments it would be nice to have a specific form
not yet used by other types of obects (triangle, hexagon, ...).

Please try out r58557.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2148#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#2148: wxGUI modeler: allow to name elements in the model schema
-------------------------------+--------------------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: wxGUI | Version: svn-trunk
Keywords: modeller comments | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------+--------------------------------------------

Comment(by martinl):

Replying to [comment:1 martinl]:
> > In addition, the possibility to add comments would be nice, possibly
in the form of a comment object that would be ignored in the model.
>
> This has been implemented in r58521. You can set comments from
contextual menu, it's saved to model file. I am not sure how to display
them, probably as tooltips or directly in the object shape below label.
Any opinions?

Comments related to the commands are now shown as !DividedShape, see
attachment:modeler-comment.png

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2148#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>