[GRASS-dev] [GRASS GIS] #2238: minor change in r.stream.segment syntax

#2238: minor change in r.stream.segment syntax
------------------------------+---------------------------------------------
Reporter: madi | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: minor | Milestone: 7.0.0
Component: Default | Version: svn-trunk
Keywords: r.stream.segment | Platform: Unspecified
      Cpu: Unspecified |
------------------------------+---------------------------------------------
Following the unification of syntax used within r.stream.* modules, in
r.stream.segment we overlooked to change the input option stream_raster
into stream_rast. Since it is now in core and i don't have writing access,
could someone kindly do that.

Thanks

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2238&gt;
GRASS GIS <http://grass.osgeo.org>

#2238: minor change in r.stream.segment syntax
------------------------------+---------------------------------------------
Reporter: madi | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: minor | Milestone: 7.0.0
Component: Raster | Version: svn-trunk
Keywords: r.stream.segment | Platform: Unspecified
      Cpu: Unspecified |
------------------------------+---------------------------------------------
Changes (by neteler):

  * component: Default => Raster

Comment:

Done in r59509 (trunk) and r59510 (releasebranch_7_0).

BTW: the param description wording is a bit odd.

{{{
     in_stm_opt = G_define_standard_option(G_OPT_R_INPUT);
     in_stm_opt->key = "stream_rast";
     in_stm_opt->description = _("Name of input streams mask raster map");

     in_dir_opt = G_define_standard_option(G_OPT_R_INPUT);
     in_dir_opt->key = "direction";
     in_dir_opt->description = _("Name for input raster map with flow
direction");
}}}

and should perhaps be sync'ed to that of "direction" (in all modules).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2238#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#2238: minor change in r.stream.segment syntax
------------------------------+---------------------------------------------
Reporter: madi | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: minor | Milestone: 7.0.0
Component: Raster | Version: svn-trunk
Keywords: r.stream.segment | Platform: Unspecified
      Cpu: Unspecified |
------------------------------+---------------------------------------------

Comment(by hellik):

Replying to [comment:1 neteler]:
> Done in r59509 (trunk) and r59510 (releasebranch_7_0).

thanks

>
> BTW: the param description wording is a bit odd.
>
> {{{
> in_stm_opt = G_define_standard_option(G_OPT_R_INPUT);
> in_stm_opt->key = "stream_rast";
> in_stm_opt->description = _("Name of input streams mask raster
map");
>
> in_dir_opt = G_define_standard_option(G_OPT_R_INPUT);
> in_dir_opt->key = "direction";
> in_dir_opt->description = _("Name for input raster map with flow
direction");
> }}}
>
> and should perhaps be sync'ed to that of "direction" (in all modules).

yes; any template/example around there to facilitate
unification/harmonizing not only for r.stream.* but also for other
hydrologically oriented modules?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2238#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#2238: minor change in r.stream.segment syntax
------------------------------+---------------------------------------------
Reporter: madi | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: minor | Milestone: 7.0.0
Component: Raster | Version: svn-trunk
Keywords: r.stream.segment | Platform: Unspecified
      Cpu: Unspecified |
------------------------------+---------------------------------------------

Comment(by madi):

Replying to [comment:1 neteler]:
> Done in r59509 (trunk) and r59510 (releasebranch_7_0).

Thanks
>
> BTW: the param description wording is a bit odd.
>
> {{{
> in_stm_opt = G_define_standard_option(G_OPT_R_INPUT);
> in_stm_opt->key = "stream_rast";
> in_stm_opt->description = _("Name of input streams mask raster
map");
>
> in_dir_opt = G_define_standard_option(G_OPT_R_INPUT);
> in_dir_opt->key = "direction";
> in_dir_opt->description = _("Name for input raster map with flow
direction");
> }}}
>
> and should perhaps be sync'ed to that of "direction" (in all modules).

Agreed. Something like: "Name for input raster map with stream network"
should do.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2238#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#2238: minor change in r.stream.segment syntax
--------------------------+-------------------------------------------------
  Reporter: madi | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: minor | Milestone: 7.0.0
Component: Raster | Version: svn-trunk
Resolution: fixed | Keywords: r.stream.segment
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Changes (by neteler):

  * status: new => closed
  * resolution: => fixed

Comment:

Replying to [comment:3 madi]:
> Agreed. Something like: "Name for input raster map with stream network"
should do.

Done in r59519 and r59520.
Closing.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2238#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>