[GRASS-dev] [GRASS GIS] #2423: r.series.interp missing in wxGUI menu

#2423: r.series.interp missing in wxGUI menu
------------------------------------------+---------------------------------
Reporter: jbrauner | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.1.0
Component: wxGUI | Version: svn-trunk
Keywords: r.series.interp, wxGUI, menu | Platform: All
      Cpu: All |
------------------------------------------+---------------------------------
Hi devs,

r.series.interp is missing in wxGUI menu.

I created a patch (attached) to add it just below r.series in the Raster
-> Overlay submenu as "Raster series interpolation". This is just a
suggestion, feel free to place it anywhere else.

Hopefully I've modified the correct toolboxes.xml -> newbie :).

Cheers,

Johannes

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2423&gt;
GRASS GIS <http://grass.osgeo.org>

#2423: r.series.interp missing in wxGUI menu
------------------------------------------+---------------------------------
Reporter: jbrauner | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.1.0
Component: wxGUI | Version: svn-trunk
Keywords: r.series.interp, wxGUI, menu | Platform: All
      Cpu: All |
------------------------------------------+---------------------------------

Comment(by neteler):

I would be happy to intergrate tge missing item but it is not clear to me
which files to edit:

{{{
ls gui/wxpython/xml/*.xml
main_menu.xml menudata_psmap.xml module_tree_menudata.xml
toolboxes.xml
menudata_modeler.xml menudata.xml module_tree.xml
wxgui_items.xml
}}}

What is the role of

gui/wxpython/tools/update_menudata.py

?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2423#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#2423: r.series.interp missing in wxGUI menu
------------------------------------------+---------------------------------
Reporter: jbrauner | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.1.0
Component: wxGUI | Version: svn-trunk
Keywords: r.series.interp, wxGUI, menu | Platform: All
      Cpu: All |
------------------------------------------+---------------------------------

Comment(by jbrauner):

I ''try'' to deduct my thinking process here ... which lead to the patch
:slight_smile:

Replying to [comment:1 neteler]:
> I would be happy to intergrate tge missing item but it is not clear to
me which files to edit:
>
> {{{
> ls gui/wxpython/xml/*.xml
> main_menu.xml menudata_psmap.xml module_tree_menudata.xml
toolboxes.xml
> menudata_modeler.xml menudata.xml module_tree.xml
wxgui_items.xml
> }}}

I somehow figured out (after checking the wxGUI developer documentation
and the source code), that it has to be {{{toolboxes.xml}}}, because

> What is the role of
>
> gui/wxpython/tools/update_menudata.py
>
> ?

this script delivers a list of all possible menuentries and
{{{toolboxes.xml}}} based on {{{menudata.xml}}} provides the structure,
place and the labels used in the menu.

Again, that was somehow a noobish deduction - but that's the best I can
deliver right now. :slight_smile:

Cheers,

Johannes

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2423#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#2423: r.series.interp missing in wxGUI menu
------------------------------------------+---------------------------------
Reporter: jbrauner | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.1.0
Component: wxGUI | Version: svn-trunk
Keywords: r.series.interp, wxGUI, menu | Platform: All
      Cpu: All |
------------------------------------------+---------------------------------

Comment(by wenzeslaus):

Replying to [comment:2 jbrauner]:
> I ''try'' to deduct my thinking process here ... which lead to the patch
:slight_smile:
>
> Replying to [comment:1 neteler]:
> > I would be happy to intergrate tge missing item but it is not clear to
me which files to edit:
> >
> > {{{
> > ls gui/wxpython/xml/*.xml
> > main_menu.xml menudata_psmap.xml module_tree_menudata.xml
toolboxes.xml
> > menudata_modeler.xml menudata.xml module_tree.xml
wxgui_items.xml
> > }}}
>
> I somehow figured out (after checking the wxGUI developer documentation
and the source code), that it has to be {{{toolboxes.xml}}}, because
>

There was [source:grass/trunk/gui/wxpython/wxguitoolboxes.dox?rev=57001 a
documentation for this] in programming manual but it was deleted few days
ago in r62097. However, there is still a user-oriented documentation which
applies almost completely:

  * http://grass.osgeo.org/grass71/manuals/wxGUI.toolboxes.html

(except for location of the files)

> > What is the role of
> >
> > gui/wxpython/tools/update_menudata.py
> >
> > ?
>
> this script delivers a list of all possible menuentries and
{{{toolboxes.xml}}} based on {{{menudata.xml}}} provides the structure,
place and the labels used in the menu.
>
See, (removed) documentation
(source:grass/trunk/gui/wxpython/wxguitoolboxes.dox?rev=57001#L224).
Perhaps we could remove the script now. I would have to double check.

Anyway, use `make` and see what happens, if nothing do `make clean`, maybe
`rm ...dist.../etc/gui` and `make` (or simple or time consuming `make
distclean && make`).

> Again, that was somehow a noobish deduction - but that's the best I can
deliver right now. :slight_smile:
>

If you want some example of a change, see the changes in r60768
(backported r60771).

I'm not doing the change because I don't know if "Overlay rasters" is the
right toolbox/group/submenu for `r.series.interp`, interpolation is not
really an overlay operation. Perhaps `r.series.accumulate` should go there
(which is also not in the menu).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2423#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#2423: r.series.interp missing in wxGUI menu
------------------------------------------+---------------------------------
Reporter: jbrauner | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.1.0
Component: wxGUI | Version: svn-trunk
Keywords: r.series.interp, wxGUI, menu | Platform: All
      Cpu: All |
------------------------------------------+---------------------------------

Comment(by neteler):

Replying to [comment:3 wenzeslaus]:
> There was [source:grass/trunk/gui/wxpython/wxguitoolboxes.dox?rev=57001
a documentation for this] in programming manual but it was deleted few
days ago in r62097.

BTW: I brought that now back as sphinx rst files in r62138.

(technically, I converted the doxygen output from a not yet updated GRASS
mirror site to ODT/Libreoffice, then used
https://pypi.python.org/pypi/odt2sphinx/ to convert it again + some manual
work on the files). Generate with

{{{
cd gui/wxpython/docs/wxgui_toolboxes/
make toolboxeshtml
}}}

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2423#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#2423: r.series.interp missing in wxGUI menu
-----------------------+----------------------------------------------------
  Reporter: jbrauner | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.1.0
Component: wxGUI | Version: svn-trunk
Resolution: fixed | Keywords: r.series.interp, wxGUI, menu
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------
Changes (by neteler):

  * status: new => closed
  * resolution: => fixed

Comment:

Replying to [ticket:2423 jbrauner]:
> Hi devs,
>
> r.series.interp is missing in wxGUI menu.
>
> I created a patch (attached) to add it just below r.series in the Raster
-> Overlay submenu as "Raster series interpolation". This is just a
suggestion, feel free to place it anywhere else.

I have now put
  * r.series.accumulate into "Overlay"
  * r.series.interp into "Interpolation"

and additionally moved r.buffer + r.distance into a new submenu to shorten
the "Raster" menu.

See r62139 (trunk) and r62140 (relbr7). Closing ticket.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2423#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#2423: r.series.interp missing in wxGUI menu
-----------------------+----------------------------------------------------
  Reporter: jbrauner | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.1.0
Component: wxGUI | Version: svn-trunk
Resolution: fixed | Keywords: r.series.interp, wxGUI, menu
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------

Comment(by jbrauner):

Thank you both! Much appreciated and I've learned some things once again.

Johannes

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2423#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>