[GRASS-dev] [GRASS GIS] #2426: add r.surf.nnbathy to the core code of GRASS 7.1

#2426: add r.surf.nnbathy to the core code of GRASS 7.1
-------------------------+--------------------------------------------------
Reporter: bhlevca | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: major | Milestone: 7.1.0
Component: Addons | Version: unspecified
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
I find this script much faster and gives better results that
r.surf.contour.

I am not sure if there are licensing problems with nnbathy
(https://code.google.com/p/nn-c/) as it is a MIT license, but my
understanding is that it should be possible.

I recently copied manually the script from the Grass6 add on repositories
into the scripts directory of the Grass7.1 installation directory. I also
compiled nnbathy from the above sources.
The Makefile in the grass7 addons did not work although I had the grass6
addons installed in parallel. Probably that needs fixing as well as a
temporary measure until nnbathy is properly integrated.

It worked flawlessly in grass 7.1. The result of a 6000x 10000 nodes was
given in less than one minute. The r.surf.contour gave me a worse result
in 192 minutes! That's more than 3 hours and that happened only after I
lowered the resolution from res=2 to res=6. With res=1 in the g.region the
r.surf.contour did not advance at all after 2 hours so I had to cancel. In
addition the quality is not so great from r.surf.contour, especially if
you have complex shapes.

I believe many people would benefit from this triangulation (nnbathy)
method rather than using the linear interpolation method of
r.surf.contour.

Please consider of adding r.surf.nnbathy to the main repository.
Thanks

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2426&gt;
GRASS GIS <http://grass.osgeo.org>

#2426: add r.surf.nnbathy to the core code of GRASS 7.1
-------------------------+--------------------------------------------------
Reporter: bhlevca | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: major | Milestone: 7.1.0
Component: Addons | Version: unspecified
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by annakrat):

[http://lists.osgeo.org/pipermail/grass-dev/2014-April/068179.html link]
to related mailing list discussion

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2426#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#2426: add r.surf.nnbathy to the core code of GRASS 7.1
-------------------------+--------------------------------------------------
Reporter: bhlevca | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: major | Milestone: 7.1.0
Component: Addons | Version: unspecified
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by bhlevca):

I read that.

However, I think that it is better to have a tracked item rather than
discussions on a list, which are more difficult to find and probably lead
nowhere because there is no one assigned to deal with it.

Thanks for the reply. I did my job with it, but using hacks and chasing
information on the net. Having it all in a common place would make more
sense. I thought that by raising the issue it would life easier to many
people.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2426#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#2426: add r.surf.nnbathy to the core code of GRASS 7.1
-------------------------+--------------------------------------------------
Reporter: bhlevca | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: major | Milestone: 7.1.0
Component: Addons | Version: unspecified
Keywords: nnbathy | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by martinl):

* cc: lazaa (added)
  * keywords: => nnbathy

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2426#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#2426: add r.surf.nnbathy to the core code of GRASS 7.1
-------------------------+--------------------------------------------------
Reporter: bhlevca | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: major | Milestone: 7.1.0
Component: Addons | Version: unspecified
Keywords: nnbathy | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by martinl):

Replying to [ticket:2426 bhlevca]:
> I am not sure if there are licensing problems with nnbathy
> (https://code.google.com/p/nn-c/) as it is a MIT license, but my
understanding is that it should be possible.

From https://code.google.com/p/nn-c/source/browse/nn/LICENSE it doesn't
seems to me that it's MIT licence (?)

> I recently copied manually the script from the Grass6 add on
repositories into the scripts directory of the Grass7.1 installation
directory. I also compiled nnbathy from the above sources.

Please try out new modules which have been recently rewritten from Bash to
Python by lazaa. You can install them via g.extension

{{{
g.extension m.surf.nnbathy
}}}

which installs two new addon modules: `r.surf.nnbathy` and
`v.surf.nnbathy`.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2426#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#2426: add r.surf.nnbathy to the core code of GRASS 7.1
-------------------------+--------------------------------------------------
Reporter: bhlevca | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: major | Milestone: 7.1.0
Component: Addons | Version: unspecified
Keywords: nnbathy | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by martinl):

Replying to [comment:4 martinl]:
> From https://code.google.com/p/nn-c/source/browse/nn/LICENSE it doesn't
seems to me that it's MIT licence (?)

sorry, it's MIT licence as visible from https://code.google.com/p/nn-c/

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2426#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>