#2443: r.in.srtm.region add-on updates for 7.1svn
-------------------------+--------------------------------------------------
Reporter: awickert | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.1.0
Component: Addons | Version: unspecified
Keywords: | Platform: Unspecified
Cpu: Unspecified |
-------------------------+--------------------------------------------------
The simplification in GRASS 7.1 that changes g.list/g.mlist and g.mremove
into g.list and g.remove for everything broke some of the functionality of
r.in.srtm.region. I've attached a revised file and a list of diffs. My
changes check for GRASS version, and while I haven't tested it with 7.0,
should allow it to work on both 7.0 and 7.1.
I should note that these changes likely broke other add-ons, but that I am
in support of the g.list/g.remove change.
Just sending a nudge about this issue. Since I have fixed the code but there has been no response, could someone advise me if opening a ticket is not the best way to communicate an improvement to GRASS? I certainly know that everyone is busy.
Thanks,
Andy
···
On Thu, Oct 9, 2014 at 3:32 PM, GRASS GIS <trac@osgeo.org> wrote:
#2443: r.in.srtm.region add-on updates for 7.1svn
-------------------------±-------------------------------------------------
Reporter: awickert | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.1.0
Component: Addons | Version: unspecified
Keywords: | Platform: Unspecified
Cpu: Unspecified |
-------------------------±-------------------------------------------------
The simplification in GRASS 7.1 that changes g.list/g.mlist and g.mremove
into g.list and g.remove for everything broke some of the functionality of
r.in.srtm.region. I’ve attached a revised file and a list of diffs. My
changes check for GRASS version, and while I haven’t tested it with 7.0,
should allow it to work on both 7.0 and 7.1.
I should note that these changes likely broke other add-ons, but that I am
in support of the g.list/g.remove change.
has been no response, could someone advise me if opening a ticket is not the
best way to communicate an improvement to GRASS? I certainly know that
everyone is busy.
You followed the perfect way! The issue is that g.list and g.remove
are still changing (last change was a few minutes ago: see [1]).
A first major backport to GRASS 7.0.svn happened only earlier today
[2], it was not possible to update the Addons.
Now we are ready for that I would say!
Would you mind to revisit your patch? I'll answer in the ticket.
Replying to [ticket:2443 awickert]:
> The simplification in GRASS 7.1 that changes g.list/g.mlist and
g.mremove into g.list and g.remove for everything broke some of the
functionality of r.in.srtm.region. I've attached a revised file and a list
of diffs. My changes check for GRASS version, and while I haven't tested
it with 7.0, should allow it to work on both 7.0 and 7.1.
Thanks for the patch. I have updated `r.in.srtm.region` in r62451. Note
that the default is now to import SRTM v3.
On Tue, Oct 28, 2014 at 10:19 PM, Markus Neteler <neteler@osgeo.org> wrote:
...
A first major backport to GRASS 7.0.svn happened only earlier today
[2], it was not possible to update the Addons.
Now we are ready for that I would say!
Would you mind to revisit your patch? I'll answer in the ticket.
... nice, while writing Markus Metz fixed the Addon
Thanks, Markus and Markus. I’ll write over there to advise closing the ticket. Completely understand not wanting to or being able to do too much while multiple interacting pieces of code are in motion.
Andy
···
Andrew D. Wickert
INSTAAR & Geological Sciences, University of Colorado Boulder
Now at:
Universität Potsdam
Institut für Erd- und Umweltwissenschaften
Haus 29, Rm. 153
Karl-Liebknecht-Str. 24-25
14476 Potsdam-Golm, Deutschland
On Tue, Oct 28, 2014 at 10:20 PM, Markus Neteler <neteler@osgeo.org> wrote:
On Tue, Oct 28, 2014 at 10:19 PM, Markus Neteler <neteler@osgeo.org> wrote:
…
A first major backport to GRASS 7.0.svn happened only earlier today
[2], it was not possible to update the Addons.
Now we are ready for that I would say!
Would you mind to revisit your patch? I’ll answer in the ticket.
