#2514: G_OPT_C_BG and G_OPT_C_FG differ in support of color_none
-------------------------------------+--------------------------------------
Reporter: annakrat | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Default | Version: svn-trunk
Keywords: color, standard options | Platform: All
Cpu: Unspecified |
-------------------------------------+--------------------------------------
In the attempt to standardize options for fg and bg colors, we ignored the
gisprompt where some commands have `old,color,color` and some
`old,color_none,color`. So this for example results in d.vect gui dialog
not supporting transparent feature color, because G_OPT_C_FG doesn't use
`color_none`.
Beside the gisprompt, also the description must be different. Should we
have 4 versions of color standard options? Something like G_OPT_C_BG,
G_OPT_C_FG, G_OPT_CN_BG, G_OPT_CN_FG?
I suppose all modules using standard color option should be checked.
#2514: G_OPT_C_BG and G_OPT_C_FG differ in support of color_none
-------------------------------------+--------------------------------------
Reporter: annakrat | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Default | Version: svn-trunk
Keywords: color, standard options | Platform: All
Cpu: Unspecified |
-------------------------------------+--------------------------------------
Comment(by mmetz):
Replying to [ticket:2514 annakrat]:
> In the attempt to standardize options for fg and bg colors, we ignored
the gisprompt where some commands have `old,color,color` and some
`old,color_none,color`. So this for example results in d.vect gui dialog
not supporting transparent feature color, because G_OPT_C_FG doesn't use
`color_none`.
>
> Beside the gisprompt, also the description must be different. Should we
have 4 versions of color standard options? Something like G_OPT_C_BG,
G_OPT_C_FG, G_OPT_CN_BG, G_OPT_CN_FG?
Too many just slightly different standard options contradict the idea of
having standard options. You can not make every possible occurrence of an
option a standard option. Standard options can be easily modified by
modules to meet their needs. Therefore I would opt to drop G_OPT_C_FG and
G_OPT_C_BG, and have instead G_OPT_C for `old,color,color` and G_OPT_CN
for `old,color_none,color`. That would also fix the wrong description for
G_OPT_C_FG.
#2514: G_OPT_C_BG and G_OPT_C_FG differ in support of color_none
-------------------------------------+--------------------------------------
Reporter: annakrat | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: Default | Version: svn-trunk
Keywords: color, standard options | Platform: All
Cpu: Unspecified |
-------------------------------------+--------------------------------------
Comment(by annakrat):
Replying to [comment:1 mmetz]:
> Replying to [ticket:2514 annakrat]:
> > In the attempt to standardize options for fg and bg colors, we ignored
the gisprompt where some commands have `old,color,color` and some
`old,color_none,color`. So this for example results in d.vect gui dialog
not supporting transparent feature color, because G_OPT_C_FG doesn't use
`color_none`.
> >
> > Beside the gisprompt, also the description must be different. Should
we have 4 versions of color standard options? Something like G_OPT_C_BG,
G_OPT_C_FG, G_OPT_CN_BG, G_OPT_CN_FG?
>
> Too many just slightly different standard options contradict the idea of
having standard options. You can not make every possible occurrence of an
option a standard option. Standard options can be easily modified by
modules to meet their needs. Therefore I would opt to drop G_OPT_C_FG and
G_OPT_C_BG, and have instead G_OPT_C for `old,color,color` and G_OPT_CN
for `old,color_none,color`. That would also fix the wrong description for
G_OPT_C_FG.