[GRASS-dev] [GRASS GIS] #2588: wxGUI digitizer: error when adding a new column

#2588: wxGUI digitizer: error when adding a new column
----------------------------------------+-----------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: defect | Status: new
Priority: critical | Milestone: 7.0.0
Component: wxGUI | Version: svn-releasebranch70
Keywords: digitizer crash add column | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------------+-----------------------------------
- In wxGUI Display Manager, chose Digitize -> New map
- Try to add a new column to the new map:

{{{
ATTENTION: Unable to open vector map <test1@user1> on level 2. Try to
            rebuild vector topology with v.build.
ERREUR :Unable to open vector map <test1@user1>
Traceback (most recent call last):
   File "/data/home/mlennert/SRC/GRASS/grass-7.0.0RC2/dist.x86_64-unknown-
linux-gnu/scripts/v.db.addcolumn", line 88, in <module>
     main()
   File "/data/home/mlennert/SRC/GRASS/grass-7.0.0RC2/dist.x86_64-unknown-
linux-gnu/scripts/v.db.addcolumn", line 84, in main
     grass.vector_history(map)
   File "/data/home/mlennert/SRC/GRASS/grass-7.0.0RC2/dist.x86_64-unknown-
linux-gnu/etc/python/grass/script/vector.py", line 145, in vector_history
     run_command('v.support', map=map, cmdhist=os.environ['CMDLINE'])
   File "/data/home/mlennert/SRC/GRASS/grass-7.0.0RC2/dist.x86_64-unknown-
linux-gnu/etc/python/grass/script/core.py", line 375, in run_command
     return handle_errors(returncode, returncode, args, kwargs)
   File "/data/home/mlennert/SRC/GRASS/grass-7.0.0RC2/dist.x86_64-unknown-
linux-gnu/etc/python/grass/script/core.py", line 310, in handle_errors
     returncode=returncode)
grass.exceptions.CalledModuleError: Module run None ['v.support',
'map=test1@user1', 'cmdhist=v.db.addcolumn "--q" "map=test1@user1"
"layer=1" "columns=tt1 integer"'] ended with error
Process ended with non-zero return code 1. See errors in the (error)
output.
}}}

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2588&gt;
GRASS GIS <http://grass.osgeo.org>

#2588: wxGUI digitizer: error when adding a new column
----------------------------------------+-----------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: defect | Status: new
Priority: critical | Milestone: 7.0.0
Component: wxGUI | Version: svn-releasebranch70
Keywords: digitizer crash add column | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------------+-----------------------------------

Comment(by mlennert):

A bit more info:

  * the column actually gets created
  * I can reproduce this with any existing map by just putting it into
editing mode and then trying to add a column

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2588#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#2588: wxGUI digitizer: error when adding a new column
----------------------------------------+-----------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: defect | Status: new
Priority: critical | Milestone: 7.0.0
Component: wxGUI | Version: svn-releasebranch70
Keywords: digitizer crash add column | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------------+-----------------------------------

Comment(by annakrat):

I think v.support doesn't need to open the vector on level 2. Changing it
to level 1 solves this issue. Any opinion on that?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2588#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#2588: wxGUI digitizer: error when adding a new column
----------------------------------------+-----------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: defect | Status: new
Priority: critical | Milestone: 7.0.0
Component: wxGUI | Version: svn-releasebranch70
Keywords: digitizer crash add column | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------------+-----------------------------------

Comment(by mlennert):

Replying to [comment:2 annakrat]:
> I think v.support doesn't need to open the vector on level 2. Changing
it to level 1 solves this issue. Any opinion on that?

I don't see any reason why v.support would need topology.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2588#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#2588: wxGUI digitizer: error when adding a new column
----------------------------------------+-----------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: defect | Status: new
Priority: critical | Milestone: 7.0.0
Component: wxGUI | Version: svn-releasebranch70
Keywords: digitizer crash add column | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------------+-----------------------------------

Comment(by annakrat):

If there are no objections, I will commit it tomorrow. I just want to
avoid breaking v.support because of my insufficient knowledge of vector
library...

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2588#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#2588: wxGUI digitizer: error when adding a new column
----------------------------------------+-----------------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: defect | Status: new
Priority: critical | Milestone: 7.0.0
Component: wxGUI | Version: svn-releasebranch70
Keywords: digitizer crash add column | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------------+-----------------------------------

Comment(by annakrat):

Done in r64603 and r64604. Moritz, please confirm that it fixed the issue
and close this, thanks.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2588#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#2588: wxGUI digitizer: error when adding a new column
--------------------------+-------------------------------------------------
  Reporter: mlennert | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: critical | Milestone: 7.0.0
Component: wxGUI | Version: svn-releasebranch70
Resolution: fixed | Keywords: digitizer crash add column
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Changes (by mlennert):

  * status: new => closed
  * resolution: => fixed

Comment:

Replying to [comment:5 annakrat]:
> Done in r64603 and r64604. Moritz, please confirm that it fixed the
issue and close this, thanks.

Yes, this fixes it for me. And rapid tests of v.support have not shown any
bad consequences. Closing.

Thanks a lot !

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2588#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>