[GRASS-dev] [GRASS GIS] #2621: r.random.cell should use NULL instead of 0

#2621: r.random.cell should use NULL instead of 0
-------------------------+--------------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: minor | Milestone: 7.0.1
Component: Raster | Version: 7.0.0
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
It seems that r.random.cell is using 0 to mark empty areas instead of
using proper NULL values.
It is easy fixable by r.nulls call, still it should be fixed.

If it is a desired behaviour, documentation should be updated to state it.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2621&gt;
GRASS GIS <http://grass.osgeo.org>

#2621: r.random.cells should use NULL instead of 0
----------------------------+-----------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: minor | Milestone: 7.0.1
Component: Raster | Version: svn-releasebranch70
Keywords: r.random.cells | Platform: Unspecified
      Cpu: Unspecified |
----------------------------+-----------------------------------------------
Changes (by neteler):

  * keywords: => r.random.cells
  * version: 7.0.0 => svn-releasebranch70

Old description:

It seems that r.random.cell is using 0 to mark empty areas instead of
using proper NULL values.
It is easy fixable by r.nulls call, still it should be fixed.

If it is a desired behaviour, documentation should be updated to state
it.

New description:

It seems that r.random.cells is using 0 to mark empty areas instead of
using proper NULL values.
It is easy fixable by r.null call, still it should be fixed.

If it is a desired behaviour, documentation should be updated to state it.

--

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2621#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#2621: r.random.cells should use NULL instead of 0
----------------------------+-----------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.1
Component: Raster | Version: svn-releasebranch70
Keywords: r.random.cells | Platform: Unspecified
      Cpu: Unspecified |
----------------------------+-----------------------------------------------
Changes (by neteler):

  * priority: minor => normal

Comment:

Hopefully fixed in r65021. Please check.

TODO:
* update manual page example
* Backported to relbranch7

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2621#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#2621: r.random.cells should use NULL instead of 0
----------------------------+-----------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.1
Component: Raster | Version: svn-releasebranch70
Keywords: r.random.cells | Platform: Unspecified
      Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by marisn):

Replying to [comment:2 neteler]:
> * Backport to relbranch7
I would say - no. It changes behaviour of module. 7.0.x shouldn't change
such things as it might break some scripts relaying on consistency of 7.0.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2621#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#2621: r.random.cells should use NULL instead of 0
----------------------------+-----------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.1
Component: Raster | Version: svn-releasebranch70
Keywords: r.random.cells | Platform: Unspecified
      Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by neteler):

G7.1 manual updated in r65024.

Replying to [comment:3 marisn]:
> Replying to [comment:2 neteler]:
> > * Backport to relbranch7
> I would say - no. It changes behaviour of module. 7.0.x shouldn't change
such things as it might break some scripts relaying on consistency of 7.0.

Maybe. However, the 7.0 manual states "The cells are numbered from 1 to
the
numbers of cells generated." which is not true.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2621#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#2621: r.random.cells should use NULL instead of 0
----------------------------+-----------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.1
Component: Raster | Version: svn-releasebranch70
Keywords: r.random.cells | Platform: Unspecified
      Cpu: Unspecified |
----------------------------+-----------------------------------------------

Comment(by marisn):

Replying to [comment:4 neteler]:
> Maybe. However, the 7.0 manual states "The cells are numbered from 1 to
the
> numbers of cells generated." which is not true.
>
Then the manual needs to be fixed. (It also doesn't state that empty cells
have NULLs thus manual is not contradicting current behaviour.)
How about adding a simple sentence "Empty cells are marked with 0 (will be
changed to NULL in GRASS GIS 7.1.0 release)."?

I would say - fix documentation, add to GRASS 7.1 changes and close this
issue.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2621#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#2621: r.random.cells should use NULL instead of 0
--------------------------+-------------------------------------------------
  Reporter: marisn | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.0.1
Component: Raster | Version: svn-releasebranch70
Resolution: fixed | Keywords: r.random.cells
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Changes (by neteler):

  * status: new => closed
  * resolution: => fixed

Comment:

Replying to [comment:5 marisn]:
> I would say - fix documentation, add to GRASS 7.1 changes and close this
issue.

While I don't fully agree I have clarified the presence of 0 in r65117
(relbr7).
Closing.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2621#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>