[GRASS-dev] [GRASS GIS] #2672: r.surf.idw should support FCELL and DCELL

GDAL · May 10, 2015, 9:40pm

#2672: r.surf.idw should support FCELL and DCELL
------------------------+---------------------------------
Reporter: annakrat | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.0.1
Component: Raster | Version: svn-releasebranch70
Keywords: r.surf.idw | CPU: All
Platform: All |
------------------------+---------------------------------
Currently r.surf.idw reads and outputs raster as CELL. Float and double
precision support is needed.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2672>
GRASS GIS <http://grass.osgeo.org>

GDAL · May 17, 2015, 12:43pm

#2672: r.surf.idw should support FCELL and DCELL
-----------------------+---------------------------------
  Reporter: annakrat | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.1
Component: Raster | Version: svn-releasebranch70
Resolution: | Keywords: r.surf.idw
       CPU: All | Platform: All
-----------------------+---------------------------------

Comment (by neteler):

For now I have added a G_fatal_error(): r65260 + r65261:
exit with fatal error in case of FCELL or DCELL input.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2672#comment:1>
GRASS GIS <http://grass.osgeo.org>

GDAL · May 17, 2015, 5:25pm

#2672: r.surf.idw should support FCELL and DCELL
-----------------------+---------------------------------
  Reporter: annakrat | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.1
Component: Raster | Version: svn-releasebranch70
Resolution: | Keywords: r.surf.idw
       CPU: All | Platform: All
-----------------------+---------------------------------

Comment (by neteler):

Once fixed, the commented example (see r65262) can be activated in the
manual

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2672#comment:2>
GRASS GIS <http://grass.osgeo.org>

GDAL · May 18, 2015, 7:47am

#2672: r.surf.idw should support FCELL and DCELL
-----------------------+---------------------------------
  Reporter: annakrat | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.1
Component: Raster | Version: svn-releasebranch70
Resolution: | Keywords: r.surf.idw
       CPU: All | Platform: All
-----------------------+---------------------------------

Comment (by kuszinger):

'''Comment only''': Any solution is generated, I've realized that in V7
r.surf.id eats much more memory than in 6.4. Addition of FCELL and DCELL
is handy, but I'm afraid that it may lead to further memory footprint
growing. I'm ready for testing, anyway any new version. I use r.surf.idw
extensively on huge sparse rasters where it takes 2 - 10 GB RAM to create
the result.

When it is about an FCELL source my workaround is creating a temporal CELL
coverage with mapcalc and multiplication and rounding original values and
when idw is done I calculate it back to an FCELL and remove the temporal
map.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2672#comment:3>
GRASS GIS <http://grass.osgeo.org>

GDAL · May 19, 2015, 6:45am

#2672: r.surf.idw should support FCELL and DCELL
-----------------------+---------------------------------
  Reporter: annakrat | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.1
Component: Raster | Version: svn-releasebranch70
Resolution: | Keywords: r.surf.idw
       CPU: All | Platform: All
-----------------------+---------------------------------

Comment (by neteler):

Replying to [comment:3 kuszinger]:
> '''Comment only''': Any solution is generated, I've realized that in V7
r.surf.idw eats much more memory than in 6.4. Addition of FCELL and DCELL
is handy, but I'm afraid that it may lead to further memory footprint
growing. I'm ready for testing, anyway, any new version.

I made a test with valgrind
(http://grasswiki.osgeo.org/wiki/GRASS_Debugging#Using_Valgrind) and did
not find any leak:

{{{
# current region:
rows: 7490
cols: 6990
cells: 52355100

# valgrind ...
==29843== LEAK SUMMARY:
==29843== definitely lost: 660 bytes in 24 blocks
==29843== indirectly lost: 0 bytes in 0 blocks
==29843== possibly lost: 0 bytes in 0 blocks
==29843== still reachable: 101,344 bytes in 52 blocks
==29843== suppressed: 0 bytes in 0 blocks
}}}

> I use r.surf.idw extensively on huge sparse rasters where it takes 2 -
10 GB RAM to create the result.

Please indicate how many cols/rows or ideally post a test with the NC
dataset.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2672#comment:4>
GRASS GIS <http://grass.osgeo.org>