#2694: rendering command layer and adding 3d raster layer broken
-----------------------+-------------------------
Reporter: annakrat | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.1.0
Component: wxGUI | Version: svn-trunk
Keywords: rendering | CPU: Unspecified
Platform: Linux |
-----------------------+-------------------------
Two issues I found with the new rendering with the less often used cases:
1. adding 3D raster layer breaks rendering, although there is no error,
rendering just stops working after that and busy cursors stays there. I
was trying to fix this one, but was not able to get rid of the progress
bar which was still showing up:
{{{
Index: core/render.py
--- core/render.py (revision 65443)
+++ core/render.py (working copy)
@@ -472,6 +472,8 @@
# render map layers if forced
nlayers = 0
for layer in self.layers:
+ if layer.GetType() == '3d-raster':
+ continue
if force or layer.forceRender:
nlayers += 1
layer.Render(env)
@@ -532,6 +534,8 @@
for layer in self.layers:
if layer.GetType() == 'overlay':
continue
+ if layer.GetType() == '3d-raster':
+ continue
if os.path.isfile(layer.mapfile):
maps.append(layer.mapfile)
}}}
2. Rendering command layers is weird, (un)checking has no effect.
#2694: rendering command layer and adding 3d raster layer broken
--------------------------+-------------------------
Reporter: annakrat | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.1.0
Component: wxGUI | Version: svn-trunk
Resolution: | Keywords: rendering
CPU: Unspecified | Platform: Linux
--------------------------+-------------------------
Comment (by martinl):
Replying to [ticket:2694 annakrat]:
> 1. adding 3D raster layer breaks rendering, although there is no error,
rendering just stops working after that and busy cursors stays there. I
was trying to fix this one, but was not able to get rid of the progress
bar which was still showing up:
please try out r65450
> 2. Rendering command layers is weird, (un)checking has no effect.
I would suggest to remove command layers from wxGUI completely, what do
you think?
Replying to [comment:1 martinl]:
> Replying to [ticket:2694 annakrat]:
>
> > 1. adding 3D raster layer breaks rendering, although there is no
error, rendering just stops working after that and busy cursors stays
there. I was trying to fix this one, but was not able to get rid of the
progress bar which was still showing up:
>
> please try out r65450
Thank you, works nicely
>
> > 2. Rendering command layers is weird, (un)checking has no effect.
>
> I would suggest to remove command layers from wxGUI completely, what do
you think?
Hm, I was actually using it. For example you can have multiple legends
with command layers and you can save them to workspace. But that's
workaround for not having a way to display multiple legends.
> > I would suggest to remove command layers from wxGUI completely, what
do you think?
>
> Hm, I was actually using it. For example you can have multiple legends
with command layers and you can save them to workspace. But that's
workaround for not having a way to display multiple legends.
I realized d.histogram is not working when called from Map Display
toolbar. It seems that it actually uses the command layers.