[GRASS-dev] [GRASS GIS] #2773: grass-7.0.1 fails to build when compiled with -Werror=format-security"

GRASS GIS GRASS GIS developer
1

#2773: grass-7.0.1 fails to build when compiled with -Werror=format-security"
-----------------------+-------------------------
Reporter: wraeth | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone:
Component: Compiling | Version: 7.0.1
Keywords: | CPU: Unspecified
Platform: Linux |
-----------------------+-------------------------
Building of Grass 7.0.1 fails when the compiler options include -Werror
=format-security, indicating insecure handling of string formatting.
Compile log will be attached containing errors.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2773&gt;
GRASS GIS <https://grass.osgeo.org>

2

#2773: grass-7.0.1 fails to build when compiled with -Werror=format-security"
--------------------------+-------------------------
  Reporter: wraeth | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone:
Component: Compiling | Version: 7.0.1
Resolution: | Keywords:
       CPU: Unspecified | Platform: Linux
--------------------------+-------------------------
Changes (by wraeth):

* Attachment "grass-7.0.1:201510212148.log.gz" added.

Compressed build output

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2773&gt;
GRASS GIS <https://grass.osgeo.org>

3

#2773: grass-7.0.1 fails to build when compiled with -Werror=format-security"
--------------------------+-------------------------
  Reporter: wraeth | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.1
Component: Compiling | Version: 7.0.1
Resolution: | Keywords:
       CPU: Unspecified | Platform: Linux
--------------------------+-------------------------
Changes (by neteler):

* milestone: => 7.0.1

Comment:

This happens when configuring with --with-nls, is that true in your case?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2773#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

4

#2773: grass-7.0.1 fails to build when compiled with -Werror=format-security"
--------------------------+----------------------
  Reporter: wraeth | Owner: martinl
      Type: defect | Status: assigned
  Priority: normal | Milestone: 7.0.2
Component: Compiling | Version: 7.0.1
Resolution: | Keywords:
       CPU: Unspecified | Platform: Linux
--------------------------+----------------------
Changes (by martinl):

* status: new => assigned
* owner: grass-dev@… => martinl
* cc: grass-dev@… (added)
* milestone: 7.0.1 => 7.0.2

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2773#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

5

#2773: grass-7.0.1 fails to build when compiled with -Werror=format-security"
--------------------------+----------------------
  Reporter: wraeth | Owner: martinl
      Type: defect | Status: assigned
  Priority: normal | Milestone: 7.0.2
Component: Compiling | Version: 7.0.1
Resolution: | Keywords:
       CPU: Unspecified | Platform: Linux
--------------------------+----------------------

Comment (by martinl):

Should be fixed in r66561 (trunk). If no objection I would backport it to
relbr70 within few next days.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2773#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

6

#2773: grass-7.0.1 fails to build when compiled with -Werror=format-security"
--------------------------+----------------------
  Reporter: wraeth | Owner: martinl
      Type: defect | Status: assigned
  Priority: normal | Milestone: 7.0.2
Component: Compiling | Version: 7.0.1
Resolution: | Keywords:
       CPU: Unspecified | Platform: Linux
--------------------------+----------------------

Comment (by wraeth):

Replying to [comment:1 neteler]:
> This happens when configuring with --with-nls, is that true in your
case?

Compiling with --without-nls produces the same results.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2773#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

7

#2773: grass-7.0.1 fails to build when compiled with -Werror=format-security"
--------------------------+---------------------
  Reporter: wraeth | Owner: martinl
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.0.2
Component: Compiling | Version: 7.0.1
Resolution: fixed | Keywords:
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------
Changes (by martinl):

* status: assigned => closed
* resolution: => fixed

Comment:

Replying to [comment:3 martinl]:
> Should be fixed in r66561 (trunk). If no objection I would backport it
to relbr70 within few next days.

Done in r66613. Closing the ticket.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2773#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>

8

#2773: grass-7.0.1 fails to build when compiled with -Werror=format-security"
--------------------------+---------------------
  Reporter: wraeth | Owner: martinl
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.0.2
Component: Compiling | Version: 7.0.1
Resolution: fixed | Keywords:
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------

Comment (by neteler):

Partially backported to relbranch64 in r66616

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2773#comment:6&gt;
GRASS GIS <https://grass.osgeo.org>