#2801: wxGUI modeler: overwrite flag not saved when reopening module dialog
--------------------------+------------------------------------
Reporter: mlennert | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.0.3
Component: wxGUI | Version: 7.0.1
Resolution: | Keywords: modeler overwrite flag
CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------
Comment (by martinl):
There were two issues - wxGUI part fixed in r66941. Moreover
`G_recreate_command()` ignored global options (like `--overwrite`), this
issue is fixed r66940. After some testing I will backport both changes to
relbr70.
#2801: wxGUI modeler: overwrite flag not saved when reopening module dialog
--------------------------+------------------------------------
Reporter: mlennert | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.0.3
Component: wxGUI | Version: 7.0.1
Resolution: | Keywords: modeler overwrite flag
CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------
Comment (by martinl):
Replying to [ticket:2801 mlennert]:
> Result: the overwrite flag is not checked anymore. You have to
explicitely set the flag everytime you reopen a module dialogue. Very
annoying...
Please note that you can set overwrite globally for model in `Model ->
Properties` (Graphical Modeler) or for whole GUI in `GUI Preferences ->
Modules` (Layer Manager).
#2801: wxGUI modeler: overwrite flag not saved when reopening module dialog
--------------------------+------------------------------------
Reporter: mlennert | Owner: martinl
Type: defect | Status: assigned
Priority: normal | Milestone: 7.0.3
Component: wxGUI | Version: 7.0.1
Resolution: | Keywords: modeler overwrite flag
CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------
Comment (by wenzeslaus):
Replying to [comment:2 martinl]:
> Replying to [ticket:2801 mlennert]:
>
> > Result: the overwrite flag is not checked anymore. You have to
explicitely set the flag everytime you reopen a module dialogue. Very
annoying...
>
> Please note that you can set overwrite globally for model in `Model ->
Properties` (Graphical Modeler) or for whole GUI in `GUI Preferences ->
Modules` (Layer Manager).
BTW, I think the global settings is a best practice and should be
preferred.
#2801: wxGUI modeler: overwrite flag not saved when reopening module dialog
--------------------------+------------------------------------
Reporter: mlennert | Owner: martinl
Type: defect | Status: assigned
Priority: normal | Milestone: 7.0.3
Component: wxGUI | Version: 7.0.1
Resolution: | Keywords: modeler overwrite flag
CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------
Comment (by mlennert):
Replying to [comment:4 wenzeslaus]:
> Replying to [comment:2 martinl]:
> > Replying to [ticket:2801 mlennert]:
> >
> > > Result: the overwrite flag is not checked anymore. You have to
explicitely set the flag everytime you reopen a module dialogue. Very
annoying...
> >
> > Please note that you can set overwrite globally for model in `Model ->
Properties` (Graphical Modeler) or for whole GUI in `GUI Preferences ->
Modules` (Layer Manager).
>
> BTW, I think the global settings is a best practice and should be
preferred.
Are you speaking about the global setting in the modeler or for the whole
GUI ?
In both cases I strongly disagree. IMHO, automatic overwrite should not be
the default setting. It should always be a deliberate choice by the user.
Thank you for the fixes, Martin, I'll test as soon as possible.
#2801: wxGUI modeler: overwrite flag not saved when reopening module dialog
--------------------------+------------------------------------
Reporter: mlennert | Owner: martinl
Type: defect | Status: assigned
Priority: normal | Milestone: 7.0.3
Component: wxGUI | Version: 7.0.1
Resolution: | Keywords: modeler overwrite flag
CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------
Comment (by mlennert):
Replying to [comment:1 martinl]:
> There were two issues - wxGUI part fixed in r66941. Moreover
`G_recreate_command()` ignored global options (like `--overwrite`), this
issue is fixed r66940. After some testing I will backport both changes to
relbr70.
A quick test shows that both the modeler fix and the general lib fix seem
to work here.
#2801: wxGUI modeler: overwrite flag not saved when reopening module dialog
--------------------------+------------------------------------
Reporter: mlennert | Owner: martinl
Type: defect | Status: assigned
Priority: normal | Milestone: 7.0.3
Component: wxGUI | Version: 7.0.1
Resolution: | Keywords: modeler overwrite flag
CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------
Comment (by wenzeslaus):
Replying to [comment:5 mlennert]:
> Replying to [comment:4 wenzeslaus]:
> > Replying to [comment:2 martinl]:
> > > Replying to [ticket:2801 mlennert]:
> > >
> > > > Result: the overwrite flag is not checked anymore. You have to
explicitely set the flag everytime you reopen a module dialogue. Very
annoying...
> > >
> > > Please note that you can set overwrite globally for model in `Model
-> Properties` (Graphical Modeler) or for whole GUI in `GUI Preferences ->
Modules` (Layer Manager).
> >
> > BTW, I think the global settings is a best practice and should be
preferred.
>
> Are you speaking about the global setting in the modeler or for the
whole GUI ?
>
> In both cases I strongly disagree. IMHO, automatic overwrite should not
be the default setting. It should always be a deliberate choice by the
user.
`Model -> Properties` applies just to the current model (global for the
whole model), right? If the alternative is overwrite checked for every
individual module, then yes, I think it is better.
Replying to [comment:1 martinl]:
> There were two issues - wxGUI part fixed in r66941. Moreover
`G_recreate_command()` ignored global options (like `--overwrite`), this
issue is fixed r66940. After some testing I will backport both changes to
relbr70.
Both issues backported (r67374 and r66981). Closing this ticket, feel free
to reopen if needed.