[GRASS-dev] [GRASS GIS] #2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch Linux

GDAL · February 13, 2016, 6:49pm

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
-----------------------+-------------------------
Reporter: msieczka | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Keywords: | CPU: All
Platform: Linux |
-----------------------+-------------------------
Arch Linux build system by default sets CPPFLAGS="-D_FORTIFY_SOURCE=2".

If I unset FORTIFY_SOURCE, configure and make passes. But when it's set,
configure in GRASS 6 and 7 fails.

I'm attaching config.log-fail (FORTIFY_SOURCE is set) and config.log-pass
(FORTIFY_SOURCE is NOT set) for GRASS 7.0.3. The suspicious bits config
.log-fail seem to be:

{{{
/usr/include/sys/cdefs.h:30:3: error: #error "You need a ISO C conforming
compiler to use the glibc headers"
gcc: error: unrecognized command line option '-nologo'
}}}

gcc 5.3.0, make 4.1, autoconf 2.69

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 13, 2016, 6:50pm

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------
Changes (by msieczka):

* Attachment "config.log-fail" added.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 13, 2016, 6:51pm

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------
Changes (by msieczka):

* Attachment "config.log-pass" added.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 15, 2016, 7:16pm

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by scimmia):

Known issue with the ancient version of autoconf used to generate the
configure script.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:1>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 15, 2016, 11:32pm

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by neteler):

Replying to [ticket:2916 msieczka]:
> gcc 5.3.0, make 4.1, autoconf 2.69

You would need to use autoconf-2.13 if you want to regenerate the
configure script. But I guess you don't do that anyway.

I tried on my Fedora box:
{{{
Copying config.status to config.status.x86_64-pc-linux-gnu

GRASS is now configured for: x86_64-pc-linux-gnu

   Source directory: /home/neteler/software/grass71
   Build directory: /home/neteler/software/grass71
   Installation directory: ${prefix}/grass-7.1.svn
   Startup script in directory:${exec_prefix}/bin
   C compiler: gcc -O2 -march=native -fdiagnostics-color
   C++ compiler: c++ -O2 -D_FORTIFY_SOURCE=2
...

gcc --version
gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2)
}}}

I have a link which seems to be missing on your system according to your
log file:
{{{
ls -la /lib/cpp
lrwxrwxrwx 1 root root 10 Dec 8 18:45 /lib/cpp -> ../bin/cpp*

# its origin:
rpm -qf /lib/cpp
cpp-5.3.1-2.fc23.x86_64
}}}

Maybe you simply lost that link?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:2>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 16, 2016, 11:21am

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by msieczka):

Replying to [comment:2 neteler]:
> Replying to [ticket:2916 msieczka]:
> > gcc 5.3.0, make 4.1, autoconf 2.69
>
> You would need to use autoconf-2.13 if you want to regenerate the
configure script. But I guess you don't do that anyway.

I'd rather rely on an upstream-provided configure script, if possible.

> I tried on my Fedora box:
> {{{
> C++ compiler: c++ -O2 -D_FORTIFY_SOURCE=2
> }}}

Is it OK that CPPFLAGS content ends up in CXXFLAGS?

> I have a link which seems to be missing on your system according to your
log file:
> {{{
> ls -la /lib/cpp
> lrwxrwxrwx 1 root root 10 Dec 8 18:45 /lib/cpp -> ../bin/cpp*
>
> # its origin:
> rpm -qf /lib/cpp
> cpp-5.3.1-2.fc23.x86_64
> }}}
>
> Maybe you simply lost that link?

There is no CPP package as such on Arch Linux. cpp, gcc and g++
executables come in a single GCC package here. It doesn't provide this
`/lib/cpp' link.

Anyway, I created /lib/cpp -> ../bin/cpp symlink manually, but this
doesn't help and doesn't seem to be the actual issue. The references to a
missing /lib/cpp link only got replaced by yet more "_FORTIFY_SOURCE
requires compiling with optimization" warnings. The original errors
remain:

{{{
/usr/include/sys/cdefs.h:30:3: error: #error "You need a ISO C conforming
compiler to use the glibc headers"
gcc: error: unrecognized command line option '-nologo'
}}}

I'm attaching a complete config.log-fail-with_cpp_symlink.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:3>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 16, 2016, 11:22am

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------
Changes (by msieczka):

* Attachment "config.log-fail-with_cpp_symlink" added.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 16, 2016, 11:53am

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by msieczka):

Replying to [comment:2 neteler]:

> You would need to use autoconf-2.13 if you want to regenerate the
configure script. But I guess you don't do that anyway.

I have regenerated the configure script with autoconf-2.13 now. No
improvement: configure still fails when CPPFLAGS="-D_FORTIFY_SOURCE=2" is
set, and the resulting config.log is pretty much identical to the attached
config.log-fail.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:4>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 16, 2016, 3:59pm

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by neteler):

Replying to [comment:4 msieczka]:
> I have regenerated the configure script

Why do you do this? there is no need for that, all is in SVN.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:5>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 16, 2016, 4:04pm

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by neteler):

Replying to [comment:3 msieczka]:
> Replying to [comment:2 neteler]:
> > Replying to [ticket:2916 msieczka]:
> > > gcc 5.3.0, make 4.1, autoconf 2.69
> >
> > You would need to use autoconf-2.13 if you want to regenerate the
configure script. But I guess you don't do that anyway.
>
> I'd rather rely on an upstream-provided configure script, if possible.

?
SVN-grass is upstream.

> There is no CPP package as such on Arch Linux. cpp, gcc and g++
executables come in a single GCC package here.

I see.

> It doesn't provide this `/lib/cpp' link.

Seems to be a known issue in Archlinux, e.g.:
https://bbs.archlinux.org/viewtopic.php?id=147199

Suggestion: Try to set CPP, then configure (guessing here):

{{{
export CPP=/usr/bin/cpp
configure ...
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:6>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 17, 2016, 1:50am

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by glynn):

Replying to [ticket:2916 msieczka]:
> Arch Linux build system by default sets CPPFLAGS="-D_FORTIFY_SOURCE=2".
>
> If I unset FORTIFY_SOURCE, configure and make passes. But when it's set,
configure in GRASS 6 and 7 fails.

{{{
configure:2722: checking how to run the C preprocessor
configure:2741: gcc -E -D_FORTIFY_SOURCE=2 conftest.c >/dev/null
2>conftest.out
In file included from /usr/include/assert.h:35:0,
                  from configure:2736:
/usr/include/features.h:328:4: warning: #warning _FORTIFY_SOURCE requires
compiling with optimization (-O) [-Wcpp]
  # warning _FORTIFY_SOURCE requires compiling with optimization (-O)
     ^
configure: failed program was:
}}}

This all arises because autoconf tends to treat ANYTHING written to stderr
as indicating a failure.

It then goes on to try:

{{{
configure:2758: gcc -E -traditional-cpp -D_FORTIFY_SOURCE=2 conftest.c
>/dev/null 2>conftest.out
In file included from /usr/include/assert.h:36:0,
from configure:2754:
/usr/include/features.h:328:4: warning: #warning _FORTIFY_SOURCE requires
compiling with optimization (-O) [-Wcpp]
# warning _FORTIFY_SOURCE requires compiling with optimization (-O)
}}}

which fails for the same reason.

Finally it tries:

{{{
configure:2775: gcc -nologo -E -D_FORTIFY_SOURCE=2 conftest.c >/dev/null
2>conftest.out
gcc: error: unrecognized command line option '-nologo'
}}}

After everything it has tried has failed (by its standards), it
unconditionally sets CPP to /lib/cpp and uses that (resulting in every
subsequent use of $(CPP) failing).

The first thing it tried (gcc -E) would actually work, but it doesn't know
that.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:7>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 17, 2016, 4:59pm

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by msieczka):

Replying to [comment:5 neteler]:
> Replying to [comment:4 msieczka]:
> > I have regenerated the configure script
>
> Why do you do this? there is no need for that, all is in SVN.

I thought I'd try this after your #comment:2, quote:
"You would need to use autoconf-2.13 if you want to regenerate the
configure script. But I guess you don't do that anyway."

Nevermind.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:8>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 17, 2016, 5:06pm

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by msieczka):

Replying to [comment:6 neteler]:
> Replying to [comment:3 msieczka]:
> > Replying to [comment:2 neteler]:
> > > Replying to [ticket:2916 msieczka]:
> > > > gcc 5.3.0, make 4.1, autoconf 2.69
> > >
> > > You would need to use autoconf-2.13 if you want to regenerate the
configure script. But I guess you don't do that anyway.
> >
> > I'd rather rely on an upstream-provided configure script, if possible.
>
> ?
> SVN-grass is upstream.

I'm talking from Arch Linux package perspective. In that case "upstream"
is GRASS 7.0.3 source code tarball.

> > There is no CPP package as such on Arch Linux. cpp, gcc and g++
executables come in a single GCC package here.
>
> I see.
>
> > It doesn't provide this `/lib/cpp' link.
>
> Seems to be a known issue in Archlinux, e.g.:
> https://bbs.archlinux.org/viewtopic.php?id=147199
>
> Suggestion: Try to set CPP, then configure (guessing here):
>
> {{{
> export CPP=/usr/bin/cpp
> configure ...
> }}}

Thanks. This doesn't change anything though.

I think Glynn nailed it. I'm going to have a closer look at his comments
now.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:9>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 17, 2016, 5:21pm

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by msieczka):

Replying to [comment:7 glynn]:
> Replying to [ticket:2916 msieczka]:
> > Arch Linux build system by default sets
CPPFLAGS="-D_FORTIFY_SOURCE=2".
> >
> > If I unset FORTIFY_SOURCE, configure and make passes. But when it's
set, configure in GRASS 6 and 7 fails.
>
> {{{
> configure:2722: checking how to run the C preprocessor
> configure:2741: gcc -E -D_FORTIFY_SOURCE=2 conftest.c >/dev/null
2>conftest.out
> In file included from /usr/include/assert.h:35:0,
> from configure:2736:
> /usr/include/features.h:328:4: warning: #warning _FORTIFY_SOURCE
requires compiling with optimization (-O) [-Wcpp]
> # warning _FORTIFY_SOURCE requires compiling with optimization (-O)
> ^
> configure: failed program was:
> }}}
>
> This all arises because autoconf tends to treat ANYTHING written to
stderr as indicating a failure.

Thanks for the explanation. Do you know why this "_FORTIFY_SOURCE requires
compiling with optimization (-O)" warning is triggered? I think it
shouldn't be, because I do have optimization enabled in my build
environment:

{{{
$ grep '\-O' /etc/makepkg.conf
CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong"
CXXFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong"
LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro"
}}}

config.log-fail contents also reflect this.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:10>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 17, 2016, 6:20pm

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by glynn):

Replying to [comment:10 msieczka]:

> Thanks for the explanation. Do you know why this "_FORTIFY_SOURCE
requires compiling with optimization (-O)" warning is triggered? I think
it shouldn't be, because I do have optimization enabled in my build
environment:

Optimisation switches are normally in CFLAGS or CXXFLAGS, while -D
switches are normally in CPPFLAGS. The configure checks for the
preprocessor don't pass $(CFLAGS) or $(CXXFLAGS) because most of the
switches that they're likely to contain often aren't recognised by a
standalone preprocessor, and may result in an error. The comment in
autoconf/c.m4 says:
{{{
# CFLAGS is not in ac_cpp because -g, -O, etc. are not valid cpp options.
}}}

Apart from that, there are valid reasons for compiling without
optimisation (e.g. it often makes debugging significantly more difficult),
so forcibly enabling _FORTIFY_SOURCE doesn't appear to have been a
particularly wise move.

FWIW, on Gentoo this is implemented within the compiler:
{{{
$ gcc -E -dM -O2 -x c /dev/null | fgrep FORTIFY
#define _FORTIFY_SOURCE ((defined __OPTIMIZE__ && __OPTIMIZE__ > 0) ? 2 :
0)
}}}
I.e. _FORTIFY_SOURCE is enabled automatically if and only if optimisation
is enabled.

As for workarounds, the simplest to implement would be to have
configure.in check whether $(CPPFLAGS) contains -D_FORTIFY_SOURCE and
either attempt to remove it or generate an error telling the user to
remove it. It can always be added to CFLAGS and/or CXXFLAGS.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2916#comment:11>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 17, 2016, 11:47pm

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by msieczka):

I forgot to say that the /etc/makepkg.conf contents I quoted are as per
default Arch Linux settings, and that makepkg is an official build tool
for Arch packages. I'm saying this just to clarify that I'm not making
this case up, but that it's a real issue for Arch GRASS users, in case
anybody wondered.

So far I've been removing D_FORTIFY_SOURCE from CPPFLAGS before configure
as follows, in my Arch GRASS PKGBUILD (which is an input for makepkg,
something like a Gentoo ebuild):

{{{
CPPFLAGS=`echo $CPPFLAGS | sed 's/-D_FORTIFY_SOURCE=.//g'`
}}}

If understand what you are saying, the following would be better (putting
aside your point against forcibly enabling _FORTIFY_SOURCE at all):

{{{
export CFLAGS="$CPPFLAGS $CFLAGS"
export CXXFLAGS="$CPPFLAGS $CXXFLAGS"
unset CPPFLAGS
}}}

By "better" here I mean "preserving the intended makepkg environment at
GRASS build-time".

Do you know whether all (sane) CPPFLAGS can be safely be mixed into
CXXFLAGS and CFLAGS like this?

And what do you think about scimmia's "ancient version of autoconf used"
#comment:1? I mean could using a newer autoconf version to generate the
GRASS configure script fix the problem?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:12>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 19, 2016, 2:00am

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by glynn):

Replying to [comment:12 msieczka]:

> If understand what you are saying, the following would be better
(putting aside your point against forcibly enabling _FORTIFY_SOURCE at
all):
>
{{{
export CFLAGS="$CPPFLAGS $CFLAGS"
export CXXFLAGS="$CPPFLAGS $CXXFLAGS"
unset CPPFLAGS
}}}

The problem with this is that it breaks any case where the preprocessor is
run standalone, rather than as part of compilation.

I don't think that happens anywhere within actual the GRASS build process,
as Platform.make.in doesn't mention @CPP@ anywhere (so there's no valid
way for a Makefile to know how to run the preprocessor by itself).

But it can create problems for the configure script, which uses the pre-
processor extensively. E.g. AC_CHECK_HEADERS is based upon AC_TRY_CPP, so
if it needs e.g. any -I switches from CPPFLAGS, moving those into
CFLAGS/CXXFLAGS will break it.

> Do you know whether all (sane) CPPFLAGS can be safely be mixed into
CXXFLAGS and CFLAGS like this?

That isn't a problem. The C compiler is always passed both $(CFLAGS) and
$(CPPFLAGS), while the C++ compiler is always passed both $(CXXFLAGS) and
$(CPPFLAGS). If the preprocessor is run separately, it should only be
passed $(CPPFLAGS), hence the distinction.

> And what do you think about scimmia's "ancient version of autoconf used"
#comment:1? I mean could using a newer autoconf version to generate the
GRASS configure script fix the problem?

Maybe. Like many autoconf macros, AC_PROG_CPP runs through a fixed set of
candidates until one appears to work. It's possible that a newer version
has more candidates. Or it's possible that it's smarter at ignoring
warnings from the preprocessor.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:13>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 19, 2016, 5:18am

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by msieczka):

Replying to [comment:13 glynn]:

How about this:

{{{
CFLAGS="$CPPFLAGS $CFLAGS" CXXFLAGS="$CPPFLAGS $CXXFLAGS" CPPFLAGS=`echo
$CPPFLAGS | sed 's/-D_FORTIFY_SOURCE=.//g'` ./configure
}}}

This way I'm passing all CPPFLAGS as declared in /etc/makepkg.conf to
CXXFLAGS and CFLAGS for make, I don't give up on CPPFLAGS entirely in case
it contained anything that configure could need, but I drop
D_FORTIFY_SOURCE from CPPFLAGS for configure, to avoid the
"_FORTIFY_SOURCE requires compiling with optimization" issue. Seems least
intrusive and foolproof?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:14>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 22, 2016, 7:57am

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by glynn):

Replying to [comment:14 msieczka]:

> How about this:
>
{{{
CFLAGS="$CPPFLAGS $CFLAGS" CXXFLAGS="$CPPFLAGS $CXXFLAGS" CPPFLAGS=`echo
$CPPFLAGS | sed 's/-D_FORTIFY_SOURCE=.//g'` ./configure
}}}

It would be better if any _FORTIFY_SOURCE definition could be extracted
and moved into CFLAGS/CXXFLAGS, e.g.

{{{
FORTIFY_FLAGS=`echo "$CPPFLAGS" | sed
'/^.*$-D_FORTIFY_SOURCE=.$.*$/s//\1/'`
CPPFLAGS=`echo "$CPPFLAGS" | sed 's/-D_FORTIFY_SOURCE=.//g'`
CFLAGS="$FORTIFY_FLAGS $CFLAGS"
CXXFLAGS="$FORTIFY_FLAGS $CXXFLAGS"
}}}

This avoids any potential problems with duplicating the other elements of
$CPPFLAGS.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:15>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 22, 2016, 9:42am

#2916: configure bug (?): FORTIFY_SOURCE in CPPFLAGS breaks configure on Arch
Linux
------------------------+-------------------------
  Reporter: msieczka | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords:
       CPU: All | Platform: Linux
------------------------+-------------------------

Comment (by msieczka):

Replying to [comment:15 glynn]:

> It would be better if any _FORTIFY_SOURCE definition could be extracted
and moved into CFLAGS/CXXFLAGS, e.g.
> (...)

Excellent. Thanks a ton.

In summary: there's nothing that GRASS should do about this issue, it's
down to the fact that D_FORTIFY_SOURCE should not go into CPPFLAGS, only
to CFLAGS and CXXFLAGS. Please let me know whether that's correct.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2916#comment:16>
GRASS GIS <https://grass.osgeo.org>