[GRASS-dev] [GRASS GIS] #2959: r.viewshed, r.terraflow and i.atcorr broken in 32/64bit builds

#2959: r.viewshed, r.terraflow and i.atcorr broken in 32/64bit builds
-------------------------------------------------+-------------------------
Reporter: wenzeslaus | Owner: grass-dev@…
     Type: defect | Status: new
Priority: blocker | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Keywords: c++, r.viewshed, r.terraflow, | CPU: All
  i.atcorr, mingw64, mingw |
Platform: MSWindows 8 |
-------------------------------------------------+-------------------------
`r.viewshed`, `r.terraflow` and `i.atcorr` are not working in the new MS
Windows builds. These are C++ modules and does not work in 32bit and 64bit
versions.

The executable exists. The error message when running r.viewshed from the
system terminal is shown in a dialog:

{{{
The application was unable to start correctly (0xc000007b)
}}}

In relation to this message a [http://stackoverflow.com/questions/10492037
/the-application-was-unable-to-start-correctly-0xc000007b StackOverflow
posts] mentions `STATUS_INVALID_IMAGE_FORMAT` and 32-64 mismatch.

The issues were partially already reported in the following:

* [https://lists.osgeo.org/pipermail/grass-user/2016-February/073678.html
Error running r.viewshed in GRASS 7.0.3 on Windows 7]
* [http://gis.stackexchange.com/questions/179575/cannot-open-r-viewshed-
on-grass-7 Cannot open r.viewshed on Grass 7]
* [https://lists.osgeo.org/pipermail/grass-dev/2016-February/078842.html
C++ and libLAS modules broken in 7.0.3 in winGRASS]
* #2884

Applies to all variations:
* GRASS version: 7.1.svn (r67915, 2016-01-22), 7.0.3 (r67691, 2016-01-28)
* Build Platform: `x86_64-w64-mingw32` and `i386-w64-mingw32`
* Platform: `Windows-7-6.1.7601-SP1 (OSGeo4W)` and standalone
`Windows-8-6.2.9200`

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2959&gt;
GRASS GIS <https://grass.osgeo.org>

#2959: r.viewshed, r.terraflow and i.atcorr broken in 32/64bit builds
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords: c++, r.viewshed, r.terraflow,
                         | i.atcorr, mingw64, mingw
       CPU: All | Platform: MSWindows 8
-------------------------+-------------------------------------------------

Comment (by hellik):

Replying to [ticket:2959 wenzeslaus]:
> `r.viewshed`, `r.terraflow` and `i.atcorr` are not working in the new MS
Windows builds. These are C++ modules and does not work in 32bit and 64bit
versions.
>
> The executable exists. The error message when running r.viewshed from
the system terminal is shown in a dialog:
>
> {{{
> The application was unable to start correctly (0xc000007b)
> }}}
>
> In relation to this message a
[http://stackoverflow.com/questions/10492037/the-application-was-unable-
to-start-correctly-0xc000007b StackOverflow posts] mentions
`STATUS_INVALID_IMAGE_FORMAT` and 32-64 mismatch.
>
> The issues were partially already reported in the following:
>
> * [https://lists.osgeo.org/pipermail/grass-
user/2016-February/073678.html Error running r.viewshed in GRASS 7.0.3 on
Windows 7]
> * [http://gis.stackexchange.com/questions/179575/cannot-open-r-viewshed-
on-grass-7 Cannot open r.viewshed on Grass 7]
> * [https://lists.osgeo.org/pipermail/grass-dev/2016-February/078842.html
C++ and libLAS modules broken in 7.0.3 in winGRASS]
> * #2884
>
> Applies to all variations:
> * GRASS version: 7.1.svn (r67915, 2016-01-22), 7.0.3 (r67691,
2016-01-28)
> * Build Platform: `x86_64-w64-mingw32` and `i386-w64-mingw32`
> * Platform: `Windows-7-6.1.7601-SP1 (OSGeo4W)` and standalone
`Windows-8-6.2.9200`

See also
https://trac.osgeo.org/grass/ticket/2884

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2959#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

#2959: r.viewshed, r.terraflow and i.atcorr broken in 32/64bit builds
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords: c++, r.viewshed, r.terraflow,
                         | i.atcorr, mingw64, mingw
       CPU: All | Platform: MSWindows 8
-------------------------+-------------------------------------------------
Changes (by annakrat):

* Attachment "error_viewshed.png" added.

error message

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2959&gt;
GRASS GIS <https://grass.osgeo.org>

#2959: r.viewshed, r.terraflow and i.atcorr broken in 32/64bit builds
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords: c++, r.viewshed, r.terraflow,
                         | i.atcorr, mingw64, mingw
       CPU: All | Platform: MSWindows 8
-------------------------+-------------------------------------------------

Comment (by annakrat):

I attached a message I get on Windows, perhaps might be helpful.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2959#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

#2959: r.viewshed, r.terraflow and i.atcorr broken in 32/64bit builds
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords: c++, r.viewshed, r.terraflow,
                         | i.atcorr, mingw64, mingw
       CPU: All | Platform: MSWindows 8
-------------------------+-------------------------------------------------

Comment (by martinl):

I added missing library to the builds in r68144 and r68145. Please check
tomorrow's build.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2959#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

#2959: r.viewshed, r.terraflow and i.atcorr broken in 32/64bit builds
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords: c++, r.viewshed, r.terraflow,
                         | i.atcorr, mingw64, mingw
       CPU: All | Platform: MSWindows 8
-------------------------+-------------------------------------------------

Comment (by wenzeslaus):

Replying to [comment:1 hellik]:
> See also
> https://trac.osgeo.org/grass/ticket/2884

Off topic: Tickets on Trac can be linked using hash and number, e.g.:
`#2884`. The advantage is that Trac will tell you ticket title and status
in the tool tip and will strike out closed tickets. See for example the
original description of the ticket where I actually speak about `i.atcorr`
and link #2884. Also I don't see a need to quote the whole original
description. That's why we use Trac and not just mailing list for tracking
the issues. No need to read through description twice when I open the
ticket page.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2959#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

#2959: r.viewshed, r.terraflow and i.atcorr broken in 32/64bit builds
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: | Keywords: c++, r.viewshed, r.terraflow,
                         | i.atcorr, mingw64, mingw
       CPU: All | Platform: MSWindows 8
-------------------------+-------------------------------------------------

Comment (by martinl):

Replying to [comment:3 martinl]:
> I added missing library to the builds in r68144 and r68145. Please check
tomorrow's build.

I have tested latest 7.0.4svn build and it seems to be fixed (I tested
`r.viewshed`). Please confirm.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2959#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>

#2959: r.viewshed, r.terraflow and i.atcorr broken in 32/64bit builds
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: blocker | Milestone: 7.0.4
Component: Compiling | Version: 7.0.3
Resolution: fixed | Keywords: c++, r.viewshed, r.terraflow,
                         | i.atcorr, mingw64, mingw
       CPU: All | Platform: MSWindows 8
-------------------------+-------------------------------------------------
Changes (by annakrat):

* status: new => closed
* resolution: => fixed

Comment:

Yes, it's working, thanks!

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2959#comment:6&gt;
GRASS GIS <https://grass.osgeo.org>