[GRASS-dev] [GRASS GIS] #2988: Install additional hicolor icon sizes

#2988: Install additional hicolor icon sizes
-------------------------+-------------------------
Reporter: sebastic | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Keywords: | CPU: All
Platform: Linux |
-------------------------+-------------------------
The attached patch and tarball with icons are required for Debian Policy
compliance, which requires at least 22x22 PNG icons:
> Unless hidden by default, the desktop entry must point to a PNG or SVG
icon with a transparent background, providing at least the 22×22 size, and
preferably up to 64×64. The icon should be neutral enough to integrate
well with the default icon themes. It is encouraged to ship the icon in
the default hicolor icon theme directories, or to use an existing icon
from the hicolor theme.

[https://www.debian.org/doc/debian-policy/ch-opersys.html#s-menus Debian
Policy Manual 9.6 Menus]

The 48x48, 64x64 & SVG icons were already installed, these additional PNG
icons are mostly required for DEs which don't support SVG.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------
Changes (by sebastic):

* Attachment "hicolor-icons.patch" added.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------

Comment (by martinl):

The inner part of icons should be white (and not transparent), see
original png icons and recently updated
source:grass/trunk/gui/icons/grass.ico

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------

Comment (by sebastic):

The .ico is not installed (because "using different icons can be confusing
for the user" according to the comment in the Makefile), and the 48x48 and
64x64 PNG icons also use a transparent background.

A transparent background fits better with different themes especially dark
ones where the white icon doesn't fit well. This is in line with the
[https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-
latest.html#install_icons Icon Theme Specification] which recommends:
> It is recommended that the icons installed in the hicolor theme look
neutral, since it is a fallback theme that will be used in combination
with some very different looking themes. But if you don't have any neutral
icon, please install whatever icon you have in the hicolor theme so that
all applications get at least some icon in all themes.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------

Comment (by martinl):

Replying to [comment:2 sebastic]:
> A transparent background fits better with different themes especially
dark ones where the white icon doesn't fit well. This is in line with the
[https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-
latest.html#install_icons Icon Theme Specification] which recommends:

I do not agree. Transparent inner part makes the icon almost unreadable on
some themes.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------

Comment (by martinl):

Replying to [comment:2 sebastic]:
> The .ico is not installed (because "using different icons can be
confusing for the user" according to the comment in the Makefile), and the
48x48 and 64x64 PNG icons also use a transparent background.

no, see source:grass/trunk/gui/icons/grass-48x48.png

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------

Comment (by sebastic):

Ah, your just talking about the filling of the square, not the background.

Please note that the existing SVG icon does not fill the square either,
that should be fixed along with the additional icons.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------
Changes (by sebastic):

* Attachment "hicolor-icons.tar.gz" removed.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------
Changes (by sebastic):

* Attachment "hicolor-icons.tar.gz" added.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------
Changes (by sebastic):

* Attachment "grass.svg" added.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------

Comment (by sebastic):

Have a look at the updated icons, the PNGs in the tarball and the separate
SVG now use a white fill for the square.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988#comment:6&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: fixed | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------
Changes (by martinl):

* status: new => closed
* resolution: => fixed

Comment:

Thanks, applied in trunk in r68263, r68264. Backported to relbr70 as
r68265.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988#comment:7&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: fixed | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------
Changes (by sebastic):

* Attachment "grass70-icons.patch" added.

The icons in relbr70 need to be installed as grass70.png, not grass71.png
as in trunk.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988&gt;
GRASS GIS <https://grass.osgeo.org>

#2988: Install additional hicolor icon sizes
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 7.0.4
Component: wxGUI | Version: svn-trunk
Resolution: fixed | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------

Comment (by martinl):

Ops, fixed in r68266. Thanks for pinging me.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2988#comment:8&gt;
GRASS GIS <https://grass.osgeo.org>