[GRASS-dev] [GRASS GIS] #2996: Lidar modules broken in 64bit WinGRASS

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------------------------------+-------------------------
Reporter: wenzeslaus | Owner: grass-dev@…
     Type: defect | Status: new
Priority: blocker | Milestone: 7.0.4
Component: Packaging | Version: svn-
Keywords: lasinfo, r.in.lidar, v.in.lidar, | releasebranch70
  r3.in.lidar, libLAS | CPU: x86-64
Platform: Unspecified |
-------------------------------------------------+-------------------------
`lasinfo`, `r.in.lidar` and `v.in.lidar` are broken in 64bit version of
7.0.4svn (r68280) and 7.1.svn (r68287). The modules are present, show GUI
and show help but will fail to work with any file (tried two, one is
[http://courses.ncsu.edu/mea582/common/media/01/0793_016.las.zip here]).
`lasinfo` fails as well. Possible commands:

{{{
lasinfo 0793_016.las
r.in.lidar -e input=0793_016.las output=n method=n resolution=5 -o
}}}

{{{
System Info
GRASS version: 7.1.svn
GRASS SVN revision: r68287
Build date: 2016-04-20
Build platform: x86_64-w64-mingw32
GDAL: 2.0.2
PROJ.4: 4.9.2
GEOS: 3.5.0
SQLite: 3.7.17
Python: 2.7.5
wxPython: 2.8.12.1
Platform: Windows-8-6.2.9200
}}}

Running them with `--help` works as well as e.g. `r.in.gdal` works in the
64bit version.

In 32bit version (7.0.4RC1 and 7.1.svn), `lasinfo` and `r.in.lidar` work:

{{{
GRASS version: 7.1.svn
GRASS SVN revision: r68287
Build date: 2016-04-20
Build platform: i386-w64-mingw32
GDAL: 2.0.2
PROJ.4: 4.9.2
GEOS: 3.5.0
SQLite: 3.7.17
Python: 2.7.4
wxPython: 2.8.12.1
Platform: Windows-8-6.2.9200
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by martinl):

I can confirm this bug. I just wonder whether it's problem of GRASS or
liblas OSGeo4W package.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by martinl):

I tried to install fresh OSGeo4W64 just with `liblas` cmd package.
`lasinfo` fails with the same error as described. So it's appearently bug
in `liblas` osgeo4w packaging. I suggest to report this issue in osgeo4w
trac and close this bugreport.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by wenzeslaus):

Replying to [comment:2 martinl]:
> I suggest to report this issue in osgeo4w trac

Done in:

https://trac.osgeo.org/osgeo4w/ticket/493

> close this bugreport.

I'm not sure. We should not release without the OSGeo4W 493 issue fixed.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by martinl):

Replying to [comment:3 wenzeslaus]:

> I'm not sure. We should not release without the OSGeo4W 493 issue fixed.

well, it depends when it will be fixed. In my eyes it's not blocker whole
GRASS release.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by wenzeslaus):

Replying to [comment:4 martinl]:
> well, it depends when it will be fixed. In my eyes it's not blocker
whole GRASS release.

Well, the question is what

> We can always build fixed Windows package with updated liblas.

We've already tried that for 7.0.3 by mistake. libLAS modules and C++ were
broken. It created a lot of questions. There was no way of downloading
installer of a stable version which does what the previous one did (libLAS
and C++ modules). Now, we would have to provide 7.0.3 alongside with 7.0.4
unless we don't want users to download 6.4. We would also have to tell
users before download that they should not download 7.0.4 if they want to
use these and these modules.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by martinl):

Replying to [comment:5 wenzeslaus]:
> Replying to [comment:4 martinl]:
> > well, it depends when it will be fixed. In my eyes it's not blocker
whole GRASS release.
>
> Well, the question is what

liblas package in osgeo4w. It's not our deal.

> > We can always build fixed Windows package with updated liblas.
>
> We've already tried that for 7.0.3 by mistake. libLAS modules and C++
were broken. It created a lot of questions. There was no way of
downloading installer of a stable version which does

C++ modules are now fixed, so? Another reason why to not wait with 7.0.4
release.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:6&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: blocker | Milestone: 7.0.4
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by martinl):

Please consider downgrading priority or even closing this ticket. ASAIU
this ticket is not related to GRASS but liblas itself.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2996#comment:7&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.0.4
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------
Changes (by wenzeslaus):

* priority: blocker => critical

Comment:

Downgraded but how to communicate to users that they should install
install 32bit version if they want these modules to work?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:8&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.0.5
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by martinl):

The issue seems to be gone with all (64bit) builds (7.0.5/7.2/7.3)
starting on 10/7. Testing welcome.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:10&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: critical | Milestone: 7.0.5
Component: Packaging | Version: svn-releasebranch70
Resolution: fixed | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------
Changes (by martinl):

* status: new => closed
* resolution: => fixed

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:11&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: reopened
  Priority: critical | Milestone: 7.0.5
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------
Changes (by annakrat):

* status: closed => reopened
* resolution: fixed =>

Comment:

Tested 32 and 64bit 7.0.5, 7.2, standalone and OSGeo4W and las tools and
v/r.in.lidar are not working. Several people here reported the same, it
worked for one colleague for some reason. How did it get broken again?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:12&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: reopened
  Priority: critical | Milestone: 7.0.5
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by hellik):

Replying to [comment:12 annakrat]:
> Tested 32 and 64bit 7.0.5, 7.2, standalone and OSGeo4W and las tools and
v/r.in.lidar are not working. Several people here reported the same, it
worked for one colleague for some reason. How did it get broken again?

tested here with

{{{
System Info
GRASS version: 7.3.svn
GRASS SVN revision: r69714
Build date: 2016-10-24
Build platform: i386-w64-mingw32
GDAL: 2.1.1
PROJ.4: 4.9.3
GEOS: 3.5.0
SQLite: 3.14.1
Python: 2.7.4
wxPython: 2.8.12.1
Platform: Windows-Vista-6.0.6002-SP2 (OSGeo4W)
}}}

and

{{{
lasinfo (libLAS 1.7.0 with GeoTIFF 1.3.0 GDAL 1.8.1 LASzip 2.1.0)
}}}

v.in.lidar fails with the data from the
[https://grasswiki.osgeo.org/wiki/LIDAR#Import_LAS_as_vector_points wiki
example].

also lasinfo itself fails on this sample data set.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:13&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: reopened
  Priority: critical | Milestone: 7.0.5
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by hellik):

Replying to [comment:13 hellik]:
> also lasinfo itself fails on this sample data set.

but e.g. las2txt of the same osgeo4w environment works without failing.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:14&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: reopened
  Priority: critical | Milestone: 7.0.5
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by hellik):

Replying to [comment:13 hellik]:
>
> tested here with
>
> {{{
> System Info
> GRASS version: 7.3.svn
> GRASS SVN revision: r69714
> Build date: 2016-10-24
> Build platform: i386-w64-mingw32
> GDAL: 2.1.1
> PROJ.4: 4.9.3
> GEOS: 3.5.0
> SQLite: 3.14.1
> Python: 2.7.4
> wxPython: 2.8.12.1
> Platform: Windows-Vista-6.0.6002-SP2 (OSGeo4W)
> }}}

now tested with

{{{
System Info
GRASS Version: 7.3.svn
GRASS SVN revision: r69714
Build date: 2016-10-24
Build platform: x86_64-w64-mingw32
GDAL: 2.1.1
PROJ.4: 4.9.3
GEOS: 3.5.0
SQLite: 3.14.1
Python: 2.7.5
wxPython: 2.8.12.1
Platform: Windows-8-6.2.9200 (OSGeo4W)
}}}

{{{
lasinfo Serpent_Mound_Model_LAS_Data.las
---------------------------------------------------------
   Header Summary
---------------------------------------------------------

   Version: 1.0
   Source ID: 0
   Reserved: 0
   Project ID/GUID: '00000000-0000-0000-0000-000000000000'
   System ID: ''
   Generating Software: 'TerraScan'
   File Creation Day/Year: 0/0
   Header Byte Size 227
   Data Offset: 759
   Header Padding: 2
[...]
}}}

{{{
v.in.lidar -p input=D:\temp\lidartest\Serpent_Mound_Model_LAS_Data.las
Using LAS Library Version 'libLAS 1.8.0 with GeoTIFF 1.4.0 GDAL 1.11.3
LASzip 2.2.0'
LAS File Version: 1.0
System ID: ''
Generating Software: 'TerraScan'
File Creation Day/Year: 0/0
Point Data Format: 1
Number of Point Records: 3265110
Number of Points by Return: 0 0 0 0 0
Scale Factor X Y Z: 0.01 0.01 0.01
Offset X Y Z: -0 -0 -0
Min X Y Z: 289021 4.32094e+006 166.78
Max X Y Z: 290106 4.32364e+006 215.48
Spatial Reference:
+proj=utm +zone=17 +datum=WGS84 +units=m +no_defs
Data Fields:
   'X'
   'Y'
   'Z'
   'Intensity'
   'Return Number'
   'Number of Returns'
   'Scan Direction'
   'Flighline Edge'
   'Classification'
   'Scan Angle Rank'
   'User Data'
   'Point Source ID'
   'GPS Time'
[...]
}}}

{{{
v.in.lidar -e -t -b
input=D:\temp\lidartest\Serpent_Mound_Model_LAS_Data.las
output=Serpent_Mound_Model_pts
Die Projektionsinformationen des Eingabedatensatzes und der aktuellen
Location scheinen übereinzustimmen.
Scanning 3265110 points...
16416272 points imported (limit was 1024)
219 input points were skipped by count-based decimation
The rest of points was ignored
}}}

on this win10 64bit box it works.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:15&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: reopened
  Priority: critical | Milestone: 7.0.6
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------
Changes (by martinl):

* milestone: 7.0.5 => 7.0.6

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:16&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: reopened
  Priority: critical | Milestone: 7.0.6
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by martinl):

I tested `v.in.lidar` (64bit) with results below:

OSGeo4W: works (g73,g705); broken (g72rc)

Standalone: works (g705, g72rc, g72svn-n96)

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:17&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: reopened
  Priority: critical | Milestone: 7.0.6
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by annakrat):

I tested on 2 machines. First one is freshly installed Windows 10 and
r.in.lidar does not even start. Here it seems some of the needed dlls are
missing. When running r.in.lidar from terminal, it says msvcp120.dll and
msvcr120.dll are missing. So I found them in some obscure system directory
and copied them to extrabin and then everything works.

Then I tested an older computer. Here nothing works, but it behaves
differently. r.in.lidar starts, but then it says GRASS7 has stopped
working. Copying those dlls does not help. I tested different grass
versions, nothing works.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:18&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: reopened
  Priority: critical | Milestone: 7.0.6
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by martinl):

Replying to [comment:18 annakrat]:
> I tested on 2 machines. First one is freshly installed Windows 10 and
r.in.lidar does not even start. Here it seems some of the needed dlls are
missing. When running r.in.lidar from terminal, it says msvcp120.dll and
msvcr120.dll are missing. So I found them in some obscure system directory
and copied them to extrabin and then everything works.

standalone or osgeo4w installer. If standalone did you installed Microsoft
Runtime Libs? Ma

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:19&gt;
GRASS GIS <https://grass.osgeo.org>

#2996: Lidar modules broken in 64bit WinGRASS
-------------------------+-------------------------------------------------
  Reporter: wenzeslaus | Owner: grass-dev@…
      Type: defect | Status: reopened
  Priority: critical | Milestone: 7.0.6
Component: Packaging | Version: svn-releasebranch70
Resolution: | Keywords: lasinfo, r.in.lidar, v.in.lidar,
                         | r3.in.lidar, libLAS
       CPU: x86-64 | Platform: Unspecified
-------------------------+-------------------------------------------------

Comment (by annakrat):

Replying to [comment:19 martinl]:
> Replying to [comment:18 annakrat]:
> > I tested on 2 machines. First one is freshly installed Windows 10 and
r.in.lidar does not even start. Here it seems some of the needed dlls are
missing. When running r.in.lidar from terminal, it says msvcp120.dll and
msvcr120.dll are missing. So I found them in some obscure system directory
and copied them to extrabin and then everything works.
>
> standalone or osgeo4w installer. If standalone did you installed
Microsoft Runtime Libs? Ma

both, yes I did

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2996#comment:20&gt;
GRASS GIS <https://grass.osgeo.org>