#3000: i.gensig overwrites signature file without warning
-------------------------+-------------------------
Reporter: marisn | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.1.0
Component: Imagery | Version: svn-trunk
Keywords: i.gensig | CPU: Unspecified
Platform: Unspecified |
-------------------------+-------------------------
Although it is not a huge issue, overwriting output files without asking
for confirmation goes against the spirit of GRASS GIS.
An --overwrite flag should be implemented for i.gensig for signature file.
Replying to [ticket:3000 marisn]:
> Although it is not a huge issue, overwriting output files without asking
for confirmation goes against the spirit of GRASS GIS.
>
> An --overwrite flag should be implemented for i.gensig for signature
file.
Sorry, that change is wrong as it will check for file presence only if
OVERWRITE is set and fail to do so if it is unset (usual case). I reverted
it in r68432
I implemented a new function to find signature files in r68433 to not
change I_find_subgroup_file function within 7.x lifetime. Good question if
all hardcoded directory separators in lib/imagery should not be replaced
with HOST_DIRSEP as it is done in r68433 to match how G_file_name works.
Needs testing on Windows.
As of r68434 all (I hope) signatures generating modules perform check to
not overwrite signature file.