[GRASS-dev] [GRASS GIS] #308: Compiler error while building python swig

GDAL · September 10, 2008, 9:45pm

#308: Compiler error while building python swig
---------------------------------+------------------------------------------
Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Keywords: | Platform: Unspecified
Cpu: Unspecified |
---------------------------------+------------------------------------------
While doing a make in swig/python, I get this error:

{{{
make -C interfaces
make[1]: Entering directory
`/home/bobm/src/gis/grass6_devel/swig/python/interfaces'
echo "/* auto-generate swig typedef file (with some GRASS functions
removed) */" > gisdefs.i
cat ../../../include/gisdefs.h | grep -v
'#\|asprintf\|G_snprintf\|G_debug\|G_fatal_error\|G_warning\|G_verbose\|lzw\|G_done_msg\|G_message\|G_important_message'
>> gisdefs.i
echo "/* auto-generate swig typedef file */" > dig_structs.i
cat ../../../include/vect/dig_structs.h >> dig_structs.i
echo "/* auto-generate swig typedef file */" > vect.i
cat ../../../include/Vect.h | grep -v 'V1_\|V2_' >> vect.i
make[1]: Leaving directory
`/home/bobm/src/gis/grass6_devel/swig/python/interfaces'
/usr/bin/swig -python -shadow python_grass6.i
renames.i:2: Warning(301): class keyword used, but not in C++ mode.
interfaces/gisdefs.i:116: Error: Syntax error in input(1).
make: *** [python_grass6_wrap.c] Error 1
}}}

The syntax error in interfaces/gisdefs.i points to this line:

__attribute__ ((format(printf, 2, 3)));

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 11, 2008, 12:48am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Changes (by hamish):

* keywords: => python swig

Comment:

builds fine for me. What version of python/swig/grass?

> The syntax error in interfaces/gisdefs.i points to this line:
> {{{ __attribute__ ((format(printf, 2, 3))); }}}

for me line 116 of interfaces/gisdefs.i is like:
{{{
/* auto_mask.c */
int G__check_for_auto_masking(void);
}}}

'make clean' in the swig/python dir and try again?

?,
Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:1>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 11, 2008, 4:05am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by glynn):

Replying to [ticket:308 cgsbob]:
> While doing a make in swig/python, I get this error:

> interfaces/gisdefs.i:116: Error: Syntax error in input(1).

> The syntax error in interfaces/gisdefs.i points to this line:
>
> __attribute__ ((format(printf, 2, 3)));

Right. The Makefile generates gisdefs.i from gisdefs.h, removing the
declarations of any variadic functions using grep. One of the declarations
which it removes is G_asprintf(), which has the above __attribute__
declaration on the following line, so it gets left behind, separated from
the actual function declaration.

I'm guessing that this happened when the file was "indent"ed.

A more robust filter is:

{{{
cat ../../../include/gisdefs.h | sed -e '/\.\.\..*;/d' -e '/\.\.\./,/;/d'
>> gisdefs.i
}}}

This removes any declaration containing "..."; if the terminating
semicolon isn't on the same line, it will remove subsequent lines until it
finds the semicolon.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:2>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 11, 2008, 5:29am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by cgsbob):

I changed the Makefile with the filter you specified below. Now there are
problems with vect.i.

Replying to [comment:2 glynn]:
> Replying to [ticket:308 cgsbob]:
> > While doing a make in swig/python, I get this error:
>
> > interfaces/gisdefs.i:116: Error: Syntax error in input(1).
>
> > The syntax error in interfaces/gisdefs.i points to this line:
> >
> > __attribute__ ((format(printf, 2, 3)));
>
> Right. The Makefile generates gisdefs.i from gisdefs.h, removing the
declarations of any variadic functions using grep. One of the declarations
which it removes is G_asprintf(), which has the above __attribute__
declaration on the following line, so it gets left behind, separated from
the actual function declaration.
>
> I'm guessing that this happened when the file was "indent"ed.
>
> A more robust filter is:
>
> {{{
> cat ../../../include/gisdefs.h | sed -e '/\.\.\..*;/d' -e
'/\.\.\./,/;/d' >> gisdefs.i
> }}}
>
> This removes any declaration containing "..."; if the terminating
semicolon isn't on the same line, it will remove subsequent lines until it
finds the semicolon.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:3>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 11, 2008, 5:37am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by hamish):

thanks Glynn. a few fine tuning issues:

The new sed filter does not remove lzw and G_verbose*() functions. Also
#ifdef and #define statements are no longer removed.

I am not sure, but perhaps skipping all G_verbose*() was a bug and the
intention was only to skip G_verbose_message(,...) ??
G_vasprintf(...,va_list) now becomes available FWIW.

No idea about why lzw was left out; I suspect that #defines should be
filtered out (-e '/#/d').

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:4>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 11, 2008, 5:57am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by hamish):

Replying to [comment:3 cgsbob]:
> Now there are problems with vect.i.

perhaps something like:
cat ../../../include/Vect.h | sed -e '/V[12]_.*/,/;/d'

is better, but "/* Read/write lines */" goes away which is a bad sign. And
question re. to remove #ifndef's apply here too.

?

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:5>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 11, 2008, 8:12am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by hamish):

Hamish:
> > I suspect that #defines should be filtered out (-e '/#/d').

Glynn:
> Agreed.

It happens that filtering out /^#/ also filters out any '#include <foo.h>'
etc.
include/vect/dig_structs.h is the most diverse example of that, with
#defined constants, structs, and #ifdef HAVE_OGR etc.

also include/Vect.h #includes the dig_*.h files in include/vect/,
should those be followed? stdio.h? grass/gis.h?

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:7>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 11, 2008, 1:49pm

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by hamish):

fyi, "SWIG-1.3.12 and newer releases support variadic preprocessor
macros."

http://www.swig.org/Doc1.3/Preprocessor.html#Preprocessor_nn7

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:8>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 12, 2008, 1:53am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by glynn):

Replying to [comment:7 hamish]:

> It happens that filtering out /^#/ also filters out any '#include
<foo.h>' etc.
> include/vect/dig_structs.h is the most diverse example of that, with
#defined constants, structs, and #ifdef HAVE_OGR etc.
>
> also include/Vect.h #includes the dig_*.h files in include/vect/,
> should those be followed? stdio.h? grass/gis.h?

The existing Makefile doesn't filter out preprocessor directives from
Vect.h, only from gisdefs.h.

Replying to [comment:8 hamish]:
> fyi, "SWIG-1.3.12 and newer releases support variadic preprocessor
macros."

We don't use variadic preprocessor macros, as they aren't allowed by ANSI
C. The issue is whether the interface file should include variadic
function declarations.

It appears that the problem is with the __attribute__ declarations. If I
insert
{{{
#define __attribute__(x)
}}}
at the top of gisdefs.i, gisdefs.h can be inserted in its entirety and
nothing needs to be filtered out.

But then there's the more fundamental problem that the other
interfaces/*.i files are duplicating information from the headers, and are
somewhat out of date. And it's safe to say that anything which attempts to
duplicate information from the headers will be continually out of date.
The SWIG stuff is going to have to use the actual headers directly.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:9>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 12, 2008, 3:53am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by hamish):

we can echo {{{ #define __attribute__(x) }}} >> *.i at the top of the swig
interface file if access to those functions are desired.

Perhaps leaving out G_fatal_error() is good due to the exit(1).
A scripter can access the other G_message()s with a call to the g.message
module if they like, maybe that method could be wrapped.

My guess is that access to the core GIS engine processing functions is the
thing real value to SWIGers. Python probably has its own (possibly nicer)
versions of any G_string_manipulate() function that libgis provides.

We only have to provide interfaces to functions which would be useful. But
I don't want to limit others needlessly based on my lack of imagination
wrt what is "useful".

AFAIU #includes are ignored/not followed, so I'll filter those out to
avoid confusion, while leaving other preprocessor #ifdefs and #defines in
place.

GC:
> But then there's the more fundamental problem that the other
> interfaces/*.i files are duplicating information from the headers,
> and are somewhat out of date. And it's safe to say that anything
> which attempts to duplicate information from the headers will be
> continually out of date. The SWIG stuff is going to have to use
> the actual headers directly.

Right, AFAIK that's a known issue and not done currently simply because it
is still waiting on the TODO list and none of the devels are actively
working this part of the code.

At minimum I'll make a note of it in the Makefile.

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:10>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 12, 2008, 8:03am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by hamish):

I checked in some fixes to devbr6 SVN but it still doesn't build.

{{{
python_grass6_wrap.c: In function '_wrap_Cluster_nbands_set':
python_grass6_wrap.c:48044: error: dereferencing pointer to incomplete
type
python_grass6_wrap.c: In function '_wrap_Cluster_nbands_get':
python_grass6_wrap.c:48067: error: dereferencing pointer to incomplete
type
python_grass6_wrap.c: In function '_wrap_Cluster_npoints_set':
python_grass6_wrap.c:48097: error: dereferencing pointer to incomplete
type
python_grass6_wrap.c: In function '_wrap_Cluster_npoints_get':
...
python_grass6_wrap.c: In function '_wrap_new_Cluster':
python_grass6_wrap.c:49087: error: invalid application of 'sizeof' to
incomplete type 'struct Cluster'
...
python_grass6_wrap.c: At top level:
python_grass6_wrap.c:82965: warning: function declaration isn't a
prototype
make: *** [python_grass6_wrap.o] Error 1
}}}

----

Auto-generation of gis.i seems to be an important thing, so wrt to
tackling that next:

- gis.i seems to be based on gis.h circa 12/17/04 (r16393)

After removing comments and trailing whitespace, then diff'ing versus
gis.h r16393 the changes between gis.h and gis.i are as follows:

{{{
-extern CELL CELL_NODATA;
+/*extern CELL CELL_NODATA; Sajith */

@@ -159,10 +101,17 @@
         unsigned char red;
         unsigned char grn;
         unsigned char blu;
- } low, high;
+ } high;
+ struct
+ {
+ DCELL value;
+ unsigned char red;
+ unsigned char grn;
+ unsigned char blu;
+ } low;

- struct _Color_Rule_ *next;
- struct _Color_Rule_ *prev;
+/* struct _Color_Rule_ *next;
+ struct _Color_Rule_ *prev; Commented By sajith I am confued
here....*/
};

struct _Color_Info_
}}}

The duplication of the high,low structs was done by Sajith AFAICT.

I've no idea why of course, but that's what it is.

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:11>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 12, 2008, 8:46am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by glynn):

Replying to [comment:10 hamish]:

> Perhaps leaving out G_fatal_error() is good due to the exit(1).

SWIG needn't just be for wxGUI. It should be possible to write modules in
Python (full raster processing in Python is likely to be slow, but code
which only deals with support files isn't a problem), and those modules
may need to call G_fatal_error().

> My guess is that access to the core GIS engine processing functions is
the thing real value to SWIGers. Python probably has its own (possibly
nicer) versions of any G_string_manipulate() function that libgis
provides.

A Python function can only be "equivalent" to a libgis function if the
libgis function has clearly defined behaviour which won't change in future
versions. If there's any chance that the behaviour might change, Python
code should normally call the libgis function to ensure consistent
behaviour.

[Here, I'm talking about Python code which already needs to call GRASS
functions for other reasons. An otherwise "pure" Python script shouldn't
import GRASS' SWIG bindings for something so minor as G_message().]

> AFAIU #includes are ignored/not followed, so I'll filter those out to
avoid confusion, while leaving other preprocessor #ifdefs and #defines in
place.

If they're ignored, there's no specific need to filter them out.

> > But then there's the more fundamental problem that the other
> > interfaces/*.i files are duplicating information from the headers,
> > and are somewhat out of date. And it's safe to say that anything
> > which attempts to duplicate information from the headers will be
> > continually out of date. The SWIG stuff is going to have to use
> > the actual headers directly.
>
> Right, AFAIK that's a known issue and not done currently simply because
it is still waiting on the TODO list and none of the devels are actively
working this part of the code.

What's to do? Just remove the .i files and %include the .h files directly.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:12>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 12, 2008, 9:01am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by glynn):

Replying to [comment:11 hamish]:
> I checked in some fixes to devbr6 SVN but it still doesn't build.
>
{{{
> python_grass6_wrap.c: In function '_wrap_Cluster_nbands_set':
> python_grass6_wrap.c:48044: error: dereferencing pointer to incomplete
type
}}}

The cluster stuff was moved into a separate library (lib/cluster and
cluster.h). The imagery.i file still contains a definition for "struct
Cluster", but the C++ code is assuming that imagery.h will provide a
definition. The quick fix is to #include cluster.h.

> Auto-generation of gis.i seems to be an important thing, so wrt to
tackling that next:
>
> - gis.i seems to be based on gis.h circa 12/17/04 (r16393)
>
> After removing comments and trailing whitespace, then diff'ing versus
gis.h r16393 the changes between gis.h and gis.i are as follows:
>
{{{
> -extern CELL CELL_NODATA;
> +/*extern CELL CELL_NODATA; Sajith */
}}}

This appears to be unused.

{{{
> - struct _Color_Rule_ *next;
> - struct _Color_Rule_ *prev;
> +/* struct _Color_Rule_ *next;
> + struct _Color_Rule_ *prev; Commented By sajith I am confued
here....*/
}}}

Can SWIG not handle recursive type declarations?

> The duplication of the high,low structs was done by Sajith AFAICT.

Can SWIG not handle multiple fields with the same anonymous structure
type? If not, just add a named declaration for the structure before the
"struct _Color_Rule_" declaration.

> I've no idea why of course, but that's what it is.

First, I suggest replacing the contents of gis.i with "%include
<grass/gis.h>" and seeing if that actually causes any errors. Ditto for
all of the other interfaces/*.i files.

Essentially, SWIG aims to support the use of C/C++ header files directly.
Although there is still some "not yet supported" syntax, the amount of it
has decreased significantly since the early versions.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:13>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 14, 2008, 7:26am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by hamish):

cluster lib stuff removed from imagery.i in SVN, SWIG/Python now builds
again.

TODO/redo: further automated grass/*.h -> *.i

Glynn:
> First, I suggest replacing the contents of gis.i with "%include
<grass/gis.h>"
> and seeing if that actually causes any errors. Ditto for all of the
other
> interfaces/*.i files.

It doesn't know where to find $(MODULE_TOPDIR)/include/

{{{ interfaces/gis.i:1: Error: Unable to find 'grass/gis.h' }}}

If I get around that by hardcoding the path it shows that _Color_Rule_ is
still a problem:
{{{
struct _Color_Rule_
{
     struct
     {
         DCELL value;
         unsigned char red;
         unsigned char grn;
         unsigned char blu;
     } low, high;

struct _Color_Rule_ *next;
struct _Color_Rule_ *prev;
};
}}}

{{{
$ make
...
/usr/bin/swig -python -shadow python_grass6.i
renames.i:2: Warning(301): class keyword used, but not in C++ mode.
/usr/src/grass/svn/grass64/include/gis.h:289: Error: Syntax error in
input(3).
/usr/src/grass/svn/grass64/include/gis.h:39: Warning(451): Setting a const
char * variable may leak memory.
/usr/src/grass/svn/grass64/include/gis.h:574: Warning(451): Setting a
const char * variable may leak memory.
/usr/src/grass/svn/grass64/include/gis.h:578: Warning(451): Setting a
const char * variable may leak memory.
...
}}}

Recursive use of a struct is not the problem, it's the "low, high"
multiple defn which is creating the syntax error. If I clone that into two
separate struct defns it builds ok.

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:14>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 14, 2008, 8:55am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by glynn):

Replying to [comment:14 hamish]:

> > First, I suggest replacing the contents of gis.i with "%include
<grass/gis.h>"
> > and seeing if that actually causes any errors. Ditto for all of the
other
> > interfaces/*.i files.
>
> It doesn't know where to find $(MODULE_TOPDIR)/include/

Does this work:
{{{
      -I<dir> - Look for SWIG files in directory <dir>
}}}
Also:
{{{
      -importall - Follow all #include statements as imports
      -includeall - Follow all #include statements
}}}

> If I get around that by hardcoding the path it shows that _Color_Rule_
is still a problem:

> Recursive use of a struct is not the problem, it's the "low, high"
multiple defn which is creating the syntax error. If I clone that into two
separate struct defns it builds ok.

How about:

{{{
struct _Color_Value_
{
     DCELL value;
     unsigned char red;
     unsigned char grn;
     unsigned char blu;
};

struct _Color_Rule_
{
struct _Color_Value_ low, high;

struct _Color_Rule_ *next;
struct _Color_Rule_ *prev;
};
}}}

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:15>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 14, 2008, 11:56am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by hamish):

Adding a _Color_Value_ struct helps it get past the preprocessor stage,
but
then the compliation fails:

{{{
python_grass6_wrap.c:2945: warning: function declaration isn't a prototype
python_grass6_wrap.c: In function '_wrap__Color_Value__value_set':
python_grass6_wrap.c:5033: error: dereferencing pointer to incomplete type
python_grass6_wrap.c: In function '_wrap__Color_Value__value_get':
python_grass6_wrap.c:5056: error: dereferencing pointer to incomplete type
python_grass6_wrap.c: In function '_wrap__Color_Value__red_set':
python_grass6_wrap.c:5086: error: dereferencing pointer to incomplete type
python_grass6_wrap.c: In function '_wrap__Color_Value__red_get':
python_grass6_wrap.c:5109: error: dereferencing pointer to incomplete type
python_grass6_wrap.c: In function '_wrap__Color_Value__grn_set':
python_grass6_wrap.c:5139: error: dereferencing pointer to incomplete type
python_grass6_wrap.c: In function '_wrap__Color_Value__grn_get':
python_grass6_wrap.c:5162: error: dereferencing pointer to incomplete type
python_grass6_wrap.c: In function '_wrap__Color_Value__blu_set':
python_grass6_wrap.c:5192: error: dereferencing pointer to incomplete type
python_grass6_wrap.c: In function '_wrap__Color_Value__blu_get':
python_grass6_wrap.c:5215: error: dereferencing pointer to incomplete type
python_grass6_wrap.c: In function '_wrap_new__Color_Value_':
python_grass6_wrap.c:5228: error: invalid application of 'sizeof' to
incomplete type 'struct _Color_Value_'
python_grass6_wrap.c: In function '_wrap__Color_Rule__low_set':
python_grass6_wrap.c:5287: error: dereferencing pointer to incomplete type
python_grass6_wrap.c: In function '_wrap__Color_Rule__high_set':
python_grass6_wrap.c:5340: error: dereferencing pointer to incomplete type
python_grass6_wrap.c: In function '_wrap__Color_Info__fp_lookup_vals_set':
}}}

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:16>
GRASS GIS <http://grass.osgeo.org>

Glynn_Clements1 · September 15, 2008, 7:36am

GRASS GIS wrote:

Adding a _Color_Value_ struct helps it get past the preprocessor stage,
but
then the compliation fails:

{{{
python_grass6_wrap.c:2945: warning: function declaration isn't a prototype
python_grass6_wrap.c: In function '_wrap__Color_Value__value_set':

python_grass6_wrap.c:5228: error: invalid application of 'sizeof' to
incomplete type 'struct _Color_Value_'

At this point, it may help if you post (or attach to the ticket) your
modified version.

--
Glynn Clements <glynn@gclements.plus.com>

GDAL · September 16, 2008, 5:15am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by hamish):

Glynn wrote:
> At this point, it may help if you post (or attach to the ticket)
> your modified version.

That was with the _Color_Value_ struct as given in comment:15 to the
ticket.

I have now made an attempt at automatically expanding the struct in gis.h
to avoid the problem. Now py/swig builds without error and we are finally
using an up to date copy of gis.h.

SVN r33454 thru r33456. Improvements to the expansion method are most
welcome.

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:17>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 16, 2008, 6:16am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by hamish):

can {{{ extern CELL CELL_NODATA; }}} be removed from gis.h?
AFAICT CELL_NODATA is not used or defined anywhere in the code.

After removing CELL_NODATA python_grass6.pyc compiles ok upon running
"python test.py" but then test.py gets stuck due to the new definition of
G_gisinit():

{{{
Traceback (most recent call last):
File "test.py", line 17, in ?
g6lib.G_gisinit('')
AttributeError: 'module' object has no attribute 'G_gisinit'
}}}

Within a python shell "help(g6lib)" only shows G__gisinit() as a valid
function name. Running g6lib.G__gisinit('','') in python exits with the
mismatched version error.

How to recreate these from gis.h in a way that SWIG will like?
{{{
#define GIS_H_VERSION "$Revision: 33187 $"
#define G_gisinit(pgm) G__gisinit(GIS_H_VERSION, (pgm))
#define G_no_gisinit() G__no_gisinit(GIS_H_VERSION)
}}}

if in test.py I replace G_gisinit() with G__gisinit():
{{{
-g6lib.G_gisinit('')
+g6lib.G__gisinit(g6lib.GIS_H_VERSION, '')
}}}

Then it all works, but that's more to type.

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:18>
GRASS GIS <http://grass.osgeo.org>

GDAL · September 16, 2008, 7:39am

#308: Compiler error while building python swig
----------------------------------+-----------------------------------------
  Reporter: cgsbob | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: SWIG (all bindings) | Version: svn-develbranch6
Resolution: | Keywords: python swig
  Platform: Unspecified | Cpu: Unspecified
----------------------------------+-----------------------------------------
Comment (by glynn):

Replying to [comment:13 glynn]:

> First, I suggest replacing the contents of gis.i with "%include
<grass/gis.h>" and seeing if that actually causes any errors. Ditto for
all of the other interfaces/*.i files.

Okay; I've removed the swig/python/interfaces directory. python_grass7.i
now includes the headers directly (I've also un-nested the structure
definitions from the headers).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/308#comment:19>
GRASS GIS <http://grass.osgeo.org>