[GRASS-dev] [GRASS GIS] #3101: v.in.pdal compilation issue

GRASS GIS GRASS GIS developer
1

#3101: v.in.pdal compilation issue
-----------------------+-------------------------
Reporter: martinl | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.2.0
Component: Vector | Version: unspecified
Keywords: v.in.pdal | CPU: x86-64
Platform: Linux |
-----------------------+-------------------------
Compilation of `v.in.pdal` fails on my computer with

{{{
main.cpp:62:47: error: ‘pdal::Dimension::id::Enum’ has not been declared
                           pdal::Dimension::id::Enum dim_to_use_as_z)
                                                ^
main.cpp: In function ‘void pdal_point_to_grass(Map_info*, line_pnts*,
line_cats*, pdal::PointViewPtr, pdal::PointId, GLidarLayers*, int, int)’:
main.cpp:67:38: error: ‘Id’ is not a namespace-name
      using namespace pdal::Dimension::Id;
}}}

I have self-compiled pdal

{{{
pdal-config --version
1.2.0
}}}

{{{
g++ --version
g++ (Debian 5.4.0-6) 5.4.0 20160609
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3101&gt;
GRASS GIS <https://grass.osgeo.org>

2

#3101: v.in.pdal compilation issue
------------------------+-------------------------
  Reporter: martinl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.2.0
Component: Compiling | Version: unspecified
Resolution: | Keywords: v.in.pdal
       CPU: x86-64 | Platform: Linux
------------------------+-------------------------
Changes (by martinl):

* component: Vector => Compiling

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/3101#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

3

#3101: v.in.pdal compilation issue
------------------------+-------------------------
  Reporter: martinl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.2.0
Component: Compiling | Version: unspecified
Resolution: | Keywords: v.in.pdal
       CPU: x86-64 | Platform: Linux
------------------------+-------------------------

Comment (by wenzeslaus):

There might be more. PDAL did several releases since I wrote `v.in.pdal`
and I didn't have time to update.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3101#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

4

#3101: v.in.pdal compilation issue
------------------------+-------------------------
  Reporter: martinl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.2.2
Component: Compiling | Version: unspecified
Resolution: | Keywords: v.in.pdal
       CPU: x86-64 | Platform: Linux
------------------------+-------------------------
Changes (by ptschrum):

* cc: ptschrum (added)

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3101#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>

5

#3101: v.in.pdal compilation issue
------------------------+-------------------------
  Reporter: martinl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.2.3
Component: Compiling | Version: unspecified
Resolution: | Keywords: v.in.pdal
       CPU: x86-64 | Platform: Linux
------------------------+-------------------------

Comment (by neteler):

See r72253: v.in.pdal: change API calls to PDAL 1.6.0 (available in G7.4).

See also #3243

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3101#comment:7&gt;
GRASS GIS <https://grass.osgeo.org>

6

#3101: v.in.pdal compilation issue
------------------------+-------------------------
  Reporter: martinl | Owner: wenzeslaus
      Type: defect | Status: new
  Priority: normal | Milestone: 7.2.3
Component: Compiling | Version: unspecified
Resolution: | Keywords: v.in.pdal
       CPU: x86-64 | Platform: Linux
------------------------+-------------------------
Changes (by wenzeslaus):

* owner: grass-dev@… => wenzeslaus

Comment:

Assigning to myself for clarity, but should be fixed in r72253 from #3496
by felixg for 7.4. Do we need/want to backport?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3101#comment:8&gt;
GRASS GIS <https://grass.osgeo.org>

7

#3101: v.in.pdal compilation issue
------------------------+-------------------------
  Reporter: martinl | Owner: wenzeslaus
      Type: defect | Status: new
  Priority: normal | Milestone: 7.2.3
Component: Compiling | Version: unspecified
Resolution: | Keywords: v.in.pdal
       CPU: x86-64 | Platform: Linux
------------------------+-------------------------

Comment (by wenzeslaus):

In [changeset:"72363" 72363]:
{{{
#!CommitTicketReference repository="" revision="72363"
v.in.pdal: change API calls to PDAL 1.6.0, see #3496, #3243, #3101, #2732
(author: felixg, backport of trunk r72246) + GPL header added in r72245
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3101#comment:9&gt;
GRASS GIS <https://grass.osgeo.org>

8

#3101: v.in.pdal compilation issue
------------------------+-----------------------------
  Reporter: martinl | Owner: wenzeslaus
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.2.4
Component: Compiling | Version: unspecified
Resolution: fixed | Keywords: v.in.pdal, PDAL
       CPU: x86-64 | Platform: Linux
------------------------+-----------------------------
Changes (by wenzeslaus):

* status: new => closed
* keywords: v.in.pdal => v.in.pdal, PDAL
* resolution: => fixed

Comment:

Error related to changes in PDAL API. Fixed in r72246, backported to 7.4
in r72253. backported to 7.2 in r72363. Closing as fixed.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3101#comment:12&gt;
GRASS GIS <https://grass.osgeo.org>