[GRASS-dev] [GRASS GIS] #3151: raster digitizer crashes GUI in trunk

#3151: raster digitizer crashes GUI in trunk
-------------------------+-------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.4.0
Component: wxGUI | Version: unspecified
Keywords: | CPU: Unspecified
Platform: Unspecified |
-------------------------+-------------------------
When the raster digitizer is selected, it generates the error below and
then locks ups the GUI so that you can't even quit it without killing
Python from the OS.

error:

{{{

Traceback (most recent call last):
   File "/Users/cmbarton/Dropbox (ASU)/GRASS_dropbox/GRASS-7.
3.app/Contents/MacOS/gui/wxpython/mapdisp/toolbars.py", line
255, in OnSelectTool

self.parent.AddRDigit()
   File "/Users/cmbarton/Dropbox (ASU)/GRASS_dropbox/GRASS-7.
3.app/Contents/MacOS/gui/wxpython/mapdisp/frame.py", line
1507, in AddRDigit

toolSwitcher=self._toolSwitcher)
   File "/Users/cmbarton/Dropbox (ASU)/GRASS_dropbox/GRASS-7.
3.app/Contents/MacOS/gui/wxpython/rdigit/toolbars.py", line
56, in __init__

self._previousMap = self._mapSelectionCombo.GetValue()
   File "/Users/cmbarton/Dropbox (ASU)/GRASS_dropbox/GRASS-7.
3.app/Contents/MacOS/etc/python/wx/_controls.py", line 610,
in GetValue

return _controls_.ComboBox_GetValue(*args, **kwargs)
wx._core
.
PyAssertionError
:
C++ assertion "IsValid(n)" failed at /BUILD/wxPython-
src-2.8.12.1/src/mac/carbon/choice.cpp(242) in GetString():
wxChoice::GetString(): invalid index

}}}

I don't know if this is just a Mac issue or more general.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3151&gt;
GRASS GIS <https://grass.osgeo.org>

#3151: raster digitizer crashes GUI in trunk
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.4.0
Component: wxGUI | Version: unspecified
Resolution: | Keywords:
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------

Comment (by cmbarton):

Forgot to add: compiled from trunk a few hours ago, version: 69469

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3151#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

#3151: raster digitizer crashes GUI in trunk
--------------------------+------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.4.0
Component: wxGUI | Version: unspecified
Resolution: | Keywords: raster digitizer
       CPU: Unspecified | Platform: MacOSX
--------------------------+------------------------------
Changes (by annakrat):

* keywords: => raster digitizer
* platform: Unspecified => MacOSX

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3151#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

#3151: raster digitizer crashes GUI in trunk
--------------------------+------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.4.0
Component: wxGUI | Version: unspecified
Resolution: | Keywords: raster digitizer
       CPU: Unspecified | Platform: MacOSX
--------------------------+------------------------------

Comment (by neteler):

Can MacOSX please try the raster digitizer again?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3151#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

#3151: raster digitizer crashes GUI in trunk
--------------------------+------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.4.0
Component: wxGUI | Version: unspecified
Resolution: | Keywords: raster digitizer
       CPU: Unspecified | Platform: MacOSX
--------------------------+------------------------------

Comment (by annakrat):

Hmm, I haven't found time to fix this yet, so testing won't help I am
afraid...

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3151#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

#3151: raster digitizer crashes GUI in trunk
--------------------------+------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.4.1
Component: wxGUI | Version: unspecified
Resolution: | Keywords: raster digitizer
       CPU: Unspecified | Platform: MacOSX
--------------------------+------------------------------

Comment (by annakrat):

I didn't get this error anymore, but I had other problems with the
digitizer toolbar, which should be fixed in r72793.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3151#comment:6&gt;
GRASS GIS <https://grass.osgeo.org>

#3151: raster digitizer crashes GUI in trunk
--------------------------+------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.4.1
Component: wxGUI | Version: unspecified
Resolution: fixed | Keywords: raster digitizer
       CPU: Unspecified | Platform: MacOSX
--------------------------+------------------------------
Changes (by cmbarton):

* status: new => closed
* resolution: => fixed

Comment:

Just recompiled. This is fixed. Thanks much.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3151#comment:7&gt;
GRASS GIS <https://grass.osgeo.org>

#3151: raster digitizer crashes GUI in trunk
--------------------------+------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.4.1
Component: wxGUI | Version: unspecified
Resolution: fixed | Keywords: raster digitizer
       CPU: Unspecified | Platform: MacOSX
--------------------------+------------------------------

Comment (by annakrat):

In [changeset:"72854" 72854]:
{{{
#!CommitTicketReference repository="" revision="72854"
wxGUI/rdigit: fix raster digitizer toolbar on mac (merge from trunk, see
#3151)
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3151#comment:8&gt;
GRASS GIS <https://grass.osgeo.org>

#3151: raster digitizer crashes GUI in trunk
--------------------------+------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.4.1
Component: wxGUI | Version: unspecified
Resolution: fixed | Keywords: raster digitizer
       CPU: Unspecified | Platform: MacOSX
--------------------------+------------------------------

Comment (by annakrat):

In [changeset:"72855" 72855]:
{{{
#!CommitTicketReference repository="" revision="72855"
wxGUI: replace deprecated checkbox event method (merge from trunk, see
#3151)
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3151#comment:9&gt;
GRASS GIS <https://grass.osgeo.org>

#3151: raster digitizer crashes GUI in trunk
--------------------------+------------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.4.1
Component: wxGUI | Version: unspecified
Resolution: fixed | Keywords: raster digitizer
       CPU: Unspecified | Platform: MacOSX
--------------------------+------------------------------

Comment (by cmbarton):

Thanks. I am traveling the next couple weeks but will test these as soon
as I can.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3151#comment:10&gt;
GRASS GIS <https://grass.osgeo.org>