[GRASS-dev] [GRASS GIS] #3169: use external shapelib

GRASS GRASS developer
1

#3169: use external shapelib
-------------------------+-------------------------
Reporter: opoplawski | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.5
Component: Default | Version: 7.0.4
Keywords: | CPU: Unspecified
Platform: Unspecified |
-------------------------+-------------------------
Is there any reason at this point to not compile against an external
shapelib?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3169&gt;
GRASS GIS <https://grass.osgeo.org>

2

#3169: use external shapelib
--------------------------+-------------------------
  Reporter: opoplawski | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.5
Component: Default | Version: 7.0.4
Resolution: | Keywords:
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------

Comment (by opoplawski):

See also issue #1318

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3169#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

3

#3169: use external shapelib
--------------------------+---------------------------------
  Reporter: opoplawski | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.2.1
Component: LibVector | Version: svn-releasebranch72
Resolution: | Keywords: shapelib, OGR
       CPU: Unspecified | Platform: Unspecified
--------------------------+---------------------------------
Changes (by neteler):

* keywords: => shapelib, OGR
* version: 7.0.4 => svn-releasebranch72
* component: Default => LibVector
* milestone: 7.0.5 => 7.2.1

Comment:

Replying to [ticket:3169 opoplawski]:
> Is there any reason at this point to not compile against an external
shapelib?

AFAIR we picked shapelib many years ago from http://shapelib.maptools.org/
(points to http://download.osgeo.org/shapelib/). The last release appears
to be from 2012 since it then became part of OGR
(https://trac.osgeo.org/gdal/browser/branches/2.1/gdal/ogr/ogrsf_frmts/shape).

Here is what we changed after that (for some years we kept it in sync with
OGR, then lost track due to the needed effort). For the procedure, see
https://trac.osgeo.org/grass/browser/grass/trunk/lib/external/shapelib/README

The real question is: cannot we call the shape driver via OGR interface
and drop our own copy?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/3169#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

4

#3169: use external shapelib
--------------------------+---------------------------------
  Reporter: opoplawski | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.2.1
Component: Database | Version: svn-releasebranch72
Resolution: | Keywords: shapelib, OGR
       CPU: Unspecified | Platform: Unspecified
--------------------------+---------------------------------
Changes (by mmetz):

* component: LibVector => Database

Comment:

Replying to [comment:2 neteler]:
> Replying to [ticket:3169 opoplawski]:
> > Is there any reason at this point to not compile against an external
shapelib?
>
> AFAIR we picked shapelib many years ago from
http://shapelib.maptools.org/ (points to
http://download.osgeo.org/shapelib/). The last release appears to be from
2012 since it then became part of OGR
(https://trac.osgeo.org/gdal/browser/branches/2.1/gdal/ogr/ogrsf_frmts/shape).
>
> Here is what we changed after that (for some years we kept it in sync
with OGR, then lost track due to the needed effort). For the procedure,
see
>
https://trac.osgeo.org/grass/browser/grass/trunk/lib/external/shapelib/README
>
> The real question is: cannot we call the shape driver via OGR interface
and drop our own copy?

GRASS needs lib/external/shapelib to read and write dbf files. We can not
use the OGR interface easily without rewriting db/drivers/dbf because
shapefil.h is not installed with OGR. Also, GRASS does not need the full
shapelib, only those parts relevant for dbf RW. An external shapelib is
usually not installed because shapefiles can be accessed with the generic
OGR interface.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3169#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>