[GRASS-dev] [GRASS GIS] #3181: i.segment watershed method available but not implemented

#3181: i.segment watershed method available but not implemented
-------------------------+-------------------------
Reporter: madi | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.0.6
Component: Imagery | Version: unspecified
Keywords: i.segment | CPU: Unspecified
Platform: Unspecified |
-------------------------+-------------------------
In i.segment the default method is region growing, but there are also
other options presented to the user: mean shift and watershed. However,
the option method=watershed is not yet implemented. The user has the
possibility to choose it from the GUI, and after the module loads input
bands, which can take some time, it yields:

{{{
ERROR: Watershed is not yet implemented
}}}

This is inconvenient and I think it would be better to remove the
watershed option from the menu until it is actually implemented.

Thanks

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3181&gt;
GRASS GIS <https://grass.osgeo.org>

#3181: i.segment watershed method available but not implemented
--------------------------+-------------------------
  Reporter: madi | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.6
Component: Imagery | Version: unspecified
Resolution: | Keywords: i.segment
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------

Comment (by martinl):

In [changeset:"69692" 69692]:
{{{
#!CommitTicketReference repository="" revision="69692"
i.segment: watershed method disabled, see #3181
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3181#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

#3181: i.segment watershed method available but not implemented
--------------------------+-------------------------
  Reporter: madi | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.0.6
Component: Imagery | Version: unspecified
Resolution: | Keywords: i.segment
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------

Comment (by martinl):

In [changeset:"69693" 69693]:
{{{
#!CommitTicketReference repository="" revision="69693"
i.segment: watershed and mean shift methods disabled, see #3181
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3181#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

#3181: i.segment watershed method available but not implemented
--------------------------+-------------------------
  Reporter: madi | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.2.0
Component: Imagery | Version: unspecified
Resolution: | Keywords: i.segment
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------
Changes (by martinl):

* milestone: 7.0.6 => 7.2.0

Comment:

`i.segment` in G70 has only

{{{
       method Segmentation method
                options: region_growing
                default: region_growing
}}}

I disabled watershed method in trunk (r69692) and also mean shift in G72
(r69693). Question: should be r69255 backported to relbr72 before
7.2.0RC1?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3181#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

#3181: i.segment watershed method available but not implemented
--------------------------+-------------------------
  Reporter: madi | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.2.0
Component: Imagery | Version: unspecified
Resolution: | Keywords: i.segment
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------

Comment (by mlennert):

Replying to [comment:3 martinl]:
> `i.segment` in G70 has only
>
> {{{
> method Segmentation method
> options: region_growing
> default: region_growing
> }}}
>
> I disabled watershed method in trunk (r69692) and also mean shift in G72
(r69693). Question: should be r69255 backported to relbr72 before
7.2.0RC1?

-1

AFAIR, MarkusM and I decided deliberately to not backport to the release
branch. The inclusion of mean shift and watershed into core i.segment in
7.2 happened "by accident" as it was done just 3 days before MarkusN
created the 72 release branch, just when MarkusM was refactoring the code
to prepare the GSoC project. See mainly r68468. This latter change can
stay in 7.2 IMHO, but we shouldn't backport the rest as this stage. I will
be for 7.4.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3181#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

#3181: i.segment watershed method available but not implemented
--------------------------+-------------------------
  Reporter: madi | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.2.0
Component: Imagery | Version: unspecified
Resolution: fixed | Keywords: i.segment
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------
Changes (by martinl):

* status: new => closed
* resolution: => fixed

Comment:

Replying to [comment:4 mlennert]:
> AFAIR, MarkusM and I decided deliberately to not backport to the release
branch. The inclusion of mean shift and watershed into core i.segment in
7.2 happened "by accident" as it was done just 3 days before MarkusN
created the 72 release branch, just when MarkusM was refactoring the code
to prepare the GSoC project. See mainly r68468. This latter change can
stay in 7.2 IMHO, but we shouldn't backport the rest as this stage. I will
be for 7.4.

OK, thanks for explanation. I my eyes, we can close this ticket. Feel free
to reopen if needed.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3181#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>