[GRASS-dev] [GRASS GIS] #3201: wxGUI nviz: resolution settings widget broken in wxPython 3

GDAL · November 5, 2016, 2:42pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
----------------------+---------------------------------
Reporter: neteler | Owner: grass-dev@…
Type: defect | Status: new
Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Keywords: nviz | CPU: Unspecified
Platform: Linux |
----------------------+---------------------------------
At time it is not possible to adjust drawing options at all... This
renders nviz rather unusable.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 5, 2016, 5:15pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------
Changes (by neteler):

* Attachment "wxgui_nviz_wxpython3_0_2.png" added.

wxpython 3 generated resolution widget

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 5, 2016, 5:21pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------

Comment (by neteler):

I restarted the session to switch from my own to the NC data set and the
widget was no longer greyed out (screenshot). This time not broken but yet
not correctly rendered.. and in the terminal I get tons of

{{{
...
(wxgui.py:22073): Gtk-CRITICAL **: gtk_box_gadget_distribute: assertion
'size >= 0' failed in GtkSpinButton

(wxgui.py:22073): Gtk-CRITICAL **: gtk_box_gadget_distribute: assertion
'size >= 0' failed in GtkSpinButton

(wxgui.py:22073): Gtk-WARNING **: Negative content width -17 (allocation
1, extents 9x9) while allocating gadget (node entry, owner GtkEntry)

(wxgui.py:22073): Gtk-CRITICAL **: gtk_box_gadget_distribute: assertion
'size >= 0' failed in GtkSpinButton

(wxgui.py:22073): Gtk-CRITICAL **: gtk_box_gadget_distribute: assertion
'size >= 0' failed in GtkSpinButton
...
}}}

Perhaps the GtkSpinButton() definition changed somehow in wxPython3?

Maybe the same as here?
https://bugzilla.redhat.com/show_bug.cgi?id=1371036

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:1>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 5, 2016, 5:54pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------

Comment (by annakrat):

It looks normal on Ubuntu. Let's see if they reply, it looks like the same
problem. You can also try the wxpython demo, I don't understand if all
wx.SpinCtrls are messed up or if it depends somehow on the surrounding
widgets. Does this happen in trunk, too?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:2>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 6, 2016, 11:46am

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------

Comment (by neteler):

Here the patch of the other project for inspection:

http://pkgs.fedoraproject.org/cgit/rpms/printrun.git/tree/printrun-
gtk3.patch

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:3>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 6, 2016, 1:22pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------
Changes (by annakrat):

* Attachment "spinctrl.diff" added.

Increase SpinCtrl size

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 6, 2016, 1:24pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------

Comment (by annakrat):

Could you try the attached diff? It just increases the size of SpinCtrl,
since that what they had in that patch.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:4>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 6, 2016, 7:28pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------
Changes (by neteler):

* Attachment "wxgui_nviz_wxpython3_0_2_patched.png" added.

wxGUI-nviz after patch

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 6, 2016, 7:33pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------

Comment (by neteler):

The patch helps for Fine mode/coarse mode, thanks. So it seems to be the
way to go.

Out of size are still
  * Under Surface: Transparency + Shininess
  * Under "Constant surface", all three SpinCtrls
  * Under "Vector" Line width + Icon size
  * Under isosurface attributes: Transparency + Shininess
  * Under Fringe: Elevation from bottom
  * Under Animation: Frame rate

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:5>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 6, 2016, 11:13pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------

Comment (by annakrat):

Replying to [comment:5 neteler]:
> The patch helps for Fine mode/coarse mode, thanks. So it seems to be the
way to go.
>
> Out of size are still
> * Under Surface: Transparency + Shininess
> * Under "Constant surface", all three SpinCtrls
> * Under "Vector" Line width + Icon size
> * Under isosurface attributes: Transparency + Shininess
> * Under Fringe: Elevation from bottom
> * Under Animation: Frame rate
>

and probably more. This issue applies to almost all SpinCtrls in different
parts of GUI (dialogs, attribute table manager, ...), right? So all these
have to be changed. Could you find the minimum size which works for your
platform? The problem is, it's way to big for all other platforms, so
ideally this would be applied only to your platform, but I need to
recognize it in the code somehow.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:6>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 7, 2016, 2:53pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------

Comment (by neteler):

Below the update from the Fedora packager of wxPython3:

On 11/07/2016 03:00 PM, bugzilla @ redhat.com wrote: Comment 9 from Scott
Talbert

https://bugzilla.redhat.com/show_bug.cgi?id=1371036

> markusN wrote:
>> It seems that the solution for GRASS GIS would be the same, to make the
>> SpinButtons bigger:
>> https://trac.osgeo.org/grass/attachment/ticket/3201/spinctrl.diff
>>
>> The issue is: if all projects using SpinCtrl have to change their
button
>> sizes, wouldn't it be better to fix Fedora's wxPython3 package? Our
>> developers on Ubuntu do not have such issues.

The !SpinButton sizing thing cannot be fixed in wxPython - it has to be
fixed in
individual applications. This is really a problem because the underlying
GTK
!SpinButton widget is much wider in GTK+3 than it is in GTK+2.

Compare these two and you will see the problem:
* https://developer.gnome.org/gtk2/stable/GtkSpinButton.html
* https://developer.gnome.org/gtk3/stable/GtkSpinButton.html

The reason you do not see it under Ubuntu is that Ubuntu's wxPython
package
still uses GTK+2.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:7>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 8, 2016, 3:48am

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------
Changes (by annakrat):

* Attachment "gtk3.diff" removed.

fix SpinCtrl for gtk3

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 8, 2016, 3:48am

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------
Changes (by annakrat):

* Attachment "gtk3.diff" added.

fix SpinCtrl for gtk3

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 8, 2016, 3:49am

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------

Comment (by annakrat):

Please try the attachment if it does anything for you.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:8>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 8, 2016, 7:24am

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------

Comment (by neteler):

Replying to [comment:8 annakrat]:
> Please try the attachment if it does anything for you.

Yes, Anna, this is just great, the !SpinButtons are usable again with the
patch.

I'd suggest to backport it right away after having updated trunk. Thanks!

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:9>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 8, 2016, 6:37pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------

Comment (by annakrat):

In [changeset:"69790" 69790]:
{{{
#!CommitTicketReference repository="" revision="69790"
wxGUI: change size of wx.SpinCtrl for gtk3, see #3201
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:10>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 8, 2016, 6:48pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------

Comment (by annakrat):

In [changeset:"69791" 69791]:
{{{
#!CommitTicketReference repository="" revision="69791"
wxGUI: change size of wx.SpinCtrl for gtk3, see #3201 (merge from trunk,
r69790)
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:11>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 8, 2016, 6:59pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------

Comment (by annakrat):

I suggest to test more before closing.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:12>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 13, 2016, 10:20pm

#3201: wxGUI nviz: resolution settings widget broken in wxPython 3
--------------------------+---------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: critical | Milestone: 7.2.0
Component: wxGUI | Version: svn-releasebranch72
Resolution: fixed | Keywords: nviz
       CPU: Unspecified | Platform: Linux
--------------------------+---------------------------------
Changes (by annakrat):

* status: new => closed
* resolution: => fixed

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3201#comment:13>
GRASS GIS <https://grass.osgeo.org>