[GRASS-dev] [GRASS GIS] #3477: i.ortho.photo segmentation fault

#3477: i.ortho.photo segmentation fault
---------------------------+---------------------------------
Reporter: lucadelu | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 7.4.0
Component: Imagery | Version: svn-releasebranch74
Keywords: i.ortho.photo | CPU: Unspecified
Platform: All |
---------------------------+---------------------------------
If I try to launch i.ortho.photo command I get segmentation fault error.

It seems that tosystem() is not working properly.

{{{
i.ortho.photo group=lsat7_2000 prod=i.group
Segmentation fault
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3477&gt;
GRASS GIS <https://grass.osgeo.org>

#3477: i.ortho.photo segmentation fault
--------------------------+---------------------------------
  Reporter: lucadelu | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: major | Milestone: 7.4.0
Component: Imagery | Version: svn-releasebranch74
Resolution: | Keywords: i.ortho.photo
       CPU: Unspecified | Platform: All
--------------------------+---------------------------------

Comment (by ychemin):

Yes confirmed that tosystem() fails to provide its claimed services.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3477#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

#3477: i.ortho.photo segmentation fault
--------------------------+---------------------------------
  Reporter: lucadelu | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: major | Milestone: 7.4.0
Component: Imagery | Version: svn-releasebranch74
Resolution: | Keywords: i.ortho.photo
       CPU: Unspecified | Platform: All
--------------------------+---------------------------------

Comment (by neteler):

Just guessing, maybe the buffer is too small and needs to be larger?

{{{
--- menu.c (revision 72067)
+++ menu.c (working copy)
@@ -35,7 +35,7 @@
      char *desc_ortho_opt;
      char *moduletorun;
      const char *grname;
- char tosystem[99];
+ char tosystem[1024];
      const char *to_system;
      int err=0;

}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3477#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

#3477: i.ortho.photo segmentation fault
--------------------------+---------------------------------
  Reporter: lucadelu | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: major | Milestone: 7.4.0
Component: Imagery | Version: svn-releasebranch74
Resolution: | Keywords: i.ortho.photo
       CPU: Unspecified | Platform: All
--------------------------+---------------------------------

Comment (by lucadelu):

Replying to [comment:2 neteler]:
> Just guessing, maybe the buffer is too small and needs to be larger?
>
> {{{
> --- menu.c (revision 72067)
> +++ menu.c (working copy)
> @@ -35,7 +35,7 @@
> char *desc_ortho_opt;
> char *moduletorun;
> const char *grname;
> - char tosystem[99];
> + char tosystem[1024];
> const char *to_system;
> int err=0;
>
> }}}

Did you try it?

For me still "Segmentation fault"

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3477#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

#3477: i.ortho.photo segmentation fault
--------------------------+---------------------------------
  Reporter: lucadelu | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: major | Milestone: 7.4.0
Component: Imagery | Version: svn-releasebranch74
Resolution: fixed | Keywords: i.ortho.photo
       CPU: Unspecified | Platform: All
--------------------------+---------------------------------
Changes (by ychemin):

* status: new => closed
* resolution: => fixed

Comment:

rev 72075, should be fixed.
The check for group validity was not needed.
Please check and confirm

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3477#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

#3477: i.ortho.photo segmentation fault
--------------------------+---------------------------------
  Reporter: lucadelu | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: major | Milestone: 7.4.0
Component: Imagery | Version: svn-releasebranch74
Resolution: fixed | Keywords: i.ortho.photo
       CPU: Unspecified | Platform: All
--------------------------+---------------------------------

Comment (by lucadelu):

Confirmed, you can backport to 7.4 branch.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3477#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>

#3477: i.ortho.photo segmentation fault
--------------------------+---------------------------------
  Reporter: lucadelu | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: major | Milestone: 7.4.0
Component: Imagery | Version: svn-releasebranch74
Resolution: fixed | Keywords: i.ortho.photo
       CPU: Unspecified | Platform: All
--------------------------+---------------------------------

Comment (by neteler):

In [changeset:"72080" 72080]:
{{{
#!CommitTicketReference repository="" revision="72080"
i.ortho.photo: fix segfault (trunk, r72075); fixes #3477
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3477#comment:6&gt;
GRASS GIS <https://grass.osgeo.org>

#3477: i.ortho.photo segmentation fault
--------------------------+---------------------------------
  Reporter: lucadelu | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: major | Milestone: 7.4.0
Component: Imagery | Version: svn-releasebranch74
Resolution: fixed | Keywords: i.ortho.photo
       CPU: Unspecified | Platform: All
--------------------------+---------------------------------

Comment (by lucadelu):

Can I backport also this r72066?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3477#comment:7&gt;
GRASS GIS <https://grass.osgeo.org>

#3477: i.ortho.photo segmentation fault
--------------------------+---------------------------------
  Reporter: lucadelu | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: major | Milestone: 7.4.0
Component: Imagery | Version: svn-releasebranch74
Resolution: fixed | Keywords: i.ortho.photo
       CPU: Unspecified | Platform: All
--------------------------+---------------------------------

Comment (by neteler):

Replying to [comment:7 lucadelu]:
> Can I backport also this r72066?

Done in r72094

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3477#comment:8&gt;
GRASS GIS <https://grass.osgeo.org>