[GRASS-dev] [GRASS GIS] #3496: v.in.pdal: does not compile with PDAL 1.6.0

GDAL · February 15, 2018, 2:49pm

#3496: v.in.pdal: does not compile with PDAL 1.6.0
------------------------------------+-------------------------
Reporter: felixg | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone:
Component: Vector | Version: unspecified
Keywords: v.in.pdal, PDAL, lidar | CPU: Unspecified
Platform: Unspecified |
------------------------------------+-------------------------
As the PDAL API changed in a few places, the code of v.in.pdal fails to
compile and needs to be adjusted.

The attached patch file changes the following in `main.cpp` of v.in.pdal:
- the includes as PDAL relocated some header files
- use of the enum pdal::Dimension::Id
- a method call to pdal::SpatialReference::getWKT(), it does not have any
formal parameters anymore in PDAL

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3496>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 15, 2018, 2:51pm

#3496: v.in.pdal: does not compile with PDAL 1.6.0
--------------------------+------------------------------------
  Reporter: felixg | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone:
Component: Vector | Version: unspecified
Resolution: | Keywords: v.in.pdal, PDAL, lidar
       CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------
Changes (by felixg):

* Attachment "fix-for-pdal-vector-import.patch" added.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3496>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 16, 2018, 3:11am

#3496: v.in.pdal: does not compile with PDAL 1.6.0
--------------------------+------------------------------------
  Reporter: felixg | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone:
Component: Vector | Version: unspecified
Resolution: | Keywords: v.in.pdal, PDAL, lidar
       CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------

Comment (by wenzeslaus):

In [changeset:"72246" 72246]:
{{{
#!CommitTicketReference repository="" revision="72246"
v.in.pdal: change API calls to PDAL 1.6.0, see #3496 and #2732 (author:
felixg)
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3496#comment:1>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 16, 2018, 3:20am

#3496: v.in.pdal: does not compile with PDAL 1.6.0
--------------------------+------------------------------------
  Reporter: felixg | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone:
Component: Vector | Version: unspecified
Resolution: | Keywords: v.in.pdal, PDAL, lidar
       CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------

Comment (by wenzeslaus):

Thank you. I committed the change in r72246. Tested with 1.5.0 and 1.6.0
(compiled) and trunk using the two tests in testsuite directory:

{{{
export LD_LIBRARY_PATH="/home/.../install/lib:$LD_LIBRARY_PATH"
cd vector/v.in.pdal/testsuite
../../../bin.x86_64-pc-linux-gnu/grass75
~/grassdata/nc_basic_spm_grass7/user1/ \
--exec python basic_test.py
../../../bin.x86_64-pc-linux-gnu/grass75
~/grassdata/nc_basic_spm_grass7/user1/ \
--exec python filter_test.py
}}}

This can be closed after backport to 7.4 (and maybe 7.2).

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3496#comment:2>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 18, 2018, 11:09am

#3496: v.in.pdal: does not compile with PDAL 1.6.0
--------------------------+------------------------------------
  Reporter: felixg | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone:
Component: Vector | Version: unspecified
Resolution: | Keywords: v.in.pdal, PDAL, lidar
       CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------

Comment (by neteler):

In [changeset:"72253" 72253]:
{{{
#!CommitTicketReference repository="" revision="72253"
v.in.pdal: change API calls to PDAL 1.6.0, see #3496 and #2732 (author:
felixg, trunk r72246) + GPL header added in r72245
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3496#comment:3>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 18, 2018, 11:12am

#3496: v.in.pdal: does not compile with PDAL 1.6.0
--------------------------+------------------------------------
  Reporter: felixg | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.4.1
Component: Vector | Version: svn-releasebranch74
Resolution: | Keywords: v.in.pdal, PDAL, lidar
       CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------
Changes (by neteler):

* version: unspecified => svn-releasebranch74
* milestone: => 7.4.1

Comment:

Replying to [comment:2 wenzeslaus]:
...
> This can be closed after backport to 7.4 (and maybe 7.2).

Backported to 7.4 in r72253, closing.

@felixg: thanks for the patch!

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3496#comment:4>
GRASS GIS <https://grass.osgeo.org>

GDAL · February 18, 2018, 11:12am

#3496: v.in.pdal: does not compile with PDAL 1.6.0
--------------------------+------------------------------------
  Reporter: felixg | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.4.1
Component: Vector | Version: svn-releasebranch74
Resolution: fixed | Keywords: v.in.pdal, PDAL, lidar
       CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------
Changes (by neteler):

* status: new => closed
* resolution: => fixed

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3496#comment:5>
GRASS GIS <https://grass.osgeo.org>

GDAL · March 13, 2018, 1:55pm

#3496: v.in.pdal: does not compile with PDAL 1.6.0
--------------------------+------------------------------------
  Reporter: felixg | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.4.1
Component: Vector | Version: svn-releasebranch74
Resolution: fixed | Keywords: v.in.pdal, PDAL, lidar
       CPU: Unspecified | Platform: Unspecified
--------------------------+------------------------------------

Comment (by wenzeslaus):

In [changeset:"72363" 72363]:
{{{
#!CommitTicketReference repository="" revision="72363"
v.in.pdal: change API calls to PDAL 1.6.0, see #3496, #3243, #3101, #2732
(author: felixg, backport of trunk r72246) + GPL header added in r72245
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3496#comment:6>
GRASS GIS <https://grass.osgeo.org>