[GRASS-dev] [GRASS GIS] #3499: Backport of new ZSTD compression

#3499: Backport of new ZSTD compression
------------------------------+-------------------------
Reporter: neteler | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.4.1
Component: LibRaster | Version: unspecified
Keywords: ZSTD compression | CPU: All
Platform: All |
------------------------------+-------------------------
Carried over from #2750

Replying to [#2750 comment:69 neteler]:
> Concerning ZSTD compression: backport candidate for 7.4.1.

... for this I identified
  * r71892 update documentation for GRASS compression methods
  * r71891 libraster: update for ZSTD, use new G_compress_bound()
  * r71890 libgis: add ZSTD (Zstandard) compression
  * r71889 add ZSTD (Zstandard) compression to the Make system

Probably also helpful:
  * r72031 libgis: more informative messages when (de)compression fails
  * r72042 libgis: add warnings when writing compressed data fails

Is anything missing from this list?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3499&gt;
GRASS GIS <https://grass.osgeo.org>

#3499: Backport of new ZSTD compression
--------------------------+------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.4.1
Component: LibRaster | Version: unspecified
Resolution: | Keywords: ZSTD compression
       CPU: All | Platform: All
--------------------------+------------------------------

Comment (by mmetz):

Replying to [ticket:3499 neteler]:
> Carried over from #2750
>
> Replying to [#2750 comment:69 neteler]:
> > Concerning ZSTD compression: backport candidate for 7.4.1.

IMHO ZSTD compression is not a backport candidate because it is a new
feature. Moreover, substantial changes were introduced to both the gis and
raster library, which are in no way a bugfix, disqualifying it for
backporting.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3499#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

#3499: Backport of new ZSTD compression
--------------------------+------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.4.1
Component: LibRaster | Version: unspecified
Resolution: | Keywords: ZSTD compression
       CPU: All | Platform: All
--------------------------+------------------------------
Description changed by neteler:

Old description:

Carried over from #2750

Replying to [#2750 comment:69 neteler]:
> Concerning ZSTD compression: backport candidate for 7.4.1.

... for this I identified
* r71892 update documentation for GRASS compression methods
* r71891 libraster: update for ZSTD, use new G_compress_bound()
* r71890 libgis: add ZSTD (Zstandard) compression
* r71889 add ZSTD (Zstandard) compression to the Make system

Probably also helpful:
* r72031 libgis: more informative messages when (de)compression fails
* r72042 libgis: add warnings when writing compressed data fails

Is anything missing from this list?

New description:

Carried over from #2750

Replying to [#2750 comment:69 neteler]:
> Concerning ZSTD compression: backport candidate for 7.4.1.

... for this I identified
  * r71892 update documentation for GRASS compression methods
  * r71891 libraster: update for ZSTD, use new G_compress_bound()
  * r71890 libgis: add ZSTD (Zstandard) compression
  * r71889 add ZSTD (Zstandard) compression to the Make system

Probably also helpful:
  * r72030 libraster: more informative messages when reading a row fails
  * r72031 libgis: more informative messages when (de)compression fails
  * r72042 libgis: add warnings when writing compressed data fails

Is anything missing from this list?

--

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3499#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

#3499: Backport of new ZSTD compression
--------------------------+------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.4.1
Component: LibRaster | Version: unspecified
Resolution: | Keywords: ZSTD compression
       CPU: All | Platform: All
--------------------------+------------------------------

Comment (by mmetz):

Replying to [comment:1 mmetz]:
> Replying to [ticket:3499 neteler]:
> > Carried over from #2750
> >
> > Replying to [#2750 comment:69 neteler]:
> > > Concerning ZSTD compression: backport candidate for 7.4.1.
>
> IMHO ZSTD compression is not a backport candidate because it is a new
feature. Moreover, substantial changes were introduced to both the gis and
raster library, which are in no way a bugfix, disqualifying it for
backporting.

Emphasizing the backporting issue: backporting (in this case) is not
trivial because it involves several low-level changes. If you want to use
ZSTD compression, use trunk r71892. If you want more meaningful messages
about why (de-)compression fails, use trunk r72042.

Equivalent for any other new features in trunk: use trunk with the
revision when this new feature was added.

Feedback to new features helps to keep trunk robust (suitable for everyday
work).

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3499#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

#3499: Backport of new ZSTD compression
--------------------------+------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.4.1
Component: LibRaster | Version: unspecified
Resolution: | Keywords: ZSTD compression
       CPU: All | Platform: All
--------------------------+------------------------------

Comment (by Nikos Alexandris):

Avoiding to open a new ticket, the
https://grass.osgeo.org/grass75/manuals/variables.html#list-of-selected
-(grass-related)-shell-environment-variables deserves an update. It does
not mention anything about ZSTD.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3499#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

#3499: Backport of new ZSTD compression
--------------------------+------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.4.1
Component: LibRaster | Version: unspecified
Resolution: | Keywords: ZSTD compression
       CPU: All | Platform: All
--------------------------+------------------------------

Comment (by mmetz):

Replying to [comment:4 Nikos Alexandris]:
> Avoiding to open a new ticket, the
https://grass.osgeo.org/grass75/manuals/variables.html#list-of-selected
-(grass-related)-shell-environment-variables deserves an update. It does
not mention anything about ZSTD.

Thanks for the hint, done in trunk r72784. ZSTD is already mentioned in
the G7:rasterintro and in the manual of G7:r.compress.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3499#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>

#3499: Backport of new ZSTD compression
--------------------------+------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 7.4.2
Component: LibRaster | Version: unspecified
Resolution: wontfix | Keywords: ZSTD compression
       CPU: All | Platform: All
--------------------------+------------------------------
Changes (by neteler):

* status: new => closed
* resolution: => wontfix

Comment:

Since G7.6.0 is meanwhile slowly on the way (relbranch76 is available)
closing as wontfix.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3499#comment:7&gt;
GRASS GIS <https://grass.osgeo.org>