[GRASS-dev] [GRASS GIS] #3511: [patch] v.buffer: allow squared buffers around points

#3511: [patch] v.buffer: allow squared buffers around points
-------------------------------------+-------------------------
Reporter: mlennert | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.4.1
Component: Vector | Version: svn-trunk
Keywords: v.buffer squared buffer | CPU: Unspecified
Platform: Unspecified |
-------------------------------------+-------------------------
The attached patch implements squared buffers around points.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3511&gt;
GRASS GIS <https://grass.osgeo.org>

#3511: [patch] v.buffer: allow squared buffers around points
--------------------------+-------------------------------------
  Reporter: mlennert | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.4.1
Component: Vector | Version: svn-trunk
Resolution: | Keywords: v.buffer squared buffer
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------------------
Changes (by mlennert):

* Attachment "squared_buffer_around_points.diff" added.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3511&gt;
GRASS GIS <https://grass.osgeo.org>

#3511: [patch] v.buffer: allow squared buffers around points
--------------------------+-------------------------------------
  Reporter: mlennert | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.4.1
Component: Vector | Version: svn-trunk
Resolution: | Keywords: v.buffer squared buffer
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------------------

Comment (by mlennert):

Replying to [ticket:3511 mlennert]:
> The attached patch implements squared buffers around points.

Forgot to explain: with the patch, v.buffer should create square buffers
around points if the -s flag is set.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3511#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

#3511: [patch] v.buffer: allow squared buffers around points
--------------------------+-------------------------------------
  Reporter: mlennert | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.4.1
Component: Vector | Version: svn-trunk
Resolution: | Keywords: v.buffer squared buffer
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------------------

Comment (by mmetz):

Replying to [comment:1 mlennert]:
> Replying to [ticket:3511 mlennert]:
> > The attached patch implements squared buffers around points.
>
> Forgot to explain: with the patch, v.buffer should create square buffers
around points if the -s flag is set.

Currently v.buffer always uses Vect_point_buffer2() for points, but the
Vect_*_buffer*() functions might disappear at some stage because they are
not working properly (apart from point buffering). Therefore it might be
safer to add this functionality to v.buffer directly.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3511#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

#3511: [patch] v.buffer: allow squared buffers around points
--------------------------+-------------------------------------
  Reporter: mlennert | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.4.1
Component: Vector | Version: svn-trunk
Resolution: | Keywords: v.buffer squared buffer
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------------------
Changes (by mlennert):

* Attachment "squared_buffer_around_points_directly_in_vbuffer.diff"
added.

second version of a patch, this time directly in main.c of v.buffer

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3511&gt;
GRASS GIS <https://grass.osgeo.org>

#3511: [patch] v.buffer: allow squared buffers around points
--------------------------+-------------------------------------
  Reporter: mlennert | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.4.1
Component: Vector | Version: svn-trunk
Resolution: | Keywords: v.buffer squared buffer
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------------------

Comment (by mlennert):

Replying to [comment:2 mmetz]:
> Replying to [comment:1 mlennert]:
> > Replying to [ticket:3511 mlennert]:
> > > The attached patch implements squared buffers around points.
> >
> > Forgot to explain: with the patch, v.buffer should create square
buffers around points if the -s flag is set.
>
> Currently v.buffer always uses Vect_point_buffer2() for points, but the
Vect_*_buffer*() functions might disappear at some stage because they are
not working properly (apart from point buffering). Therefore it might be
safer to add this functionality to v.buffer directly.

Please check the attached new patch.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3511#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

#3511: [patch] v.buffer: allow squared buffers around points
--------------------------+-------------------------------------
  Reporter: mlennert | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.4.1
Component: Vector | Version: svn-trunk
Resolution: | Keywords: v.buffer squared buffer
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------------------

Comment (by mmetz):

Replying to [comment:3 mlennert]:
> Replying to [comment:2 mmetz]:
> > Replying to [comment:1 mlennert]:
> > > Replying to [ticket:3511 mlennert]:
> > > > The attached patch implements squared buffers around points.
> > >
> > > Forgot to explain: with the patch, v.buffer should create square
buffers around points if the -s flag is set.
> >
> > Currently v.buffer always uses Vect_point_buffer2() for points, but
the Vect_*_buffer*() functions might disappear at some stage because they
are not working properly (apart from point buffering). Therefore it might
be safer to add this functionality to v.buffer directly.
>
> Please check the attached new patch.

The patch looks and works fine, please commit.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3511#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

#3511: [patch] v.buffer: allow squared buffers around points
--------------------------+-------------------------------------
  Reporter: mlennert | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.4.1
Component: Vector | Version: svn-trunk
Resolution: | Keywords: v.buffer squared buffer
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------------------

Comment (by mlennert):

Replying to [comment:4 mmetz]:
> Replying to [comment:3 mlennert]:
> > Replying to [comment:2 mmetz]:
> > > Replying to [comment:1 mlennert]:
> > > > Replying to [ticket:3511 mlennert]:
> > > > > The attached patch implements squared buffers around points.
> > > >
> > > > Forgot to explain: with the patch, v.buffer should create square
buffers around points if the -s flag is set.
> > >
> > > Currently v.buffer always uses Vect_point_buffer2() for points, but
the Vect_*_buffer*() functions might disappear at some stage because they
are not working properly (apart from point buffering). Therefore it might
be safer to add this functionality to v.buffer directly.
> >
> > Please check the attached new patch.
>
> The patch looks and works fine, please commit.

Done in r72353.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3511#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>

#3511: [patch] v.buffer: allow squared buffers around points
--------------------------+-------------------------------------
  Reporter: mlennert | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 7.4.1
Component: Vector | Version: svn-trunk
Resolution: fixed | Keywords: v.buffer squared buffer
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------------------
Changes (by mlennert):

* status: new => closed
* resolution: => fixed

Comment:

Closing this ticket as fixed.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3511#comment:6&gt;
GRASS GIS <https://grass.osgeo.org>