[GRASS-dev] [GRASS GIS] #3525: Removing the behavior of i.maxlik which add the output to input group

GDAL · March 20, 2018, 3:51pm

#3525: Removing the behavior of i.maxlik which add the output to input group
-------------------------+-------------------------
Reporter: spareeth | Owner: grass-dev@…
Type: enhancement | Status: new
Priority: normal | Milestone: 8.0.0
Component: Default | Version: svn-trunk
Keywords: | CPU: Unspecified
Platform: All |
-------------------------+-------------------------
The final result from i.maxlik is added to input group by default. which
in my opinion is strange. I dont know if there is any reason behind this
behaviour.

In the mapset nc_spm_08_grass7/landsat;

{{{
i.group group=lsat7_2000_NW subgroup=lsat7_2000_NW
input=lsat7_2000_10,lsat7_2000_20,lsat7_2000_30,lsat7_2000_40,lsat7_2000_50
i.cluster group=lsat7_2000_NW subgroup=lsat7_2000_NW
signaturefile=sig_cluster_lsat2000 classes=10
reportfile=rep_clust_lsat2000.txt
i.maxlik group=lsat7_2000_NW subgroup=lsat7_2000_NW
signaturefile=sig_cluster_lsat2000 output=lsat7_2000_cluster_10classes
reject=lsat7_2002_cluster_reject
i.group lsat7_2000_NW -l
group <lsat7_2000_NW> references the following raster maps
-------------
<lsat7_2000_10@landsat>
<lsat7_2000_20@landsat>
<lsat7_2000_30@landsat>
<lsat7_2000_40@landsat>
<lsat7_2000_50@landsat>
<lsat7_2000_cluster_10classes@landsat>
<lsat7_2002_cluster_reject@landsat>
}}}

Would be better to remove this behaviour in future release.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3525>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 1, 2018, 12:44pm

#3525: Removing the behavior of i.maxlik which add the output to input group
--------------------------+-------------------------
  Reporter: spareeth | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 8.0.0
Component: Default | Version: svn-trunk
Resolution: | Keywords:
       CPU: Unspecified | Platform: All
--------------------------+-------------------------

Comment (by veroandreo):

+1!

It's a quite annoying to have to remove the classification and reject maps
from the group in each new run, better leave optional to the user to add
it if he/she wants it as an additional input layer.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3525#comment:1>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 1, 2018, 12:48pm

#3525: Removing the behavior of i.maxlik which add the output to input group
--------------------------+-------------------------
  Reporter: spareeth | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 8.0.0
Component: Default | Version: svn-trunk
Resolution: | Keywords:
       CPU: Unspecified | Platform: All
--------------------------+-------------------------

Comment (by martinl):

+0 Key point is that output maps are not added to subgroup (which is used
by most of imagery modules for reading list of input maps).

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3525#comment:2>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 1, 2018, 12:48pm

#3525: Removing the behavior of i.maxlik which add the output to input group
--------------------------+-------------------------
  Reporter: spareeth | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 8.0.0
Component: Default | Version: svn-trunk
Resolution: | Keywords:
       CPU: Unspecified | Platform: All
--------------------------+-------------------------

Comment (by martinl):

So you don't need to remove output maps from group in each new run...

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3525#comment:3>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 1, 2018, 12:49pm

#3525: Removing the behavior of i.maxlik which add the output to input group
--------------------------+-------------------------
  Reporter: spareeth | Owner: grass-dev@…
      Type: task | Status: new
  Priority: normal | Milestone: 8.0.0
Component: Imagery | Version: svn-trunk
Resolution: | Keywords: i.maxlik
       CPU: Unspecified | Platform: All
--------------------------+-------------------------
Changes (by martinl):

* keywords: => i.maxlik
* type: enhancement => task
* component: Default => Imagery

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3525#comment:4>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 1, 2018, 1:32pm

#3525: Removing the behavior of i.maxlik which add the output to input group
--------------------------+-------------------------
  Reporter: spareeth | Owner: grass-dev@…
      Type: task | Status: new
  Priority: normal | Milestone: 8.0.0
Component: Imagery | Version: svn-trunk
Resolution: | Keywords: i.maxlik
       CPU: Unspecified | Platform: All
--------------------------+-------------------------

Comment (by veroandreo):

Replying to [comment:3 martinl]:
> So you don't need to remove output maps from group in each new run...
Good! Thanks for clarification, Martin! I still prefer not to have
classification results in the group, though

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3525#comment:5>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 1, 2018, 9:00pm

#3525: Removing the behavior of i.maxlik which add the output to input group
--------------------------+-------------------------
  Reporter: spareeth | Owner: grass-dev@…
      Type: task | Status: new
  Priority: normal | Milestone: 8.0.0
Component: Imagery | Version: svn-trunk
Resolution: | Keywords: i.maxlik
       CPU: Unspecified | Platform: All
--------------------------+-------------------------

Comment (by mmetz):

Replying to [comment:5 veroandreo]:
> Replying to [comment:3 martinl]:
> > So you don't need to remove output maps from group in each new run...
> Good! Thanks for clarification, Martin! I still prefer not to have
classification results in the group, though

Assuming that imagery modules accept a group/subgroup as input that is not
in the current mapset, the output can not be added to the input group if
it is not in the current mapset.

The metadata of the output (datasource, description, comments) should in
any case contain information about how this output has been generated:
fully qualified input group/subgroup name, fully qualified input signature
file name if appropriate, and other parameters used by i.maxlik.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3525#comment:6>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 2, 2018, 2:11pm

#3525: Removing the behavior of i.maxlik which add the output to input group
--------------------------+-------------------------
  Reporter: spareeth | Owner: grass-dev@…
      Type: task | Status: new
  Priority: normal | Milestone: 8.0.0
Component: Imagery | Version: svn-trunk
Resolution: | Keywords: i.maxlik
       CPU: Unspecified | Platform: All
--------------------------+-------------------------

Comment (by marisn):

Replying to [comment:6 mmetz]:
> Replying to [comment:5 veroandreo]:
> Assuming that imagery modules accept a group/subgroup as input that is
not in the current mapset, the output can not be added to the input group
if it is not in the current mapset.

This is a good argument. Still at the moment only library and i.group has
been changed to allow reading group contents from other mapsets. See
r73632 and r73633

This issue should be viewed together with signature files as those also
are placed into the group/subgroup.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3525#comment:7>
GRASS GIS <https://grass.osgeo.org>

GDAL · November 5, 2018, 10:39am

#3525: Removing the behavior of i.maxlik which add the output to input group
--------------------------+-------------------------
  Reporter: spareeth | Owner: grass-dev@…
      Type: task | Status: new
  Priority: normal | Milestone: 8.0.0
Component: Imagery | Version: svn-trunk
Resolution: | Keywords: i.maxlik
       CPU: Unspecified | Platform: All
--------------------------+-------------------------

Comment (by mlennert):