[GRASS-dev] [GRASS GIS] #3603: Trunk does not compile on Mac

#3603: Trunk does not compile on Mac
------------------------+-------------------------
Reporter: cmbarton | Owner: grass-dev@…
     Type: defect | Status: new
Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Keywords: calc, nviz | CPU: Unspecified
Platform: MacOSX |
------------------------+-------------------------
I have not been able to compile GRASS trunk since last week. I did a fresh
checkout this morning to try it again with r72966. There are errors in:

/lib/nviz (new this morning)
/lib/calc (as was the case last week)
/misc/m.nviz.image (does not make because /lib/nviz does not make)

I am attaching the error output for both items. We can split ticket if
needed.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------
Changes (by cmbarton):

* Attachment "nviz_error.txt" added.

nviz compile error

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------
Changes (by cmbarton):

* Attachment "calc_error.txt" added.

calc compile error

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------

Comment (by cmbarton):

Part probably related to ticket #3600

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------

Comment (by mmetz):

Replying to [ticket:3603 cmbarton]:
> I have not been able to compile GRASS trunk since last week. I did a
fresh checkout this morning to try it again with r72966. There are errors
in:
>
> /lib/nviz (new this morning)
> /lib/calc (as was the case last week)

do you have

{{{
extern func_t f_ceil;
extern func_t f_floor;
}}}

in

Applications/GRASS-7.5.app/Contents/Resources/include/defs/calc.h

and also in

Users/cmbarton/grass_source/trunk/dist.x86_64-apple-
darwin17.6.0/include/grass/defs/calc.h

?

> /misc/m.nviz.image (does not make because /lib/nviz does not make)
>
> I am attaching the error output for both items. We can split ticket if
needed.
>

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------

Comment (by hcho):

Replying to [comment:1 cmbarton]:
> Part probably related to ticket #3600

Please make sure to copy the latest include/nviz.h to your
dist.../include/grass/nviz.h

New members width and height were added to render_window struct.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------

Comment (by cmbarton):

Replying to [comment:2 mmetz]:
> Replying to [ticket:3603 cmbarton]:
> > I have not been able to compile GRASS trunk since last week. I did a
fresh checkout this morning to try it again with r72966. There are errors
in:
> >
> > /lib/nviz (new this morning)
> > /lib/calc (as was the case last week)
>
> do you have
>
> {{{
> extern func_t f_ceil;
> extern func_t f_floor;
> }}}
>
> in
>
> Applications/GRASS-7.5.app/Contents/Resources/include/defs/calc.h
>
> and also in
>
> Users/cmbarton/grass_source/trunk/dist.x86_64-apple-
darwin17.6.0/include/grass/defs/calc.h
>
> ?
>

Yes to both questions

> > /misc/m.nviz.image (does not make because /lib/nviz does not make)
> >
> > I am attaching the error output for both items. We can split ticket if
needed.
> >

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------

Comment (by cmbarton):

Replying to [comment:3 hcho]:
> Replying to [comment:1 cmbarton]:
> > Part probably related to ticket #3600
>
> Please make sure to copy the latest include/nviz.h to your
dist.../include/grass/nviz.h
>
> New members width and height were added to render_window struct.

Copy from where? I have a fresh trunk checkout.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------

Comment (by mmetz):

Replying to [comment:4 cmbarton]:
> Replying to [comment:2 mmetz]:
> > Replying to [ticket:3603 cmbarton]:
> > > I have not been able to compile GRASS trunk since last week. I did a
fresh checkout this morning to try it again with r72966. There are errors
in:
> > >
> > > /lib/nviz (new this morning)
> > > /lib/calc (as was the case last week)
> >
> > do you have
> >
> > {{{
> > extern func_t f_ceil;
> > extern func_t f_floor;
> > }}}
> >
> > in
> >
> > Applications/GRASS-7.5.app/Contents/Resources/include/defs/calc.h
> >
> > and also in
> >
> > Users/cmbarton/grass_source/trunk/dist.x86_64-apple-
darwin17.6.0/include/grass/defs/calc.h
> >
> > ?
> >
>
>
> Yes to both questions

This is not possible. The error message suggests:

{{{
/Applications/GRASS-7.5.app/Contents/Resources/include/grass/defs/calc.h:63:15:
note: 'f_float' declared here
         extern func_t f_float;
}}}

but f_float is now in line 65, two lines further down, because the two new
functions f_ceil and f_floor have been added. That means
{{{
/Applications/GRASS-7.5.app/Contents/Resources/include/grass/defs/calc.h
}}}
is not up to date.

Why is

{{{
Applications/GRASS-7.5.app/Contents/Resources/include
}}}

included at all? The location of GRASS includes at compile time should be
{{{
Users/cmbarton/grass_source/trunk/dist.x86_64-apple-darwin17.6.0/include
}}}

without alternative locations.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603#comment:6&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------

Comment (by cmbarton):

Replying to [comment:6 mmetz]:
> Replying to [comment:4 cmbarton]:
> > Replying to [comment:2 mmetz]:
> > > Replying to [ticket:3603 cmbarton]:
> > > > I have not been able to compile GRASS trunk since last week. I did
a fresh checkout this morning to try it again with r72966. There are
errors in:
> > > >
> > > > /lib/nviz (new this morning)
> > > > /lib/calc (as was the case last week)
> > >
> > > do you have
> > >
> > > {{{
> > > extern func_t f_ceil;
> > > extern func_t f_floor;
> > > }}}
> > >
> > > in
> > >
> > > Applications/GRASS-7.5.app/Contents/Resources/include/defs/calc.h

I do NOT have anything in
Applications/GRASS-7.5.app/Contents/Resources/include/defs/ because source
won't compile

> > >
> > > and also in
> > >
> > > Users/cmbarton/grass_source/trunk/dist.x86_64-apple-
darwin17.6.0/include/grass/defs/calc.h

I do have it here

> > >
> > > ?
> > >
> >
> >
> > Yes to both questions
>
> This is not possible. The error message suggests:
>
> {{{
>
/Applications/GRASS-7.5.app/Contents/Resources/include/grass/defs/calc.h:63:15:
note: 'f_float' declared here
> extern func_t f_float;
> }}}
>
> but f_float is now in line 65, two lines further down, because the two
new functions f_ceil and f_floor have been added. That means
> {{{
> /Applications/GRASS-7.5.app/Contents/Resources/include/grass/defs/calc.h
> }}}
> is not up to date.
>
> Why is
>
> {{{
> Applications/GRASS-7.5.app/Contents/Resources/include
> }}}
>
> included at all? The location of GRASS includes at compile time should
be
> {{{
> Users/cmbarton/grass_source/trunk/dist.x86_64-apple-darwin17.6.0/include
> }}}
>
> without alternative locations.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603#comment:7&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------

Comment (by mmetz):

Replying to [comment:7 cmbarton]:
> I do NOT have anything in
Applications/GRASS-7.5.app/Contents/Resources/include/defs/ because source
won't compile

citing from calc_error.txt posted by yourself:
{{{
/Applications/GRASS-7.5.app/Contents/Resources/include/grass/defs/calc.h:63:15:
note: 'f_float' declared here
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603#comment:8&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------

Comment (by cmbarton):

That's the install path, but I have not been able to do a make install. I
will delete the app and try again.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603#comment:9&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: fixed | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------
Changes (by cmbarton):

* status: new => closed
* resolution: => fixed

Comment:

Figure it out. Somehow make was finding the old version in the install
path. Deleting the app made it compile without errors. Thanks.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603#comment:10&gt;
GRASS GIS <https://grass.osgeo.org>

#3603: Trunk does not compile on Mac
--------------------------+-------------------------
  Reporter: cmbarton | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: critical | Milestone:
Component: Default | Version: svn-trunk
Resolution: fixed | Keywords: calc, nviz
       CPU: Unspecified | Platform: MacOSX
--------------------------+-------------------------

Comment (by mmetz):

Replying to [comment:9 cmbarton]:
> That's the install path, but I have not been able to do a make install.
I will delete the app and try again.

Why is the install path
{{{
Applications/GRASS-7.5.app/Contents/Resources/include
}}}

included at all? The location of GRASS includes at compile time should be
{{{
Users/cmbarton/grass_source/trunk/dist.x86_64-apple-darwin17.6.0/include
}}}

without alternative locations.

This path
{{{
Users/cmbarton/grass_source/trunk/dist.x86_64-apple-darwin17.6.0/include
}}}
can be outdated, please also double-check
{{{
Users/cmbarton/grass_source/trunk/include
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3603#comment:11&gt;
GRASS GIS <https://grass.osgeo.org>