[GRASS-dev] [GRASS GIS] #3746: Quouting of strings with white space in t.info breaks tests for temporal modules

GRASS GRASS developer
1

#3746: Quouting of strings with white space in t.info breaks tests for temporal
modules
-----------------------------+-------------------------
Reporter: sbl | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.8.0
Component: Tests | Version: svn-trunk
Keywords: temporal,t.info | CPU: All
Platform: All |
-----------------------------+-------------------------
When working on t.rast.aggregate, I noticed that tests fail du to quoting
of strings in t.info.

Working on it...

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3746&gt;
GRASS GIS <https://grass.osgeo.org>

2

#3746: Quouting of strings with white space in t.info breaks tests for temporal
modules
---------------------+-----------------------------
  Reporter: sbl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.8.0
Component: Tests | Version: svn-trunk
Resolution: | Keywords: temporal,t.info
       CPU: All | Platform: All
---------------------+-----------------------------

Comment (by sbl):

Relevant files:

{{{
temporal/t.connect/testsuite/test_distr_tgis_db_raster3d.py
temporal/t.connect/testsuite/test_distr_tgis_db_raster.py
temporal/t.connect/testsuite/test_distr_tgis_db_vector.py
temporal/t.info/testsuite/test.t.info.sh
temporal/t.merge/testsuite/test.t.merge.sh
temporal/t.rast3d.extract/testsuite/test_extract.py
temporal/t.rast3d.extract/testsuite/test.t.rast3d.extract.sh
temporal/t.rast.accdetect/testsuite/test_simple.py
temporal/t.rast.aggregate.ds/testsuite/test.t.rast.aggregate.ds.sh
temporal/t.rast.aggregate/testsuite/test_aggregation_absolute_parallel.py
temporal/t.rast.aggregate/testsuite/test_aggregation_absolute.py
temporal/t.rast.aggregate/testsuite/test_aggregation_relative.py
temporal/t.rast.contour/testsuite/test_convert.py
temporal/t.rast.extract/testsuite/test_extract.py
temporal/t.rast.gapfill/testsuite/test_gapfill.py
temporal/t.rast.import/testsuite/test_temporal_rast_import.py
temporal/t.rast.series/testsuite/test_series.py
temporal/t.rast.to.vect/testsuite/test_to_vect.py
temporal/t.vect.extract/testsuite/test_vect_extract.py
temporal/t.vect.observe.strds/testsuite/test.t.vect.observe.strds.layer_bug.sh
temporal/t.vect.observe.strds/testsuite/test.t.vect.observe.strds.relative.sh
temporal/t.vect.observe.strds/testsuite/test.t.vect.observe.strds.sh

}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3746#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

3

#3746: Quouting of strings with white space in t.info breaks tests for temporal
modules
---------------------+-----------------------------
  Reporter: sbl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.8.0
Component: Tests | Version: svn-trunk
Resolution: | Keywords: temporal,t.info
       CPU: All | Platform: All
---------------------+-----------------------------

Comment (by sbl):

In [changeset:"74054" 74054]:
{{{
#!CommitTicketReference repository="" revision="74054"
t.connect testsuite; fix info quotes; see #3746
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3746#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

4

#3746: Quouting of strings with white space in t.info breaks tests for temporal
modules
---------------------+-----------------------------
  Reporter: sbl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.8.0
Component: Tests | Version: svn-trunk
Resolution: | Keywords: temporal,t.info
       CPU: All | Platform: All
---------------------+-----------------------------

Comment (by sbl):

In [changeset:"74055" 74055]:
{{{
#!CommitTicketReference repository="" revision="74055"
t.rast3d.extract testsuite; fix info quotes; see #3746
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3746#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

5

#3746: Quouting of strings with white space in t.info breaks tests for temporal
modules
---------------------+-----------------------------
  Reporter: sbl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.8.0
Component: Tests | Version: svn-trunk
Resolution: | Keywords: temporal,t.info
       CPU: All | Platform: All
---------------------+-----------------------------

Comment (by sbl):

In [changeset:"74059" 74059]:
{{{
#!CommitTicketReference repository="" revision="74059"
more t.info quote fixes; see #3746
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3746#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

6

#3746: Quouting of strings with white space in t.info breaks tests for temporal
modules
---------------------+-----------------------------
  Reporter: sbl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.8.0
Component: Tests | Version: svn-trunk
Resolution: | Keywords: temporal,t.info
       CPU: All | Platform: All
---------------------+-----------------------------

Comment (by sbl):

In [changeset:"74073" 74073]:
{{{
#!CommitTicketReference repository="" revision="74073"
add quotes around t.info strings; see #3746
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3746#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>

7

#3746: Quouting of strings with white space in t.info breaks tests for temporal
modules
---------------------+-----------------------------
  Reporter: sbl | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.8.0
Component: Tests | Version: svn-trunk
Resolution: fixed | Keywords: temporal,t.info
       CPU: All | Platform: All
---------------------+-----------------------------
Changes (by sbl):

* status: new => closed
* resolution: => fixed

Comment:

The rest of the test-errors in the temporal testsuites were not touched as
they indicate other issues (e.g. related to Python 3, changed results, or
errors in the test-code.)

Types of those errors are:
* AssertionError: reference argument is not a string (in several tests)
* grass.exceptions.FatalError: Wrong type of input A (in algebra tests)
* AttributeError: 'NoneType' object has no attribute 'second' (in several
tests related to datetime_math)
* AssertionError: There is no map <b_2001_01_01_00> of type <raster> in
the current mapset (t.rast.aggregate)
* Process ended with non-zero return code t.remove(inputs=['R'],
type='strds', flags=u'rf', quiet=True). See errors in the (error) output.
* UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in
position 2: ordinal not in range(128)

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3746#comment:6&gt;
GRASS GIS <https://grass.osgeo.org>