[GRASS-dev] [GRASS GIS] #3797: r.horizon suffix gets messed up in multi-direction mode

#3797: r.horizon suffix gets messed up in multi-direction mode
-----------------------+-------------------------
Reporter: sbl | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.8.0
Component: Raster | Version: svn-trunk
Keywords: r.horizon | CPU: Unspecified
Platform: Linux |
-----------------------+-------------------------
Suffixes for angles in r.horizon get messed up and become "%03". See:

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2019-03-18-07-00/report_for_nc_spm_full_v2alpha_nc/raster/r.horizon/test_r_horizon/index.html

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3797&gt;
GRASS GIS <https://grass.osgeo.org>

#3797: r.horizon suffix gets messed up in multi-direction mode
--------------------------+-------------------------
  Reporter: sbl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.8.0
Component: Raster | Version: svn-trunk
Resolution: | Keywords: r.horizon
       CPU: Unspecified | Platform: Linux
--------------------------+-------------------------

Comment (by mmetz):

Fixed in trunk r74298.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3797#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

#3797: r.horizon suffix gets messed up in multi-direction mode
--------------------------+-------------------------
  Reporter: sbl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.8.0
Component: Raster | Version: svn-trunk
Resolution: | Keywords: r.horizon
       CPU: Unspecified | Platform: Linux
--------------------------+-------------------------

Comment (by sbl):

Tested successfully :
http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2019-03-23-07-00/report_for_nc_spm_full_v2alpha_nc/raster/r.horizon/test_r_horizon/index.html

Backport candidate?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3797#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

#3797: r.horizon suffix gets messed up in multi-direction mode
--------------------------+-------------------------
  Reporter: sbl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.8.0
Component: Raster | Version: svn-trunk
Resolution: | Keywords: r.horizon
       CPU: Unspecified | Platform: Linux
--------------------------+-------------------------

Comment (by mmetz):

Replying to [comment:2 sbl]:
> Tested successfully :
http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2019-03-23-07-00/report_for_nc_spm_full_v2alpha_nc/raster/r.horizon/test_r_horizon/index.html
>
> Backport candidate?

No because only trunk was affected.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3797#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

#3797: r.horizon suffix gets messed up in multi-direction mode
--------------------------+-------------------------
  Reporter: sbl | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.8.0
Component: Raster | Version: svn-trunk
Resolution: fixed | Keywords: r.horizon
       CPU: Unspecified | Platform: Linux
--------------------------+-------------------------
Changes (by sbl):

* status: new => closed
* resolution: => fixed

Comment:

Very good. Then I take the liberty to close this ticket...

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3797#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

#3797: r.horizon suffix gets messed up in multi-direction mode
--------------------------+-------------------------
  Reporter: sbl | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.8.0
Component: Raster | Version: svn-trunk
Resolution: fixed | Keywords: r.horizon
       CPU: Unspecified | Platform: Linux
--------------------------+-------------------------

Comment (by mmetz):

Replying to [comment:4 sbl]:
> Very good. Then I take the liberty to close this ticket...

Hi Stefan, you are the original reporter of this ticket, therefore you
have IMHO the right to close the ticket. Someone else submitting a fix can
also close the ticket if this person is really confident that the issue
has been fixed.

In this case, my system behaved differently: the wrong output on
http://fatra.cnr.ncsu.edu/grassgistests/ was
"test_horizon_output_from_elevation_%03", but on my system it was
"test_horizon_output_from_elevation_", i.e. my system behaved differently.
With my fix, my system produced correct output, and I was quite but not
really sure that my fix works on other systems as well. Thus waiting for
confirmation by the original reporter that the fix is working on other
systems as well.

This particular bug and the related fix passed CI, thus CI is in this case
not good enough, only the test for r.horizon. Another point to
  1. get the testsuite all green
  2. make CI run the testsuite and let CI fail if the testsuite is not all
green

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3797#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>