[GRASS-dev] [GRASS GIS] #3839: r.watershed usage inconsistency

GRASS GRASS developer
1

#3839: r.watershed usage inconsistency
-------------------------+-------------------------
Reporter: martinl | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 7.6.2
Component: Raster | Version: svn-trunk
Keywords: r.watershed | CPU: Unspecified
Platform: Unspecified |
-------------------------+-------------------------
r.watershed source code says

{{{
     /* Check for some output map */
     if ((opt8->answer == NULL)
         && (opt9->answer == NULL)
         && (opt10->answer == NULL)
         && (opt11->answer == NULL)
         && (opt12->answer == NULL)
         && (opt14->answer == NULL)
         && (opt15->answer == NULL)) {
         G_fatal_error(_("Sorry, you must choose an output map."));
     }
}}}

but there are more output raster maps defined, eg.

{{{
     opt13 = G_define_standard_option(G_OPT_R_OUTPUT);
     opt13->key = "length_slope";
     opt13->label = _("Name for output slope length raster map");
     opt13->description = _("Slope length and steepness (LS) factor for
USLE");
     opt13->required = NO;
     opt13->guisection = _("Outputs");
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3839&gt;
GRASS GIS <https://grass.osgeo.org>

2

#3839: r.watershed usage inconsistency
--------------------------+-------------------------
  Reporter: martinl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.6.2
Component: Raster | Version: svn-trunk
Resolution: | Keywords: r.watershed
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------

Comment (by martinl):

In [changeset:"74452" 74452]:
{{{
#!CommitTicketReference repository="" revision="74452"
r.watershed usage inconsistency, see #3839
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3839#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

3

#3839: r.watershed usage inconsistency
--------------------------+-------------------------
  Reporter: martinl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.6.2
Component: Raster | Version: svn-trunk
Resolution: | Keywords: r.watershed
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------

Comment (by martinl):

Should be fixed in r74452:

{{{
r.watershed elev=dem
...
ERROR: At least one of the following options is required: <accumulation>,
<tci>, <spi>, <drainage>, <basin>, <stream>, <half_basin>, <length_slope>
and <slope_steepness>
}}}

Also `threshold` check improved:

{{{
r.watershed elev=dem basin=x
...
ERROR: Option <basin> requires <threshold>
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3839#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

4

#3839: r.watershed usage inconsistency
--------------------------+-------------------------
  Reporter: martinl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.6.2
Component: Raster | Version: svn-trunk
Resolution: | Keywords: r.watershed
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------

Comment (by martinl):

If no objection I will backport r74452 to GRASS76 release branch.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3839#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

5

#3839: r.watershed usage inconsistency
--------------------------+-------------------------
  Reporter: martinl | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone: 7.6.2
Component: Raster | Version: svn-trunk
Resolution: | Keywords: r.watershed
       CPU: Unspecified | Platform: Unspecified
--------------------------+-------------------------

Comment (by mmetz):

Replying to [comment:3 martinl]:
> If no objection I will backport r74452 to GRASS76 release branch.

Looks good to me.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3839#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>