[GRASS-dev] [GRASS GIS] #388: *.tcl installed as executable

#388: *.tcl installed as executable
---------------------------+------------------------------------------------
Reporter: hamish | Owner: grass-dev@lists.osgeo.org
     Type: defect | Status: new
Priority: minor | Milestone: 6.4.0
Component: Installation | Version: svn-develbranch6
Keywords: build install | Platform: Linux
      Cpu: Unspecified |
---------------------------+------------------------------------------------
Hi,

browsing through the Debian lintian package report for grass 6.2.3 I
notice that the .tcl files installed in $(ETC)/dm/,gm/ are incorrectly
given an executable bit in the file system.

http://lintian.debian.org/maintainer/pkg-grass-
devel@lists.alioth.debian.org.html#grass

some Makefile magic required..

Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/388&gt;
GRASS GIS <http://grass.osgeo.org>

#388: *.tcl installed as executable
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: minor | Milestone: 6.4.0
Component: Installation | Version: svn-develbranch6
Resolution: | Keywords: build install
  Platform: Linux | Cpu: Unspecified
---------------------------+------------------------------------------------
Comment (by glynn):

Replying to [ticket:388 hamish]:

> browsing through the Debian lintian package report for grass 6.2.3 I
notice that the .tcl files installed in $(ETC)/dm/,gm/ are incorrectly
given an executable bit in the file system.

> some Makefile magic required..

I've changed gis.m/Makefile from $(INSTALL) to $(INSTALL_DATA) in r34721.
tksys.tcl is an executable script, so I explicitly added execute
permission for that file.

d.m would need something similar, if we're going to keep it. Is there any
reason to? Does it still work?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/388#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#388: *.tcl installed as executable
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: minor | Milestone: 6.4.0
Component: Installation | Version: svn-develbranch6
Resolution: | Keywords: build install
  Platform: Linux | Cpu: Unspecified
---------------------------+------------------------------------------------
Comment (by hamish):

Replying to [comment:1 glynn]:
> I've changed gis.m/Makefile from $(INSTALL) to $(INSTALL_DATA)
> in r34721. tksys.tcl is an executable script, so I explicitly
> added execute permission for that file.

thanks.

> d.m would need something similar, if we're going to keep it.
> Is there any reason to?

Apparently some people prefer it. All the g.gui and init.sh stuff is set
up to handle it well in a mixed environment; it doesn't hurt anything; and
has taken minimal effort to maintain. So I'd say there's no reason to
remove it.

> Does it still work?

yes, it works fine.

Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/388#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#388: *.tcl installed as executable
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: closed
  Priority: minor | Milestone: 6.4.0
Component: Installation | Version: svn-develbranch6
Resolution: fixed | Keywords: build install
  Platform: Linux | Cpu: Unspecified
---------------------------+------------------------------------------------
Changes (by hamish):

  * status: new => closed
  * resolution: => fixed

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/388#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>