[GRASS-dev] [GRASS GIS] #3942: r.geomorphon compiler warnings

GRASS GRASS developer
1

#3942: r.geomorphon compiler warnings
--------------------+---------------------------------
Reporter: nila | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone:
Component: Addons | Version: svn-releasebranch76
Keywords: | CPU: Unspecified
Platform: MacOSX |
--------------------+---------------------------------
Compiling r.geomorphon generates 2 warnings, see attached log file.

This occures with 7.6.1, but the relevant code in master has not changed.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3942&gt;
GRASS GIS <https://grass.osgeo.org>

2

#3942: r.geomorphon compiler warnings
--------------------------+---------------------------------
  Reporter: nila | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone:
Component: Addons | Version: svn-releasebranch76
Resolution: | Keywords:
       CPU: Unspecified | Platform: MacOSX
--------------------------+---------------------------------
Changes (by nila):

* Attachment "r.geomorphon_compile.log" added.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3942&gt;
GRASS GIS <https://grass.osgeo.org>

3

#3942: r.geomorphon compiler warnings
--------------------------+---------------------------------
  Reporter: nila | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone:
Component: Addons | Version: svn-releasebranch76
Resolution: | Keywords:
       CPU: Unspecified | Platform: MacOSX
--------------------------+---------------------------------

Comment (by mmetz):

Replying to [ticket:3942 nila]:
> Compiling r.geomorphon generates 2 warnings, see attached log file.
>
> This occures with 7.6.1, but the relevant code in master has not
changed.

Since this is an addon, the GRASS version does not really matter. The
addon has been fixed in [https://github.com/OSGeo/grass-
addons/commit/b1c415a363f46e5fe16563d5821a87c51996390e#diff-
a7ba809b2709116bc5a5319e2ff8c99b b1c415a3]

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3942#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

4

#3942: r.geomorphon compiler warnings
--------------------------+---------------------------------
  Reporter: nila | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone:
Component: Addons | Version: svn-releasebranch76
Resolution: | Keywords:
       CPU: Unspecified | Platform: MacOSX
--------------------------+---------------------------------

Comment (by neteler):

Replying to [comment:1 mmetz]:
> Since this is an addon, the GRASS version does not really matter. The
addon has been fixed in [https://github.com/OSGeo/grass-
addons/commit/b1c415a363f46e5fe16563d5821a87c51996390e#diff-
a7ba809b2709116bc5a5319e2ff8c99b b1c415a3]

But r.geomorphon is a "main" command (the addon is deprecated). Is there
anything to fix also in master and rel_branches?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3942#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

5

#3942: r.geomorphon compiler warnings
--------------------------+---------------------------------
  Reporter: nila | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone:
Component: Addons | Version: svn-releasebranch76
Resolution: | Keywords:
       CPU: Unspecified | Platform: MacOSX
--------------------------+---------------------------------

Comment (by nila):

> But r.geomorphon is a "main" command (the addon is deprecated). Is there
anything to fix also in master and rel_branches?

Indeed, the same should be fixed for built-in command at
[https://github.com/OSGeo/grass/tree/master/raster/r.geomorphon master]
and branches.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3942#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

6

#3942: r.geomorphon compiler warnings
--------------------------+---------------------------------
  Reporter: nila | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone:
Component: Addons | Version: svn-releasebranch76
Resolution: | Keywords:
       CPU: Unspecified | Platform: MacOSX
--------------------------+---------------------------------

Comment (by mmetz):

Replying to [comment:3 nila]:
> > But r.geomorphon is a "main" command (the addon is deprecated). Is
there anything to fix also in master and rel_branches?
>
> Indeed, the same should be fixed for built-in command at
[https://github.com/OSGeo/grass/tree/master/raster/r.geomorphon master]
and branches.

OK, fixed in master and relbr78.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3942#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

7

#3942: r.geomorphon compiler warnings
--------------------------+---------------------------------
  Reporter: nila | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: normal | Milestone:
Component: Addons | Version: svn-releasebranch76
Resolution: | Keywords:
       CPU: Unspecified | Platform: MacOSX
--------------------------+---------------------------------

Comment (by nila):

Great, thanks!

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3942#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>

8

#3942: r.geomorphon compiler warnings
--------------------------+---------------------------------
  Reporter: nila | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 7.8.2
Component: Raster | Version: svn-releasebranch76
Resolution: fixed | Keywords: r.geomorphon
       CPU: Unspecified | Platform: MacOSX
--------------------------+---------------------------------
Changes (by neteler):

* status: new => closed
* component: Addons => Raster
* resolution: => fixed
* keywords: => r.geomorphon
* milestone: => 7.8.2

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3942#comment:6&gt;
GRASS GIS <https://grass.osgeo.org>