[GRASS-dev] [GRASS GIS] #412: add bbox check to d.rast

GRASS GRASS developer
1

#412: add bbox check to d.rast
-------------------------+--------------------------------------------------
Reporter: karme | Owner: grass-dev@lists.osgeo.org
     Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: default | Version: unspecified
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
patch applied

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/412&gt;
GRASS GIS <http://grass.osgeo.org>

2

#412: add bbox check to d.rast
--------------------------+-------------------------------------------------
  Reporter: karme | Owner: grass-dev@lists.osgeo.org
      Type: enhancement | Status: new
  Priority: trivial | Milestone: 6.4.0
Component: default | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: Unspecified
--------------------------+-------------------------------------------------
Changes (by karme):

  * priority: major => trivial
  * platform: Unspecified => All
  * version: unspecified => svn-develbranch6
  * type: defect => enhancement

Comment:

the description should read "patch attached"

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/412#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

3

#412: add bbox check to d.rast
--------------------------+-------------------------------------------------
  Reporter: karme | Owner: grass-dev@lists.osgeo.org
      Type: enhancement | Status: new
  Priority: trivial | Milestone: 6.4.0
Component: default | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: Unspecified
--------------------------+-------------------------------------------------
Comment (by glynn):

Replying to [ticket:412 karme]:

There appear to be a couple of things wrong here:

1. It assumes -o (or the lack of -n in 7.0). Without -o or with -n, a
raster which doesn't overlap the current region should result in a solid
rectangle in the map's null value colour.

2. D_cell_draw_setup() is called unconditionally, but D_cell_draw_end() is
only called if the raster is visible. These calls must be matched, i.e.
either both must be called, or neither.

Apart from that, I would suggest making the patch against 7.0.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/412#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

4

#412: add bbox check to d.rast
--------------------------+-------------------------------------------------
  Reporter: karme | Owner: grass-dev@lists.osgeo.org
      Type: enhancement | Status: new
  Priority: trivial | Milestone: 6.4.0
Component: default | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: Unspecified
--------------------------+-------------------------------------------------
Comment (by karme):

Attached updated patch addressing both issues.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/412#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

5

#412: add bbox check to d.rast
-------------------------+--------------------------------------------------
Reporter: karme | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: trivial | Milestone: 7.0.0
Component: Default | Version: svn-trunk
Keywords: | Platform: All
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by neteler):

  * version: svn-develbranch6 => svn-trunk
  * milestone: 6.4.0 => 7.0.0

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/412#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

6

#412: add bbox check to d.rast
-------------------------+--------------------------------------------------
Reporter: karme | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: trivial | Milestone: 7.0.0
Component: Display | Version: svn-trunk
Keywords: d.rast | Platform: All
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by neteler):

  * keywords: => d.rast
  * component: Default => Display

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/412#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>