[GRASS-dev] [GRASS GIS] #46: NVIZ fly mode broken on 64bit systems

#46: NVIZ fly mode broken on 64bit systems
---------------------+------------------------------------------------------
Reporter: marisn | Owner: grass-dev@lists.osgeo.org
     Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: default | Version: svn-trunk
Keywords: nviz |
---------------------+------------------------------------------------------
Fly mode in NVIZ is broken - when flying around, camera moves for some sec
and then resets back to it's initial position.

Buggy on 64bit Ubuntu 7.10 and 64bit OpenSuSE 10.3 (both use Nvidia
drivers) with GRASS 6.2.2, 6.2.3, current trunk. 32bit Gentoo (intel
driver) with current trunk is not affected - it must be a 64bit problem.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/46&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

#46: NVIZ fly mode broken on 64bit systems
----------------------+-----------------------------------------------------
  Reporter: marisn | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: default | Version: svn-trunk
Resolution: | Keywords: nviz
----------------------+-----------------------------------------------------
Comment (by neteler):

Confirmed on Mandriva 2007.1/64bit with NVIDIA.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/46#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

#46: NVIZ fly mode broken on 64bit systems
----------------------+-----------------------------------------------------
  Reporter: marisn | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: default | Version: svn-trunk
Resolution: | Keywords: nviz
----------------------+-----------------------------------------------------
Comment (by neteler):

Confirmed on Mandriva 2008.0/64bit with NVIDIA.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/46#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

#46: NVIZ fly mode broken on 64bit systems
---------------------+------------------------------------------------------
  Reporter: marisn | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: NVIZ | Version: svn-trunk
Resolution: | Keywords: nviz
---------------------+------------------------------------------------------
Changes (by neteler):

  * component: default => NVIZ

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/46#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#46: NVIZ fly mode broken on 64bit systems
-------------------------+--------------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.1
Component: NVIZ | Version: svn-trunk
Keywords: nviz | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by marisn):

  * platform: => Unspecified
  * cpu: => Unspecified
  * milestone: 6.4.0 => 6.4.1

Comment:

Doesn't seem to make to 6.4.0.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/46#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#46: NVIZ fly mode broken on 64bit systems
-------------------------+--------------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.1
Component: NVIZ | Version: svn-trunk
Keywords: nviz | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by kwasnicki):

looks like the problem is a float overflow in
togl_flythrough.c:this_time() function. changing the (float) casts to
(double) has fixed this on my 64bit slackware install.

diff attached... although not 100% sure if i created the diff patch
properly, but this is just a one line change so i'm sure the code
maintainer can replicate the necessary change if the diff doesn't work.
:wink:

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/46#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#46: NVIZ fly mode broken on 64bit systems
-------------------------+--------------------------------------------------
Reporter: marisn | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: NVIZ | Version: svn-trunk
Keywords: nviz | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by hamish):

  * milestone: 6.4.1 => 6.4.0

Comment:

Replying to [comment:5 kwasnicki]:
> diff attached... although not 100% sure if i created the diff
> patch properly, but this is just a one line change so i'm sure the
> code maintainer can replicate the necessary change if the diff
> doesn't work. :wink:

it ended up backwards, but it's just a 1 liner so no worries.

preferred method for creating patches is `svn diff`:
   http://grass.osgeo.org/wiki/Bugs#Patches

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/46#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

#46: NVIZ fly mode broken on 64bit systems
--------------------------+-------------------------------------------------
  Reporter: marisn | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: major | Milestone: 6.4.0
Component: NVIZ | Version: svn-trunk
Resolution: fixed | Keywords: nviz
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Changes (by marisn):

  * status: new => closed
  * resolution: => fixed

Comment:

Fixed and backported to 6.4. r42592, r42593, r42594

Thanks to Ken Kwasnicki.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/46#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>