#462: Tcl interp->result deprecated
---------------------+------------------------------------------------------
Reporter: neteler | Owner: grass-dev@lists.osgeo.org
Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: Tcl | Version: svn-develbranch6
Keywords: | Platform: All
Cpu: All |
---------------------+------------------------------------------------------
In Tcl, interp->result is (really) deprecated from Tcl8.6 onwards. Still
it is used in several modules:
Funda Wang has proposed a patch set: http://svn.mandriva.com/cgi-
bin/viewvc.cgi/packages/cooker/grass/current/SOURCES/grass-6.4.0-tcl8.6.patch?view=log
which I attached to the ticket.
Is it correct and can be submitted to 6.4.x to gain compatibility with
Tcl > 8.5? Related problems on Mac where reported.
#462: Tcl interp->result deprecated
----------------------+-----------------------------------------------------
Reporter: neteler | Owner: grass-dev@lists.osgeo.org
Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: Tcl | Version: svn-develbranch6
Resolution: | Keywords:
Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Comment (by marisn):
Replying to [comment:2 fundawang]:
> i've finally finish the patch, at URL:
> http://svn.mandriva.com/cgi-
bin/viewvc.cgi/packages/cooker/grass/current/SOURCES/grass-6.4.0-tcl8.6.patch
>
> The attached patch is an outdated one.
I tested this patch with develbranch_6 and tcl-8.4.19. v.digit -n
map=newmap segfaults during launch. Can provide bt on request.
#462: Tcl interp->result deprecated
----------------------+-----------------------------------------------------
Reporter: neteler | Owner: grass-dev@lists.osgeo.org
Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: Tcl | Version: svn-develbranch6
Resolution: | Keywords:
Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Comment (by neteler):
Since the update patch requires more verification, the TCL tip #330 hack
was implemented in r35624 and r35625 . The hack was tested with nviz,
d.what.vect and v.digit. The files in question now compile also with
Tcl8.6.
With later Tcl versions it will fail to compile so the patch suggested by
fundawang needs to be considered for the long term support.
#462: Tcl interp->result deprecated
----------------------+-----------------------------------------------------
Reporter: neteler | Owner: grass-dev@lists.osgeo.org
Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: Tcl | Version: svn-develbranch6
Resolution: | Keywords:
Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Comment (by marisn):
Replying to [comment:7 fundawang]:
> I think i know the reason of crash, cause I've misled the feature of
sscanf. I've updated the patch at usual place. Please test.
Hm. This patch really seems to work. Tested on ~x86 develbranch_6.
#462: Tcl interp->result deprecated
----------------------+-----------------------------------------------------
Reporter: neteler | Owner: grass-dev@lists.osgeo.org
Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: Tcl | Version: svn-develbranch6
Resolution: | Keywords:
Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Comment (by cmbarton):
Is this still an issue? We are only maintaining, not developing the TclTk
GUI beyond GRASS 6.4 right? So can't it freeze with TclTk 8.5 and/or this
patch?
#462: Tcl interp->result deprecated
----------------------+-----------------------------------------------------
Reporter: neteler | Owner: grass-dev@lists.osgeo.org
Type: defect | Status: new
Priority: major | Milestone: 6.4.1
Component: Tcl | Version: svn-develbranch6
Resolution: | Keywords:
Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Changes (by hamish):
* milestone: 6.4.0 => 6.4.1
Comment:
Replying to [comment:11 cmbarton]:
> Is this still an issue? We are only maintaining, not developing
> the TclTk GUI beyond GRASS 6.4 right? So can't it freeze with
> TclTk 8.5 and/or this patch?
FWIW, IMHO maintenance mode means not actively adding new features and
refactoring, but rather keeping things working. A small patch to keep it
working with tcl/tk 8.6 seems pretty well in the maintenance dept.
Replying to [comment:10 neteler]:
> Unsure about releasebranch_6_4 (where we currently use the TCL
> tip # 330 hack).
I suggest to leave the rest as-is for now and backport it to 6.4 if
someone using 8.6 complains or if someone really feels like it.
On the other hand it seems like a pretty simple change and we could close
the bug. I'll schedule the balance of it for 6.4.1.
I only concern about get it built