[GRASS-dev] [GRASS GIS] #519: osgeo4w build

GRASS GRASS developer
1

#519: osgeo4w build
-------------------------+--------------------------------------------------
Reporter: jef | Owner: grass-dev@lists.osgeo.org
     Type: task | Status: new
Priority: major | Milestone: 6.4.0
Component: default | Version: svn-develbranch6
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
attached the modifications I did to my GRASS tree to build for OSGeo4W

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/519&gt;
GRASS GIS <http://grass.osgeo.org>

2

#519: osgeo4w build
----------------------+-----------------------------------------------------
  Reporter: jef | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: new
  Priority: major | Milestone: 6.4.0
Component: default | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Changes (by neteler):

  * platform: Unspecified => All
  * cpu: Unspecified => All

Comment:

I have merged in the changes from Glynn (mailing list).

Questions: is the NOFILTEROUT=1 stuff needed (see include/Make/Lib.make
and lib/gis/Makefile in the path)?

I have taken out in the revised patch:
{{{
Index: lib/g3d/g3dmask.c

--- lib/g3d/g3dmask.c (revision 36200)
+++ lib/g3d/g3dmask.c (working copy)
@@ -309,12 +309,12 @@
         for (dy = y; dy < rows; dy++) {
             for (dx = x; dx < cols; dx++) {
                 G3D_MASKNUM(map, dx, dy, dz, tile, type);
- tile += length;
+ (unsigned char *)tile += length;
             }

- tile += xLength;
+ (unsigned char *)tile += xLength;
         }
- tile += yLength;
+ (unsigned char *)tile += yLength;
      }
  }
}}}

since it doesn't compile on Linux (C++ syntax?).

Please review the mingw_updated.diff patch and suggest for
lib/g3d/g3dmask.c.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/519#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

3

#519: osgeo4w build
----------------------+-----------------------------------------------------
  Reporter: jef | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: new
  Priority: major | Milestone: 6.4.0
Component: default | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Comment (by martinl):

wxGUI-related part of the patch submitted to devbr6
(http://trac.osgeo.org/grass/changeset/36220). The rest in progress...

Martin

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/519#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

4

#519: osgeo4w build
----------------------+-----------------------------------------------------
  Reporter: jef | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: new
  Priority: major | Milestone: 6.4.0
Component: default | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Changes (by martinl):

* cc: martinl (added)

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/519#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

5

#519: osgeo4w build
----------------------+-----------------------------------------------------
  Reporter: jef | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: new
  Priority: major | Milestone: 6.4.0
Component: default | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Comment (by martinl):

Replying to [comment:2 martinl]:
> wxGUI-related part of the patch submitted to devbr6
(http://trac.osgeo.org/grass/changeset/36220). The rest in progress...

Please can someone review unsubmitted part of the patch:

{{{
M raster/Makefile
M lib/g3d/g3dcache.c
M lib/g3d/g3dmask.c
M lib/gis/spawn.c
M lib/gis/Makefile
M lib/gis/gdal.c
M include/Make/Lib.make
M include/Make/Shlib.make
}}}

I don't feel enough familiar with building system in GRASS.

M.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/519#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

6

#519: osgeo4w build
----------------------+-----------------------------------------------------
  Reporter: jef | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: new
  Priority: major | Milestone: 6.4.0
Component: default | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Comment (by neteler):

I have reduced the attached patch to the outstanding items except for the
lib/g3d/g3dmask.c
  part which is only in the original submission. For that, see comment 1
above.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/519#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

7

#519: osgeo4w build
----------------------+-----------------------------------------------------
  Reporter: jef | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: new
  Priority: major | Milestone: 6.4.0
Component: default | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Comment (by neteler):

Patch reduced to outstanding items (with modification for
raster/Makefile). Left out lib/g3d/g3dmask.c as unclear how to write it
correctly (see first comment here). Please test + comment.

The other issues are in 6.4.0svn and 6.5svn now.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/519#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

8

On Sun, Mar 8, 2009 at 10:23 PM, GRASS GIS <trac@osgeo.org> wrote:

#519: osgeo4w build
----------------------+-----------------------------------------------------
Reporter: jef | Owner: grass-dev@lists.osgeo.org
Type: task | Status: new
Priority: major | Milestone: 6.4.0
Component: default | Version: svn-develbranch6
Resolution: | Keywords:
Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Comment (by neteler):

Patch reduced to outstanding items (with modification for
raster/Makefile). Left out lib/g3d/g3dmask.c as unclear how to write it
correctly (see first comment here). Please test + comment.

The other issues are in 6.4.0svn and 6.5svn now.

I would really appreciate feedback:
http://trac.osgeo.org/grass/attachment/ticket/519/mingw_updated3.diff

(plus lib/g3d/g3dmask.c, see ticket)

thanks
Markus

9

#519: osgeo4w build
----------------------+-----------------------------------------------------
  Reporter: jef | Owner: grass-dev@…
      Type: task | Status: closed
  Priority: major | Milestone: 6.4.0
Component: Default | Version: svn-develbranch6
Resolution: fixed | Keywords:
  Platform: All | Cpu: All
----------------------+-----------------------------------------------------
Changes (by hellik):

  * status: new => closed
  * resolution: => fixed

Comment:

Replying to [comment:6 neteler]:
> [...]
>
> The other issues are in 6.4.0svn and 6.5svn now.

  patches applied and a lot of fixes done in the last months.

  closing ticket, reopen if needed.

  Helmut

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/519#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>