[GRASS-dev] [GRASS GIS] #523: wxGUI: querying a vector map in edit mode does nothing

#523: wxGUI: querying a vector map in edit mode does nothing
----------------------+-----------------------------------------------------
Reporter: msieczka | Owner: grass-dev@lists.osgeo.org
     Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: wxGUI | Version: svn-develbranch6
Keywords: | Platform: All
      Cpu: All |
----------------------+-----------------------------------------------------
1. Load a vector map.

2. Zoom to it.

3. Query the map in "edit mode" - nothing happens. In vdigit query and
editing works.

SVN r36231.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
-----------------------+----------------------------------------------------
  Reporter: msieczka | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: wxGUI | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------
Comment (by martinl):

Seems to work for me. Can you post NC-based example?

Martin

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
-----------------------+----------------------------------------------------
  Reporter: msieczka | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: wxGUI | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------
Comment (by hellik):

Replying to [comment:1 martinl]:
> Seems to work for me. Can you post NC-based example?
>
> Martin

grass64rc3-3 (osgeo4w) - win vista
data nc-spm

     g.copy vect=lakes@PERMANENT,test

loading test in wx-gis-map-display

querying test map in edit mode => window for update attributes pop up

but submit a change for example in the field "FTYPE" (character) from
RESERVOIR to DAM

then following error message:

Traceback (most recent call last):
   File "C:\OSGeo4W\apps\grass\grass-6.4.0RC3\etc\wxpython\gu
i_modules\dbm.py", line 3101, in OnSubmit

"input=%s" % sqlFile.name])
   File "C:\OSGeo4W\apps\grass\grass-6.4.0RC3\etc\wxpython\gu
i_modules\gcmd.py", line 355, in __init__

_("Error: ") + self.GetError()))
gui_modules.gcmd
.
CmdError

Helmut

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
-----------------------+----------------------------------------------------
  Reporter: msieczka | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: wxGUI | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------
Comment (by msieczka):

Replying to [comment:1 martinl]:
> Seems to work for me. Can you post NC-based example?

Seems translation-related issue. I can reproduce it for any vector map,
but *only in Polish translation*. After "export LC_ALL=C" works fine.

Spearfish example:

1. start GRASS

2. add "streams" vector map

3. select it, "Zoom to selected map"

3. in "Map display" window: "Query raster/vector maps" > "Query vector map
(edit mode)"

4. left click a line on the map display - nothing happens

Querying vectors works fine though in "display mode" even in Polish
translation.

Reminds me of http://trac.osgeo.org/grass/ticket/427#comment:5. Are there
more such issues possible?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
-----------------------+----------------------------------------------------
  Reporter: msieczka | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: wxGUI | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------
Comment (by neteler):

I found this which looks suspicious:

{{{
  #: ../gui/wxpython/gui_modules/mapdisp.py:163
  msgid "Render"
-msgstr "_Renderuj"
+msgstr "Renderuj"
}}}

Could you fix that locally and regenerate the mo file?

Markus

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
-----------------------+----------------------------------------------------
  Reporter: msieczka | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: wxGUI | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------
Comment (by martinl):

Replying to [comment:2 hellik]:
> Traceback (most recent call last):
> File "C:\OSGeo4W\apps\grass\grass-6.4.0RC3\etc\wxpython\gu
> i_modules\dbm.py", line 3101, in OnSubmit
>
> "input=%s" % sqlFile.name])
> File "C:\OSGeo4W\apps\grass\grass-6.4.0RC3\etc\wxpython\gu
> i_modules\gcmd.py", line 355, in __init__
>
> _("Error: ") + self.GetError()))
> gui_modules.gcmd
> .
> CmdError

Fixed in r36377.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
-----------------------+----------------------------------------------------
  Reporter: msieczka | Owner: martinl
      Type: defect | Status: assigned
  Priority: major | Milestone: 6.4.0
Component: wxGUI | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------
Changes (by martinl):

  * status: new => assigned
  * owner: grass-dev@lists.osgeo.org => martinl
* cc: grass-dev@lists.osgeo.org (added)

Comment:

Replying to [comment:3 msieczka]:
> Seems translation-related issue. I can reproduce it for any vector map,
but *only in Polish translation*. After "export LC_ALL=C" works fine.

yes, it's problem with v.what. Temporally fixed in r36378. v.what should
have script-style output which is not based on used locales.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
-----------------------+----------------------------------------------------
  Reporter: msieczka | Owner: martinl
      Type: defect | Status: assigned
  Priority: major | Milestone: 6.4.0
Component: wxGUI | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------
Comment (by msieczka):

In r36380 the problem is still not fixed.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
-----------------------+----------------------------------------------------
  Reporter: msieczka | Owner: martinl
      Type: defect | Status: assigned
  Priority: major | Milestone: 6.4.0
Component: wxGUI | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------
Comment (by martinl):

Replying to [comment:7 msieczka]:
> In r36380 the problem is still not fixed.

{{{
export LC_ALL=pl_PL.utf8

grass65
}}}

  * add vector, zoom, query in edit mode

works. M.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523#comment:8&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
-----------------------+----------------------------------------------------
  Reporter: msieczka | Owner: martinl
      Type: defect | Status: assigned
  Priority: major | Milestone: 6.4.0
Component: wxGUI | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------
Comment (by msieczka):

Replying to [comment:8 martinl]:
> Replying to [comment:7 msieczka]:
> > In r36380 the problem is still not fixed.
>
> {{{
> export LC_ALL=pl_PL.utf8
>
> grass65
> }}}
>
> * add vector, zoom, query in edit mode
>
> works

True :). However, without explicit "export LC_ALL=pl_PL.utf8" it still
doesn't.

My default locale settings are:

{{{
$ locale
LANG=pl_PL.UTF-8
LC_CTYPE="pl_PL.UTF-8"
LC_NUMERIC="pl_PL.UTF-8"
LC_TIME="pl_PL.UTF-8"
LC_COLLATE="pl_PL.UTF-8"
LC_MONETARY="pl_PL.UTF-8"
LC_MESSAGES="pl_PL.UTF-8"
LC_PAPER="pl_PL.UTF-8"
LC_NAME="pl_PL.UTF-8"
LC_ADDRESS="pl_PL.UTF-8"
LC_TELEPHONE="pl_PL.UTF-8"
LC_MEASUREMENT="pl_PL.UTF-8"
LC_IDENTIFICATION="pl_PL.UTF-8"
LC_ALL=
}}}

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523#comment:9&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
-----------------------+----------------------------------------------------
  Reporter: msieczka | Owner: martinl
      Type: defect | Status: assigned
  Priority: major | Milestone: 6.4.0
Component: wxGUI | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
-----------------------+----------------------------------------------------
Comment (by glynn):

Replying to [comment:6 martinl]:

> > Seems translation-related issue. I can reproduce it for any vector
map, but *only in Polish translation*. After "export LC_ALL=C" works fine.
>
> yes, it's problem with v.what. Temporally fixed in r36378.

Not really; see comment:9. It also needs to set LC_MESSAGES.

BTW, the GUI should leave os.environ alone; pass env=... to Popen() to
control the environment for child processes.

> v.what should have script-style output which is not based on used
locales.

Agreed. Setting LC_MESSAGES is overkill (LC_ALL more so), as it will also
affect error messages meant for the user.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523#comment:10&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
---------------------------+------------------------------------------------
  Reporter: msieczka | Owner: martinl
      Type: defect | Status: assigned
  Priority: major | Milestone: 6.4.0
Component: Translations | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
---------------------------+------------------------------------------------
Changes (by cmbarton):

  * component: wxGUI => Translations

Comment:

It's not clear whether this is fixed or not. But in either case, it is not
a GUI problem but a problem with translations and and how they interact
with grass modules like v.what. I'm changing the component to
"translations". Maybe someone with another localization can see if it is
fixed or not.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523#comment:11&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
--------------------------+-------------------------------------------------
Reporter: msieczka | Owner: martinl
     Type: defect | Status: assigned
Priority: major | Milestone: 6.4.0
Component: Translations | Version: svn-develbranch6
Keywords: | Platform: All
      Cpu: All |
--------------------------+-------------------------------------------------

Comment(by martinl):

Asking the reporter, is this ticket still relevant to the recent version -
6.4.3svn?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/523#comment:12&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
---------------------------+------------------------------------------------
  Reporter: msieczka | Owner: martinl
      Type: defect | Status: closed
  Priority: major | Milestone: 6.4.0
Component: Translations | Version: svn-develbranch6
Resolution: worksforme | Keywords:
  Platform: All | Cpu: All
---------------------------+------------------------------------------------
Changes (by mlennert):

  * status: assigned => closed
  * resolution: => worksforme

Comment:

Replying to [comment:12 martinl]:
> Asking the reporter, is this ticket still relevant to the recent version
- 6.4.3svn?

As there has been no response for 10 months, I'm closing this ticket.

Moritz

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/523#comment:13&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
---------------------------+------------------------------------------------
  Reporter: msieczka | Owner: martinl
      Type: defect | Status: reopened
  Priority: major | Milestone: 6.4.0
Component: Translations | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
---------------------------+------------------------------------------------
Changes (by hamish):

  * status: closed => reopened
  * resolution: worksforme =>

Comment:

Please confirm bugs as fixed before closing them.

thanks, Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/523#comment:14&gt;
GRASS GIS <http://grass.osgeo.org>

#523: wxGUI: querying a vector map in edit mode does nothing
---------------------------+------------------------------------------------
  Reporter: msieczka | Owner: martinl
      Type: defect | Status: reopened
  Priority: major | Milestone: 6.4.0
Component: Translations | Version: svn-develbranch6
Resolution: | Keywords:
  Platform: All | Cpu: All
---------------------------+------------------------------------------------

Comment(by mlennert):

This was for 6.4.0 where wxgui was still an infant. Much of the layer
interrogation features has significantly changed since then.

I cannot reproduce these issues on Debian GNU/Linux (in GRASS7 there is no
interactive editing of attributes outside the digitiser, AFAIK).

Can someone test on Windows ?

Moritz

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/523#comment:15&gt;
GRASS GIS <http://grass.osgeo.org>