[GRASS-dev] [GRASS GIS] #545: r.cost warning on negative values

GRASS GRASS developer
1

#545: r.cost warning on negative values
-------------------------+--------------------------------------------------
Reporter: pcav | Owner: grass-dev@lists.osgeo.org
     Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: default | Version: 6.3.0
Keywords: | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
In case ov even a few negative values, r.cost fails badly (running
forever).
If the cost map contains any negative values, it should either
generate a fatal error, or treat such cells as nulls (exclude them or
use the null_cost= value) and generate a warning.
Thanks Glynn for the hint.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/545&gt;
GRASS GIS <http://grass.osgeo.org>

2

#545: r.cost warning on negative values
--------------------------+-------------------------------------------------
  Reporter: pcav | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: default | Version: 6.3.0
Resolution: | Keywords:
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Comment (by neteler):

Perhaps add a test in the NULL testing section
source:grass/trunk/raster/r.cost/main.c@35369#L397

?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/545#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

3

#545: r.cost warning on negative values
--------------------------+-------------------------------------------------
  Reporter: pcav | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: default | Version: 6.3.0
Resolution: | Keywords:
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Comment (by neteler):

Glynn: http://lists.osgeo.org/pipermail/grass-user/2009-April/049731.html

Patch proposal attached.

Markus

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/545#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

4

#545: r.cost warning on negative values
--------------------------+-------------------------------------------------
  Reporter: pcav | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.4.0
Component: Raster | Version: 6.3.0
Resolution: | Keywords: r.cost
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Changes (by martinl):

  * keywords: => r.cost
  * component: default => Raster

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/545#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

5

#545: r.cost warning on negative values
-------------------------+--------------------------------------------------
Reporter: pcav | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.3
Component: Raster | Version: 6.3.0
Keywords: r.cost | Platform: Unspecified
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by neteler):

  * milestone: 6.4.0 => 6.4.3

Comment:

Applied to GRASS 6.5.svn in r52740.
Needs to be backported to 6.4.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/545#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

6

#545: r.cost warning on negative values
--------------------------+-------------------------------------------------
  Reporter: pcav | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: major | Milestone: 6.4.3
Component: Raster | Version: 6.3.0
Resolution: fixed | Keywords: r.cost
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Changes (by mmetz):

  * status: new => closed
  * resolution: => fixed

Comment:

Replying to [comment:4 neteler]:
> Applied to GRASS 6.5.svn in r52740.
> Needs to be backported to 6.4.

Done in r52748, also for trunk in r52746.

Markus M

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/545#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>