[GRASS-dev] [GRASS GIS] #593: WinGRASS GIS.m: cannot select maps from other mapsets

#593: WinGRASS GIS.m: cannot select maps from other mapsets
----------------------------+-----------------------------------------------
Reporter: hamish | Owner: grass-dev@lists.osgeo.org
     Type: defect | Status: new
Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Keywords: wingrass gis.m | Platform: MSWindows XP
      Cpu: x86-32 |
----------------------------+-----------------------------------------------
Hi,

GIS.m on wingrass refuses to let you select maps from another mapset.

e.g. spearfish, from the user1 mapset:
  - start gis.m
  - click the button to add a new raster map
  - click the button at the left of the map name entry box to open the map
list GUI
  - only the user1 folder is open, the PERMANENT folder will not open.
  - type elevation.dem@PERMANENT by hand and it works.

?,
Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/593&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from other mapsets
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Comment (by hamish):

ah, the little [+] [-] boxes to expand the folders are missing on wingrass
for some reason. so the PERMANENT folder stays permanently closed.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/593#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Changes (by hamish):

  * summary: WinGRASS GIS.m: cannot select maps from other mapsets =>
              WinGRASS GIS.m: cannot select maps from mapset
              GUI

Comment:

you can't select maps from the current mapset either. see #637

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/593#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Changes (by hamish):

* cc: grass-dev@lists.osgeo.org (added)

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/593#comment:9&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Comment (by hamish):

(leave open until everything is backported & job is done)

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/593#comment:10&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Comment (by marisn):

Thanks Hamish for spotting my oversight with mapset.

$path in select.tcl seems to work just fine without quotes (no idea why -
must be something of tcl beloved lists vs strings), still there was
another issue with running anything if GISBASE contains spaces. Fixed in
r38311. Also an candidate for 6.4.0.

Leaving open till it's tested and backported.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/593#comment:11&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Comment (by cmbarton):

Works fine in GRASS 6.4 and 6.5 svn on Mac OS X.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/593#comment:12&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Comment (by hamish):

Replying to [comment:12 cmbarton]:
> Works fine in GRASS 6.4 and 6.5 svn on Mac OS X.

yeah, it's only on WinGrass. I think Maris committed a fix for this in
6.5svn, but it awaits review & backporting by someone who understands Tcl
better than I do.

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/593#comment:13&gt;
GRASS GIS <http://grass.osgeo.org>

Hamish

- are sure this is still a problem - I am at home now so I cannot test winGRASS until Monday,
but we have been using winGRASSRC5 for 3 weeks and haven't seen the problem.
maybe somebody with winGRASS on hand can check whether this is still an issue.

Helena

On Sep 11, 2009, at 4:37 AM, GRASS GIS wrote:

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Comment (by hamish):

Replying to [comment:12 cmbarton]:

Works fine in GRASS 6.4 and 6.5 svn on Mac OS X.

yeah, it's only on WinGrass. I think Maris committed a fix for this in
6.5svn, but it awaits review & backporting by someone who understands Tcl
better than I do.

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/593#comment:13&gt;
GRASS GIS <http://grass.osgeo.org>
_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Changes (by cmbarton):

* cc: maris.gis@gmail.com (added)

Comment:

I can't test this on windows unless I have a binary to give to one of my
students who uses windows. I've been out of the loop for awhile. But if
Maris can give me the fix, I can manually insert it into a 6.4 Windows
binary and see if it works.

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/593#comment:14&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Comment (by hellik):

grass65 selfcompiled in the osgeo4w-stack on WinVista32
rev39115
nc-dataset
mapset: user1

there's no problem to choose a vector or raster from another mapset like
PERMANENT in the nc-dataset. i've tried this with spaces (C:\gis
data\grassdata) and without spaces (C:\gisdata\grassdata) in the path to
the location.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/593#comment:15&gt;
GRASS GIS <http://grass.osgeo.org>

Helena wrote:

- are sure this is still a problem - I am at home now so I
cannot test winGRASS until Monday, but we have been using
winGRASSRC5 for 3 weeks and haven't seen the problem.

It is with the tcltk/gis.m GUI, not the wxpython GUI.

Hamish

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Comment (by hellik):

Replying to [comment:15 hellik]:
> grass65 selfcompiled in the osgeo4w-stack on WinVista32
> rev39115
> nc-dataset
> mapset: user1
>
> there's no problem to choose a vector or raster from another mapset like
PERMANENT in the nc-dataset. i've tried this with spaces (C:\gis
data\grassdata) and without spaces (C:\gisdata\grassdata) in the path to
the location.

tested in the tcltk/gis.m GUI

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/593#comment:16&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Comment (by cmbarton):

Is this relevant anymore? If the problem is

1) with the TclTk GUI and not wxpython,
2) only in Windows, and
3) if wxpython is the default GUI for WinGRASS 6.4,

do we need to worry about it?

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/593#comment:17&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Comment (by hamish):

Replying to [comment:17 cmbarton]:
> Is this relevant anymore?

To me, yes. Others are of course free to decide that for themselves and
spend their time worrying about issues they find more interesting, as they
like.

bugs we know about should be fixed. especially ones that cripple an entire
subsystem. anyway, this is just a small backport, not a huge investment
in/redirection of effort. The larger problem on spaces in path names is of
course another matter. I'm still a bit frustrated that the MSys devs won't
even take patches for this class of bug.

I would also note that making things more robust on WinGrass typically has
the byproduct of making thinks slightly more robust on other platforms as
well.

Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/593#comment:18&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Comment (by cmbarton):

If it's just a backport, I'm definitely in favor doing this.

Like I said, I can probably stick a TclTk patch into a student's 6.4
Windows binary to test this if it is a help. To do this on Windows,
however, it will be much easier if I get the entire patched tcltk module
instead of a patch file.

Michael

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/593#comment:19&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: reopened
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Comment (by marisn):

Please test r39149.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/593#comment:20&gt;
GRASS GIS <http://grass.osgeo.org>

#593: WinGRASS GIS.m: cannot select maps from mapset GUI
---------------------------+------------------------------------------------
  Reporter: hamish | Owner: marisn
      Type: defect | Status: closed
  Priority: critical | Milestone: 6.4.0
Component: Tcl | Version: 6.4.0 RCs
Resolution: fixed | Keywords: wingrass gis.m
  Platform: MSWindows XP | Cpu: x86-32
---------------------------+------------------------------------------------
Changes (by hamish):

  * status: reopened => closed
  * resolution: => fixed

Comment:

tested in latest WinGrass 6.4 installer (WinGRASS-6.4.0SVN-
r39271-1-Setup.exe).

works; closing bug.

(it complains that it can't find the fontcap file though)

thanks,
Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/593#comment:21&gt;
GRASS GIS <http://grass.osgeo.org>