[GRASS-dev] GRASS GIS 7.0.1 planning: potential backports

Hi,

I have been trying to track potential backports:

* v.in.ogr: backport island recognition message (sync geom.c, main.c
and v.in.ogr.html)
* v.select: code optimization, no bug fix
* r64993 - grass/trunk/gui/wxpython/vnet - Author: turek Date: 2015-04-06
* r64979 - grass/trunk/gui/wxpython/vnet - Author: turek Date: 2015-04-02
* r64898 - grass/trunk/scripts/r.unpack - Author: lucadelu Date: 2015-03-24
* r64895 - grass/trunk/raster/r.li: . r.li.daemon - Author: wenzeslaus
Date: 2015-03-23
* r64854 - grass/trunk/gui/wxpython/lmgr - Author: wenzeslaus Date: 2015-03-14
* r64783 - grass/trunk/vector/v.vol.rst - Author: annakrat Date: 2015-03-02
* r64630 - grass/trunk/vector/v.net - Author: neteler Date: 2015-02-14
* r64470 - grass/trunk/lib/python/temporal - Author: huhabla Date: 2015-02-05
* r64226 - grass/trunk: gui/xml lib/gis - Author: glynn Date: 2015-01-16
* r63543 - grass/trunk/lib/btree2 - Author: mmetz Date: 2014-12-14
* r63378 - grass/trunk/raster/r.in.gdal - Author: mmetz Date: 2014-12-05
* r63374 - grass/trunk/lib/init - Author: martinl Date: 2014-12-05
* r63369 - grass/trunk/lib/python/docs/src - Author: wenzeslaus Date: 2014-12-04
* r63361 - grass/trunk/lib/display - Author: glynn Date: 2014-12-03
* r63308 - grass/trunk/lib/gis - Author: mmetz Date: 2014-11-30
* r63238 - grass/trunk: db/drivers/sqlite scripts/v.db.update -
Author: neteler Date: 2014-11-28
* r63194 - grass/trunk/scripts/i.tasscap - Author: neteler Date: 2014-11-27
* r62026 - grass/trunk: display/d.info include/defs lib/display -
neteler Date: 2014-09-17
* r63077 - grass/trunk/gui/wxpython/vdigit - Author: mmetz Date: 2014-11-26
* r62904 - grass/trunk/lib/gis - Author: martinl Date: 2014-11-25
* r62850 - grass/trunk/general/g.parser - Author: glynn Date: 2014-11-21
* r62828 - grass/trunk: display/d.his raster/r.his - Author:
wenzeslaus Date: 2014-11-19
* r62776 - grass/trunk/lib/gis - Author: mmetz Date: 2014-11-17
* r62756 - grass/trunk/lib/gis - Author: martinl Date: 2014-11-16
* r62709 - grass/trunk/lib/python/script - Author: wenzeslaus Date: 2014-11-11

This list is incomplete, especially concerning the wxGUI and PyGRASS.

Also tracked here:
https://trac.osgeo.org/grass/wiki/Grass7Planning#a7.0.1tobebackported

Please check, backport where reasonable and delete from the trac Wiki list.

We should consider to prepare 7.0.1 in a some weeks time.

thanks
Markus

On Tue, Apr 7, 2015 at 2:36 PM, Markus Neteler <neteler@osgeo.org> wrote:

Hi,

I have been trying to track potential backports:

...

https://trac.osgeo.org/grass/wiki/Grass7Planning#a7.0.1tobebackported

This list is incomplete, especially concerning the wxGUI and PyGRASS.

The respective authors: please check, backport where reasonable and
delete from the trac Wiki list.

Markus

Hi,

2015-04-07 14:36 GMT+02:00 Markus Neteler <neteler@osgeo.org>:-05

* r63374 - grass/trunk/lib/init - Author: martinl Date: 2014-12-05

with respect to bugfix-only backports, this is a new feature

* r62756 - grass/trunk/lib/gis - Author: martinl Date: 2014-11-16
* r62904 - lib/gis - Author: martinl Date: 2014-11-25

Candidates for backport (putting them to my TODO list)

Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

Hi,

let's get 7.0.1RC1 out soon...! But...

On Sat, May 2, 2015 at 10:54 PM, Markus Neteler <neteler@osgeo.org> wrote:

On Tue, Apr 7, 2015 at 2:36 PM, Markus Neteler <neteler@osgeo.org> wrote:

https://trac.osgeo.org/grass/wiki/Grass7Planning#a7.0.1tobebackported

This list is incomplete, especially concerning the wxGUI and PyGRASS.

The respective authors: please check, backport where reasonable and
delete from the trac Wiki list.

... please go through the list.

thanks
Markus

Hi,

2015-06-04 20:55 GMT+02:00 Markus Neteler <neteler@osgeo.org>:

... please go through the list.

I tried to cleanup the list, what I cannot judge is (by authors):

mmetz:

https://trac.osgeo.org/grass/changeset/62091 (I would say no for
backport, no bug-fix, 2 cents)
https://trac.osgeo.org/grass/changeset/63543 (probably harmless)
https://trac.osgeo.org/grass/changeset/63378 (bug-fix, probably should
be backported)
https://trac.osgeo.org/grass/changeset/63308 (probably no, it's not bug-fix)
https://trac.osgeo.org/grass/changeset/63077 (probably yes)
https://trac.osgeo.org/grass/changeset/62776 (probably no, it's not bug-fix)

glynn:

https://trac.osgeo.org/grass/changeset/64834 (no idea)
https://trac.osgeo.org/grass/changeset/64226 (probably no, it's not bug-fix)
https://trac.osgeo.org/grass/changeset/63361 (I would say no, heavy
changes in trunk)
https://trac.osgeo.org/grass/changeset/62026 (probably no, it's not bug-fix?)
https://trac.osgeo.org/grass/changeset/62850 (no idea, probably not)

lucadelu:

https://trac.osgeo.org/grass/changeset/64898 (no idea)

huhabla:

https://trac.osgeo.org/grass/changeset/64470 (probably yes?)

neteler:

https://trac.osgeo.org/grass/changeset/63238 (probably no, it's not bug-fix)

I can do backports when I receive any feedback. These backports are
long-standing issue (since beginning of April). My suggestion is to
mark RC1 tomorrow if possible...

Thanks for collaboration! Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

On Fri, Jun 5, 2015 at 4:17 PM, Martin Landa <landa.martin@gmail.com> wrote:

Hi,

2015-06-04 20:55 GMT+02:00 Markus Neteler <neteler@osgeo.org>:

... please go through the list.

https://trac.osgeo.org/grass/wiki/Grass7Planning#a7.0.1tobebackported

The updated list is now way shorter. I went through a lot of commits
locally flagged as "backport" in my inbox and also checked those on
above list.

AFAIK remain now:

r65343 - vector/v.random/main.c: martinl Date: 2015-05-31
r62091 - vector/v.select: speed up OP_OVERLAP - Author: mmetz 2014-09-26
r64834 - lib/python/script/core.py - Author: glynn Date: 2015-03-11
(Attempt to fix gettext behaviour (issue #2617))

?

Markus

On 07/06/15 23:10, Markus Neteler wrote:

On Fri, Jun 5, 2015 at 4:17 PM, Martin Landa <landa.martin@gmail.com> wrote:

Hi,

2015-06-04 20:55 GMT+02:00 Markus Neteler <neteler@osgeo.org>:

... please go through the list.

https://trac.osgeo.org/grass/wiki/Grass7Planning#a7.0.1tobebackported

The updated list is now way shorter. I went through a lot of commits
locally flagged as "backport" in my inbox and also checked those on
above list.

AFAIK remain now:

r65343 - vector/v.random/main.c: martinl Date: 2015-05-31

I don't see how this can create any problems, and it does solve the one of having a link to a non-existing table, so I would say +1 for backport.

r62091 - vector/v.select: speed up OP_OVERLAP - Author: mmetz 2014-09-26

I've only tested this very briefly, but results seem identical and the speedup is very significant, so I would plead for backport, but MarkusM should have the last word on this.

r64834 - lib/python/script/core.py - Author: glynn Date: 2015-03-11

No idea on this particular fix, but I have the feeling that the whole encoding handling could need a serious overall reflection with a clear definition of coding rules. AFAIU, at this stage we have different "solutions" across the code and that none are really satisfactory, especially as none is really implemented in a global and unified way.

Moritz

On Mon, Jun 8, 2015 at 8:51 AM, Moritz Lennert
<mlennert@club.worldonline.be> wrote:

On 07/06/15 23:10, Markus Neteler wrote:

On Fri, Jun 5, 2015 at 4:17 PM, Martin Landa <landa.martin@gmail.com>
wrote:

Hi,

2015-06-04 20:55 GMT+02:00 Markus Neteler <neteler@osgeo.org>:

... please go through the list.

https://trac.osgeo.org/grass/wiki/Grass7Planning#a7.0.1tobebackported

The updated list is now way shorter. I went through a lot of commits
locally flagged as "backport" in my inbox and also checked those on
above list.

AFAIK remain now:

r65343 - vector/v.random/main.c: martinl Date: 2015-05-31

I don't see how this can create any problems, and it does solve the one of
having a link to a non-existing table, so I would say +1 for backport.

+1 also here

r62091 - vector/v.select: speed up OP_OVERLAP - Author: mmetz 2014-09-26

I've only tested this very briefly, but results seem identical and the
speedup is very significant, so I would plead for backport, but MarkusM
should have the last word on this.

.. I just locally backported, it also needs
https://trac.osgeo.org/grass/changeset/62045

r64834 - lib/python/script/core.py - Author: glynn Date: 2015-03-11

No idea on this particular fix, but I have the feeling that the whole
encoding handling could need a serious overall reflection with a clear
definition of coding rules. AFAIU, at this stage we have different
"solutions" across the code and that none are really satisfactory,
especially as none is really implemented in a global and unified way.

Agreed.

Markus

On 08/06/15 14:27, Markus Neteler wrote:

On Mon, Jun 8, 2015 at 8:51 AM, Moritz Lennert
<mlennert@club.worldonline.be> wrote:

On 07/06/15 23:10, Markus Neteler wrote:

r62091 - vector/v.select: speed up OP_OVERLAP - Author: mmetz 2014-09-26

I've only tested this very briefly, but results seem identical and the
speedup is very significant, so I would plead for backport, but MarkusM
should have the last word on this.

.. I just locally backported, it also needs
https://trac.osgeo.org/grass/changeset/62045

Ah, this does look quite heavy, indeed. Has anyone else had time to test ?

No news from MarkusM ?

Moritz

On Mon, Jun 8, 2015 at 3:05 PM, Moritz Lennert
<mlennert@club.worldonline.be> wrote:

On 08/06/15 14:27, Markus Neteler wrote:

On Mon, Jun 8, 2015 at 8:51 AM, Moritz Lennert
<mlennert@club.worldonline.be> wrote:

On 07/06/15 23:10, Markus Neteler wrote:

r62091 - vector/v.select: speed up OP_OVERLAP - Author: mmetz 2014-09-26

I've only tested this very briefly, but results seem identical and the
speedup is very significant, so I would plead for backport, but MarkusM
should have the last word on this.

.. I just locally backported, it also needs
https://trac.osgeo.org/grass/changeset/62045

Ah, this does look quite heavy, indeed. Has anyone else had time to test ?

Yes, I am testing (and it has been in place since Sept 2014).

Here the comparison, in GRASS 7.0.1svn (nc_spm_08_grass7):~ >

# old version:
v.buffer input=railroads output=railroads_buf20m distance=20

time -p v.select ainput=zipcodes_wake binput=railroads_buf20m
output=zipcodes_wake_railroads operator=overlap
v.select complete. 171 features written to output.
real 125.23
user 82.05
sys 42.61

#########
# new version

v.buffer input=railroads output=railroads_buf20m distance=20

time -p v.select ainput=zipcodes_wake binput=railroads_buf20m
output=zipcodes_wake_railroads operator=overlap
v.select complete. 171 features written to output.
real 6.72
user 4.42
sys 2.03

6.72/125.23 = 0.05366126

It is *quite* faster!

No news from MarkusM ?

No.

markusN

On Mon, Jun 8, 2015 at 3:15 PM, Markus Neteler <neteler@osgeo.org> wrote:
...

Yes, I am testing (and it has been in place since Sept 2014).

Here the comparison, in GRASS 7.0.1svn (nc_spm_08_grass7):~ >

...

6.72/125.23 = 0.05366126

It is *quite* faster!

Backported as r65423.

Remains for RC1:

r65343 - vector/v.random/main.c: martinl Date: 2015-05-31
r64404 - libpython: move cmd list <-> tuple from wxGUI: martinl Date:
Feb 2, 2015
r64834 - lib/python/script/core.py: fix gettext behaviour - Author:
glynn Date: 2015-03-11

Markus

Hi,

2015-06-08 14:27 GMT+02:00 Markus Neteler <neteler@osgeo.org>:

AFAIK remain now:

r65343 - vector/v.random/main.c: martinl Date: 2015-05-31

I don't see how this can create any problems, and it does solve the one of
having a link to a non-existing table, so I would say +1 for backport.

+1 also here

backported 65424. Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

Hi,

2015-06-08 23:37 GMT+02:00 Markus Neteler <neteler@osgeo.org>:

r64404 - libpython: move cmd list <-> tuple from wxGUI: martinl Date:
Feb 2, 2015

then we should also backport r64406 and probably others, it's seems to
me that it's not necessary to backport these changes.

Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

On Mon, Jun 8, 2015 at 11:50 PM, Martin Landa <landa.martin@gmail.com> wrote:

Hi,

2015-06-08 23:37 GMT+02:00 Markus Neteler <neteler@osgeo.org>:

r64404 - libpython: move cmd list <-> tuple from wxGUI: martinl Date:
Feb 2, 2015

then we should also backport r64406 and probably others, it's seems to
me that it's not necessary to backport these changes.

ok - I cannot judge and GUI is always a weak thing with all the Python
portability issues...
I earlier just skimmed through my list of flagged commits.

Markus

Hi,

2015-06-08 23:52 GMT+02:00 Markus Neteler <neteler@osgeo.org>:

then we should also backport r64406 and probably others, it's seems to
me that it's not necessary to backport these changes.

ok - I cannot judge and GUI is always a weak thing with all the Python
portability issues...
I earlier just skimmed through my list of flagged commits.

my suggestion is to backport it immediately after we release 7.0.1
[1], to have time to do more tests. I will do it. Martin

[1] https://trac.osgeo.org/grass/wiki/Grass7Planning#a7.0.2tobebackported

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

What is the status of r65057, #2626, and #2655?

In 70 release branch, I’m not able to use PostgreSQL attribute table but it works in trunk. I think that this is thanks to r65057. The bug was probably also reason for encountering #2626.

Thanks,

Vaclav

db.login + pg & mysql driver: support hostname and port
https://trac.osgeo.org/grass/changeset/65057

v.out.ogr does not suggest db.connect and db.login when not set
http://trac.osgeo.org/grass/ticket/2626

update t.connect to use db.login host= port=
https://trac.osgeo.org/grass/ticket/2655

[GRASS-dev] [GRASS-SVN] r65057 - in grass/trunk/db: db.login drivers/mysql drivers/postgres
http://lists.osgeo.org/pipermail/grass-commit/2015-April/035962.html
http://lists.osgeo.org/pipermail/grass-dev/2015-April/074808.html

On Tue, Jun 9, 2015 at 10:21 PM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

What is the status of r65057, #2626, and #2655?

I have added it to
https://trac.osgeo.org/grass/wiki/Grass7Planning#a7.0.1tobebackported

It would be important to get RC1 asap out.

Markus

In 70 release branch, I'm not able to use PostgreSQL attribute table but it
works in trunk. I think that this is thanks to r65057. The bug was probably
also reason for encountering #2626.

Thanks,
Vaclav

db.login + pg & mysql driver: support hostname and port
https://trac.osgeo.org/grass/changeset/65057

v.out.ogr does not suggest db.connect and db.login when not set
http://trac.osgeo.org/grass/ticket/2626

update t.connect to use db.login host= port=
https://trac.osgeo.org/grass/ticket/2655

[GRASS-dev] [GRASS-SVN] r65057 - in grass/trunk/db: db.login drivers/mysql
drivers/postgres
http://lists.osgeo.org/pipermail/grass-commit/2015-April/035962.html
http://lists.osgeo.org/pipermail/grass-dev/2015-April/074808.html

Hi,

2015-06-12 16:14 GMT+02:00 Markus Neteler <neteler@osgeo.org>:

On Tue, Jun 9, 2015 at 10:21 PM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

What is the status of r65057, #2626, and #2655?

I have added it to
https://trac.osgeo.org/grass/wiki/Grass7Planning#a7.0.1tobebackported

it's not critical, I moved this task to 7.0.2.

It would be important to get RC1 asap out.

+1^n

Ma

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

Markus Neteler wrote

On Tue, Jun 9, 2015 at 10:21 PM, Vaclav Petras &lt;

wenzeslaus@

&gt; wrote:

What is the status of r65057, #2626, and #2655?

I have added it to
https://trac.osgeo.org/grass/wiki/Grass7Planning#a7.0.1tobebackported

for r65440 in #2448 needs testing on Windows

see https://trac.osgeo.org/grass/ticket/2448#comment:23

-------------
tested locally here in a simple windows command line (outside any winGRASS
session, not in a OSGeo4W-command line):

C:\Users\xxxx>set GISBASE=C:\OSGeo4W_use\apps\grass\grass-7.0.0
C:\Users\xxxx>set
FREETYPEBASE=C:\OSGeo4W_use\bin;C:\OSGeo4W_use\apps\msys\bin;C:\OSGeo4W_use\apps\grass\grass-7.0.0\lib
C:\Users\xxxx>set PATH=%FREETYPEBASE%;%PATH%
C:\Users\xxxx>set GISRC=dummy
C:\Users\xxxx>"%GISBASE%\bin\g.mkfontcap.exe" -o
-------------

it works.

+1 for backporting

-----
best regards
Helmut
--
View this message in context: http://osgeo-org.1560.x6.nabble.com/GRASS-GIS-7-0-1-planning-potential-backports-tp5200227p5210721.html
Sent from the Grass - Dev mailing list archive at Nabble.com.

Hi,

2015-06-12 23:14 GMT+02:00 Helmut Kudrnovsky <hellik@web.de>:

there is still r64834 to marked for backport [1]. Does anybody here
option about that?

Thanks Martin

[1] https://trac.osgeo.org/grass/wiki/Grass7Planning#a7.0.1tobebackported

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa