[GRASS-dev] [GRASS GIS] #715: OSGeo4W patch for DLLs

GRASS GIS GRASS GIS developer
1

#715: OSGeo4W patch for DLLs
----------------------+-----------------------------------------------------
Reporter: neteler | Owner: grass-dev@lists.osgeo.org
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.0
Component: default | Version: 6.4.0 RCs
Keywords: wingrass | Platform: MSWindows XP
      Cpu: All |
----------------------+-----------------------------------------------------
Attached patch was submitted by Juergen Fischer, please review.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/715&gt;
GRASS GIS <http://grass.osgeo.org>

2

#715: OSGeo4W patch for DLLs
---------------------------+------------------------------------------------
  Reporter: neteler | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: normal | Milestone: 6.4.0
Component: default | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass
  Platform: MSWindows XP | Cpu: All
---------------------------+------------------------------------------------
Changes (by neteler):

* cc: jef (added)

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/715#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

3

#715: OSGeo4W patch for DLLs
---------------------------+------------------------------------------------
  Reporter: neteler | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: normal | Milestone: 6.4.0
Component: default | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass
  Platform: MSWindows XP | Cpu: All
---------------------------+------------------------------------------------
Comment (by glynn):

Replying to [ticket:715 neteler]:
> Attached patch was submitted by Juergen Fischer, please review.

Is there some reason that Shlib.make and Stlib.make can't use
ARCH_CMD_OBJS, so that Makefiles can just override MOD_OBJS if they don't
want the default?

Failing that, Lib.make should use similar logic to Rules.make, i.e. only
define the variables if they aren't already defined.

Either way, Lib.make should not contain references to specific files
(fmode.o and dllmain.o).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/715#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

4

#715: OSGeo4W patch for DLLs
---------------------------+------------------------------------------------
  Reporter: neteler | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: normal | Milestone: 6.4.0
Component: default | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass
  Platform: MSWindows XP | Cpu: All
---------------------------+------------------------------------------------
Comment (by neteler):

jef: any suggestions for us?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/715#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

5

#715: OSGeo4W patch for DLLs
---------------------------+------------------------------------------------
  Reporter: neteler | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: normal | Milestone: 6.4.0
Component: default | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass
  Platform: MSWindows XP | Cpu: All
---------------------------+------------------------------------------------
Comment (by jef):

The point is just that the DLLs need to be linked with {{{dllmain.o}}} and
the executables with {{{fmode.o}}}.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/715#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

6

#715: OSGeo4W patch for DLLs
---------------------------+------------------------------------------------
  Reporter: neteler | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: normal | Milestone: 6.4.0
Component: default | Version: 6.4.0 RCs
Resolution: | Keywords: wingrass, osgeo4w
  Platform: MSWindows XP | Cpu: All
---------------------------+------------------------------------------------
Changes (by neteler):

  * keywords: wingrass => wingrass, osgeo4w

Comment:

Jef, is the patch still needed?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/715#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

7

#715: OSGeo4W patch for DLLs
-------------------------------+--------------------------------------------
Reporter: neteler | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.0
Component: Default | Version: 6.4.0 RCs
Keywords: wingrass, osgeo4w | Platform: MSWindows XP
      Cpu: All |
-------------------------------+--------------------------------------------

Comment(by neteler):

Related (?) fix in G7: r43279

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/715#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

8

#715: OSGeo4W patch for DLLs
-------------------------------+--------------------------------------------
Reporter: neteler | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.0
Component: Default | Version: 6.4.0 RCs
Keywords: wingrass, osgeo4w | Platform: MSWindows XP
      Cpu: All |
-------------------------------+--------------------------------------------

Comment(by hamish):

still relevant?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/715#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>

9

#715: OSGeo4W patch for DLLs
-------------------------------+--------------------------------------------
Reporter: neteler | Owner: grass-dev@…
     Type: defect | Status: new
Priority: normal | Milestone: 6.4.0
Component: Default | Version: 6.4.0 RCs
Keywords: wingrass, osgeo4w | Platform: MSWindows XP
      Cpu: All |
-------------------------------+--------------------------------------------

Comment(by neteler):

See also ticket #469

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/715#comment:8&gt;
GRASS GIS <http://grass.osgeo.org>

10

#715: OSGeo4W patch for DLLs
---------------------------+------------------------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: normal | Milestone: 6.4.0
Component: Default | Version: 6.4.0 RCs
Resolution: fixed | Keywords: wingrass, osgeo4w
  Platform: MSWindows XP | Cpu: All
---------------------------+------------------------------------------------
Changes (by neteler):

  * status: new => closed
  * resolution: => fixed

Comment:

Since no user complaints have been collected, closing for now.

(See also GRASS 6.4.svn (r35767, r35769) and 6.4.0svn (r35768, r35770)
from #469)

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/715#comment:9&gt;
GRASS GIS <http://grass.osgeo.org>