#721: r.li.setup: don't modify the WIND file
--------------------+-------------------------------------------------------
Reporter: hamish | Owner: grass-dev@lists.osgeo.org
Type: defect | Status: new
Priority: normal | Milestone: 6.4.0
Component: Raster | Version: 6.4.0 RCs
Keywords: r.li | Platform: All
Cpu: All |
--------------------+-------------------------------------------------------
Hi,
when you create a sampling window with the mouse in r.li.setup it changes
the current region. It should act like v.digit (tcl version) and only do
that internally/in memory or by using GRASS_REGION or WIND_OVERRIDE.
Besides adding WIND_OVERRIDE, I have started cleaning up the many unquoted
variables in r.li.setup, and replacing tiny tmp files with shell script
backticks, but before going too far wonder what the future of it is for
trunk? Was someone working on a python upgrade?
I'd note it uses Xmons, shell scripts, tcltk, and IIRC unix sockets(?), so
not especially tuned for grass7.
#721: r.li.setup: don't modify the WIND file
----------------------------------------+-----------------------------------
Reporter: hamish | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 6.4.4
Component: Raster | Version: 6.4.0 RCs
Keywords: r.li, g.region, r.li.setup | Platform: All
Cpu: All |
----------------------------------------+-----------------------------------
Changes (by hamish):
* milestone: 6.4.3 => 6.4.4
Comment:
Hi, this is now complete in devbr6.
trunk is continued in #421. backport to relbr64 is todo.
One remaining thing to check for G6 r.li.setup is if there are places in
the tcl code which need "quoting" around filename variables which may
contain spaces. (e.g. path to temp files)
If regular tcl variables are ok(?) there are still some `exec` statements
which could need checking.
(Another thing to check is that temp files in the r.li.setup tcl code
always get written into a temp dir instead of the `pwd`)